Re: [PATCH 6/15] dt-bindings: display: sun4i: Add HDMI display bindings
On Tue, Mar 7, 2017 at 4:56 PM, Maxime Ripard wrote: > One of the possible output of the display pipeline, on the SoCs that have > it, is the HDMI controller. > > Add a binding for it. > > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 21 +++- > 1 file changed, 21 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > index b82c00449468..4b280672658e 100644 > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > @@ -4,6 +4,27 @@ Allwinner A10 Display Pipeline > The Allwinner A10 Display pipeline is composed of several components > that are going to be documented below: > > +HDMI Encoder > + > + > +The HDMI Encoder supports the HDMI video and audio outputs, and does > +CEC. It is one end of the pipeline. > + > +Required properties: > + - compatible: value must be one of: > +* allwinner,sun5i-a10s-hdmi > + - reg: base address and size of memory-mapped region > + - clocks: phandles to the clocks feeding the HDMI encoder > +* ahb: the HDMI interface clock > +* mod: the HDMI module clock > +* pll-0: the first video PLL > +* pll-1: the second video PLL > + - clock-names: the clock names mentioned above The audio part needs a DMA handle. May we add this from day one? Thanks ChenYu > + > + - ports: A ports node with endpoint definitions as defined in > +Documentation/devicetree/bindings/media/video-interfaces.txt. The > +first port should be the input endpoint. > + > TV Encoder > -- > > -- > git-series 0.8.11
Re: [PATCH 6/15] dt-bindings: display: sun4i: Add HDMI display bindings
Hi Rob, On Wed, Mar 15, 2017 at 12:26:22PM -0500, Rob Herring wrote: > > +HDMI Encoder > > + > > + > > +The HDMI Encoder supports the HDMI video and audio outputs, and does > > +CEC. It is one end of the pipeline. > > + > > +Required properties: > > + - compatible: value must be one of: > > +* allwinner,sun5i-a10s-hdmi > > + - reg: base address and size of memory-mapped region > > + - clocks: phandles to the clocks feeding the HDMI encoder > > +* ahb: the HDMI interface clock > > +* mod: the HDMI module clock > > +* pll-0: the first video PLL > > +* pll-1: the second video PLL > > + - clock-names: the clock names mentioned above > > + > > + - ports: A ports node with endpoint definitions as defined in > > +Documentation/devicetree/bindings/media/video-interfaces.txt. The > > +first port should be the input endpoint. > > You need an output port to an HDMI connector node and an audio port. I started to look at the audio, and I can't find a use for an audio port in the OF graph. As far as I understand, we will be using the hdmi-codec, that still requires an ASoC card to create the link between our i2s controller and the HDMI controller. This work perfectly for us, but as far as I know, the simple-card stuff only requires a phandle, and not an OF graph endpoint, right? Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com signature.asc Description: PGP signature
Re: [PATCH 6/15] dt-bindings: display: sun4i: Add HDMI display bindings
On Tue, Mar 07, 2017 at 09:56:25AM +0100, Maxime Ripard wrote: > One of the possible output of the display pipeline, on the SoCs that have > it, is the HDMI controller. > > Add a binding for it. > > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 21 +++- > 1 file changed, 21 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > index b82c00449468..4b280672658e 100644 > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > @@ -4,6 +4,27 @@ Allwinner A10 Display Pipeline > The Allwinner A10 Display pipeline is composed of several components > that are going to be documented below: > > +HDMI Encoder > + > + > +The HDMI Encoder supports the HDMI video and audio outputs, and does > +CEC. It is one end of the pipeline. > + > +Required properties: > + - compatible: value must be one of: > +* allwinner,sun5i-a10s-hdmi > + - reg: base address and size of memory-mapped region > + - clocks: phandles to the clocks feeding the HDMI encoder > +* ahb: the HDMI interface clock > +* mod: the HDMI module clock > +* pll-0: the first video PLL > +* pll-1: the second video PLL > + - clock-names: the clock names mentioned above > + > + - ports: A ports node with endpoint definitions as defined in > +Documentation/devicetree/bindings/media/video-interfaces.txt. The > +first port should be the input endpoint. You need an output port to an HDMI connector node and an audio port. > + > TV Encoder > -- > > -- > git-series 0.8.11
Re: [PATCH 6/15] dt-bindings: display: sun4i: Add HDMI display bindings
On Tue, Mar 7, 2017 at 4:56 PM, Maxime Ripard wrote: > One of the possible output of the display pipeline, on the SoCs that have > it, is the HDMI controller. > > Add a binding for it. > > Signed-off-by: Maxime Ripard Acked-by: Chen-Yu Tsai TODO: A31 will also need a DDC clock.
[PATCH 6/15] dt-bindings: display: sun4i: Add HDMI display bindings
One of the possible output of the display pipeline, on the SoCs that have it, is the HDMI controller. Add a binding for it. Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 21 +++- 1 file changed, 21 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt index b82c00449468..4b280672658e 100644 --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt @@ -4,6 +4,27 @@ Allwinner A10 Display Pipeline The Allwinner A10 Display pipeline is composed of several components that are going to be documented below: +HDMI Encoder + + +The HDMI Encoder supports the HDMI video and audio outputs, and does +CEC. It is one end of the pipeline. + +Required properties: + - compatible: value must be one of: +* allwinner,sun5i-a10s-hdmi + - reg: base address and size of memory-mapped region + - clocks: phandles to the clocks feeding the HDMI encoder +* ahb: the HDMI interface clock +* mod: the HDMI module clock +* pll-0: the first video PLL +* pll-1: the second video PLL + - clock-names: the clock names mentioned above + + - ports: A ports node with endpoint definitions as defined in +Documentation/devicetree/bindings/media/video-interfaces.txt. The +first port should be the input endpoint. + TV Encoder -- -- git-series 0.8.11
