Re: [PATCH 6/6] alpha: Join lines 90 and 91
On Tue, Jul 15, 2014 at 3:19 PM, Nick Krause wrote: > On Tue, Jul 15, 2014 at 2:54 PM, Måns Rullgård wrote: >> Nicholas Krause writes: >> >>> This fixes the checkpatch error I get in this file relating to a >>> quoted string needed to be joined to the line above it. >>> --- >>> arch/alpha/boot/bootpz.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/arch/alpha/boot/bootpz.c b/arch/alpha/boot/bootpz.c >>> index 6fc840d..a9e127b 100644 >>> --- a/arch/alpha/boot/bootpz.c >>> +++ b/arch/alpha/boot/bootpz.c >>> @@ -87,8 +87,7 @@ check_range(unsigned long vstart, unsigned long vend, >>> kaddr = (find_pa(vaddr) | PAGE_OFFSET); >>> if (kaddr >= kstart && kaddr <= kend) { >>> #ifdef DEBUG_CHECK_RANGE >>> - srm_printk("OVERLAP: vaddr 0x%lx kaddr 0x%lx" >>> -" [0x%lx:0x%lx]\n", >>> + srm_printk("OVERLAP: vaddr 0x%lx kaddr 0x%lx" " >>> [0x%lx:0x%lx]\n", >>> vaddr, kaddr, kstart, kend); >>> #endif >> >> If you're doing this, you should merge the strings too. >> >> -- >> Måns Rullgård >> m...@mansr.com > > Very well, > I will merge the strings for this statement. > Nick Our my other patches Ok through? Please let me know. Thanks Nick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/6] alpha: Join lines 90 and 91
On Tue, Jul 15, 2014 at 2:54 PM, Måns Rullgård wrote: > Nicholas Krause writes: > >> This fixes the checkpatch error I get in this file relating to a >> quoted string needed to be joined to the line above it. >> --- >> arch/alpha/boot/bootpz.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/arch/alpha/boot/bootpz.c b/arch/alpha/boot/bootpz.c >> index 6fc840d..a9e127b 100644 >> --- a/arch/alpha/boot/bootpz.c >> +++ b/arch/alpha/boot/bootpz.c >> @@ -87,8 +87,7 @@ check_range(unsigned long vstart, unsigned long vend, >> kaddr = (find_pa(vaddr) | PAGE_OFFSET); >> if (kaddr >= kstart && kaddr <= kend) { >> #ifdef DEBUG_CHECK_RANGE >> - srm_printk("OVERLAP: vaddr 0x%lx kaddr 0x%lx" >> -" [0x%lx:0x%lx]\n", >> + srm_printk("OVERLAP: vaddr 0x%lx kaddr 0x%lx" " >> [0x%lx:0x%lx]\n", >> vaddr, kaddr, kstart, kend); >> #endif > > If you're doing this, you should merge the strings too. > > -- > Måns Rullgård > m...@mansr.com Very well, I will merge the strings for this statement. Nick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/6] alpha: Join lines 90 and 91
Nicholas Krause writes: > This fixes the checkpatch error I get in this file relating to a > quoted string needed to be joined to the line above it. > --- > arch/alpha/boot/bootpz.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/alpha/boot/bootpz.c b/arch/alpha/boot/bootpz.c > index 6fc840d..a9e127b 100644 > --- a/arch/alpha/boot/bootpz.c > +++ b/arch/alpha/boot/bootpz.c > @@ -87,8 +87,7 @@ check_range(unsigned long vstart, unsigned long vend, > kaddr = (find_pa(vaddr) | PAGE_OFFSET); > if (kaddr >= kstart && kaddr <= kend) { > #ifdef DEBUG_CHECK_RANGE > - srm_printk("OVERLAP: vaddr 0x%lx kaddr 0x%lx" > -" [0x%lx:0x%lx]\n", > + srm_printk("OVERLAP: vaddr 0x%lx kaddr 0x%lx" " > [0x%lx:0x%lx]\n", > vaddr, kaddr, kstart, kend); > #endif If you're doing this, you should merge the strings too. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 6/6] alpha: Join lines 90 and 91
This fixes the checkpatch error I get in this file relating to a quoted string needed to be joined to the line above it. --- arch/alpha/boot/bootpz.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/alpha/boot/bootpz.c b/arch/alpha/boot/bootpz.c index 6fc840d..a9e127b 100644 --- a/arch/alpha/boot/bootpz.c +++ b/arch/alpha/boot/bootpz.c @@ -87,8 +87,7 @@ check_range(unsigned long vstart, unsigned long vend, kaddr = (find_pa(vaddr) | PAGE_OFFSET); if (kaddr >= kstart && kaddr <= kend) { #ifdef DEBUG_CHECK_RANGE - srm_printk("OVERLAP: vaddr 0x%lx kaddr 0x%lx" - " [0x%lx:0x%lx]\n", + srm_printk("OVERLAP: vaddr 0x%lx kaddr 0x%lx" " [0x%lx:0x%lx]\n", vaddr, kaddr, kstart, kend); #endif return 1; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 6/6] alpha: Join lines 90 and 91
This fixes the checkpatch error I get in this file relating to a quoted string needed to be joined to the line above it. --- arch/alpha/boot/bootpz.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/alpha/boot/bootpz.c b/arch/alpha/boot/bootpz.c index 6fc840d..a9e127b 100644 --- a/arch/alpha/boot/bootpz.c +++ b/arch/alpha/boot/bootpz.c @@ -87,8 +87,7 @@ check_range(unsigned long vstart, unsigned long vend, kaddr = (find_pa(vaddr) | PAGE_OFFSET); if (kaddr = kstart kaddr = kend) { #ifdef DEBUG_CHECK_RANGE - srm_printk(OVERLAP: vaddr 0x%lx kaddr 0x%lx - [0x%lx:0x%lx]\n, + srm_printk(OVERLAP: vaddr 0x%lx kaddr 0x%lx [0x%lx:0x%lx]\n, vaddr, kaddr, kstart, kend); #endif return 1; -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/6] alpha: Join lines 90 and 91
Nicholas Krause xerofo...@gmail.com writes: This fixes the checkpatch error I get in this file relating to a quoted string needed to be joined to the line above it. --- arch/alpha/boot/bootpz.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/alpha/boot/bootpz.c b/arch/alpha/boot/bootpz.c index 6fc840d..a9e127b 100644 --- a/arch/alpha/boot/bootpz.c +++ b/arch/alpha/boot/bootpz.c @@ -87,8 +87,7 @@ check_range(unsigned long vstart, unsigned long vend, kaddr = (find_pa(vaddr) | PAGE_OFFSET); if (kaddr = kstart kaddr = kend) { #ifdef DEBUG_CHECK_RANGE - srm_printk(OVERLAP: vaddr 0x%lx kaddr 0x%lx - [0x%lx:0x%lx]\n, + srm_printk(OVERLAP: vaddr 0x%lx kaddr 0x%lx [0x%lx:0x%lx]\n, vaddr, kaddr, kstart, kend); #endif If you're doing this, you should merge the strings too. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/6] alpha: Join lines 90 and 91
On Tue, Jul 15, 2014 at 2:54 PM, Måns Rullgård m...@mansr.com wrote: Nicholas Krause xerofo...@gmail.com writes: This fixes the checkpatch error I get in this file relating to a quoted string needed to be joined to the line above it. --- arch/alpha/boot/bootpz.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/alpha/boot/bootpz.c b/arch/alpha/boot/bootpz.c index 6fc840d..a9e127b 100644 --- a/arch/alpha/boot/bootpz.c +++ b/arch/alpha/boot/bootpz.c @@ -87,8 +87,7 @@ check_range(unsigned long vstart, unsigned long vend, kaddr = (find_pa(vaddr) | PAGE_OFFSET); if (kaddr = kstart kaddr = kend) { #ifdef DEBUG_CHECK_RANGE - srm_printk(OVERLAP: vaddr 0x%lx kaddr 0x%lx - [0x%lx:0x%lx]\n, + srm_printk(OVERLAP: vaddr 0x%lx kaddr 0x%lx [0x%lx:0x%lx]\n, vaddr, kaddr, kstart, kend); #endif If you're doing this, you should merge the strings too. -- Måns Rullgård m...@mansr.com Very well, I will merge the strings for this statement. Nick -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 6/6] alpha: Join lines 90 and 91
On Tue, Jul 15, 2014 at 3:19 PM, Nick Krause xerofo...@gmail.com wrote: On Tue, Jul 15, 2014 at 2:54 PM, Måns Rullgård m...@mansr.com wrote: Nicholas Krause xerofo...@gmail.com writes: This fixes the checkpatch error I get in this file relating to a quoted string needed to be joined to the line above it. --- arch/alpha/boot/bootpz.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/alpha/boot/bootpz.c b/arch/alpha/boot/bootpz.c index 6fc840d..a9e127b 100644 --- a/arch/alpha/boot/bootpz.c +++ b/arch/alpha/boot/bootpz.c @@ -87,8 +87,7 @@ check_range(unsigned long vstart, unsigned long vend, kaddr = (find_pa(vaddr) | PAGE_OFFSET); if (kaddr = kstart kaddr = kend) { #ifdef DEBUG_CHECK_RANGE - srm_printk(OVERLAP: vaddr 0x%lx kaddr 0x%lx - [0x%lx:0x%lx]\n, + srm_printk(OVERLAP: vaddr 0x%lx kaddr 0x%lx [0x%lx:0x%lx]\n, vaddr, kaddr, kstart, kend); #endif If you're doing this, you should merge the strings too. -- Måns Rullgård m...@mansr.com Very well, I will merge the strings for this statement. Nick Our my other patches Ok through? Please let me know. Thanks Nick -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/