Re: [PATCH 6/6] infiniband: qplib_fp: Use dev_fmt

[Selvin Xavier]

On Tue, May 15, 2018 at 8:10 PM, Doug Ledford  wrote:
> On Wed, 2018-05-09 at 08:15 -0700, Joe Perches wrote:
>> Convert the embedded dev_ uses to use the new dev_fmt
>> prefix and remove the prefix from the formats.
>>
>> Miscellanea:
>>
>> o Add missing terminating newlines to avoid possible interleaving
>> o Realign arguments
>>
>> Signed-off-by: Joe Perches 
>
> I don't see any problem with this patch.  For the IB part:
>
> Acked-by: Doug Ledford 
>
>
Acked-by: Selvin Xavier 

Re: [PATCH 6/6] infiniband: qplib_fp: Use dev_fmt

[Selvin Xavier]

On Tue, May 15, 2018 at 8:10 PM, Doug Ledford  wrote:
> On Wed, 2018-05-09 at 08:15 -0700, Joe Perches wrote:
>> Convert the embedded dev_ uses to use the new dev_fmt
>> prefix and remove the prefix from the formats.
>>
>> Miscellanea:
>>
>> o Add missing terminating newlines to avoid possible interleaving
>> o Realign arguments
>>
>> Signed-off-by: Joe Perches 
>
> I don't see any problem with this patch.  For the IB part:
>
> Acked-by: Doug Ledford 
>
>
Acked-by: Selvin Xavier 

Re: [PATCH 6/6] infiniband: qplib_fp: Use dev_fmt

[Doug Ledford]

On Wed, 2018-05-09 at 08:15 -0700, Joe Perches wrote:
> Convert the embedded dev_ uses to use the new dev_fmt
> prefix and remove the prefix from the formats.
> 
> Miscellanea:
> 
> o Add missing terminating newlines to avoid possible interleaving
> o Realign arguments
> 
> Signed-off-by: Joe Perches 

I don't see any problem with this patch.  For the IB part:

Acked-by: Doug Ledford 

-- 
Doug Ledford 
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

signature.asc
Description: This is a digitally signed message part

Re: [PATCH 6/6] infiniband: qplib_fp: Use dev_fmt

[Doug Ledford]

On Wed, 2018-05-09 at 08:15 -0700, Joe Perches wrote:
> Convert the embedded dev_ uses to use the new dev_fmt
> prefix and remove the prefix from the formats.
> 
> Miscellanea:
> 
> o Add missing terminating newlines to avoid possible interleaving
> o Realign arguments
> 
> Signed-off-by: Joe Perches 

I don't see any problem with this patch.  For the IB part:

Acked-by: Doug Ledford 

-- 
Doug Ledford 
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

signature.asc
Description: This is a digitally signed message part

[PATCH 6/6] infiniband: qplib_fp: Use dev_fmt

[Joe Perches]

Convert the embedded dev_ uses to use the new dev_fmt
prefix and remove the prefix from the formats.

Miscellanea:

o Add missing terminating newlines to avoid possible interleaving
o Realign arguments

Signed-off-by: Joe Perches 
---
 drivers/infiniband/hw/bnxt_re/qplib_fp.c | 125 ++-
 1 file changed, 57 insertions(+), 68 deletions(-)

diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c 
b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
index 3a78faba8d91..cbe6dbea9ab6 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
@@ -36,6 +36,8 @@
  * Description: Fast Path Operators
  */
 
+#define dev_fmt(fmt) "QPLIB: " fmt
+
 #include 
 #include 
 #include 
@@ -70,8 +72,7 @@ static void __bnxt_qplib_add_flush_qp(struct bnxt_qplib_qp 
*qp)
rcq = qp->rcq;
 
if (!qp->sq.flushed) {
-   dev_dbg(>hwq.pdev->dev,
-   "QPLIB: FP: Adding to SQ Flush list = %p",
+   dev_dbg(>hwq.pdev->dev, "FP: Adding to SQ Flush list = 
%p\n",
qp);
bnxt_qplib_cancel_phantom_processing(qp);
list_add_tail(>sq_flush, >sqf_head);
@@ -79,8 +80,7 @@ static void __bnxt_qplib_add_flush_qp(struct bnxt_qplib_qp 
*qp)
}
if (!qp->srq) {
if (!qp->rq.flushed) {
-   dev_dbg(>hwq.pdev->dev,
-   "QPLIB: FP: Adding to RQ Flush list = %p",
+   dev_dbg(>hwq.pdev->dev, "FP: Adding to RQ Flush 
list = %p\n",
qp);
list_add_tail(>rq_flush, >rqf_head);
qp->rq.flushed = true;
@@ -161,7 +161,7 @@ static void bnxt_qpn_cqn_sched_task(struct work_struct 
*work)
spin_lock_bh(>compl_lock);
if (atomic_read(>arm_state) && nq->cqn_handler) {
dev_dbg(>pdev->dev,
-   "%s:Trigger cq  = %p event nq = %p\n",
+   "%s: Trigger cq  = %p event nq = %p\n",
__func__, cq, nq);
nq->cqn_handler(nq, cq);
}
@@ -206,8 +206,7 @@ static int bnxt_qplib_alloc_qp_hdr_buf(struct 
bnxt_qplib_res *res,
>sq_hdr_buf_map, GFP_KERNEL);
if (!qp->sq_hdr_buf) {
rc = -ENOMEM;
-   dev_err(>pdev->dev,
-   "QPLIB: Failed to create sq_hdr_buf");
+   dev_err(>pdev->dev, "Failed to create 
sq_hdr_buf\n");
goto fail;
}
}
@@ -220,8 +219,7 @@ static int bnxt_qplib_alloc_qp_hdr_buf(struct 
bnxt_qplib_res *res,
GFP_KERNEL);
if (!qp->rq_hdr_buf) {
rc = -ENOMEM;
-   dev_err(>pdev->dev,
-   "QPLIB: Failed to create rq_hdr_buf");
+   dev_err(>pdev->dev, "Failed to create 
rq_hdr_buf\n");
goto fail;
}
}
@@ -276,8 +274,7 @@ static void bnxt_qplib_service_nq(unsigned long data)
if (!nq->cqn_handler(nq, (cq)))
num_cqne_processed++;
else
-   dev_warn(>pdev->dev,
-"QPLIB: cqn - type 0x%x not handled",
+   dev_warn(>pdev->dev, "cqn - type 0x%x not 
handled\n",
 type);
spin_unlock_bh(>compl_lock);
break;
@@ -297,16 +294,14 @@ static void bnxt_qplib_service_nq(unsigned long data)
  nqsrqe->event))
num_srqne_processed++;
else
-   dev_warn(>pdev->dev,
-"QPLIB: SRQ event 0x%x not handled",
+   dev_warn(>pdev->dev, "SRQ event 0x%x not 
handled\n",
 nqsrqe->event);
break;
}
case NQ_BASE_TYPE_DBQ_EVENT:
break;
default:
-   dev_warn(>pdev->dev,
-"QPLIB: nqe with type = 0x%x not handled",
+   dev_warn(>pdev->dev, "nqe with type = 0x%x not 
handled\n",
 type);
break;
}
@@ -393,7 +388,7 @@ int bnxt_qplib_enable_nq(struct pci_dev *pdev, struct 
bnxt_qplib_nq *nq,
rc = request_irq(nq->vector, bnxt_qplib_nq_irq, 0, nq->name, nq);
if (rc) {
dev_err(>pdev->dev,
-   "Failed to request IRQ for NQ: %#x", rc);
+

[PATCH 6/6] infiniband: qplib_fp: Use dev_fmt

[Joe Perches]

Convert the embedded dev_ uses to use the new dev_fmt
prefix and remove the prefix from the formats.

Miscellanea:

o Add missing terminating newlines to avoid possible interleaving
o Realign arguments

Signed-off-by: Joe Perches 
---
 drivers/infiniband/hw/bnxt_re/qplib_fp.c | 125 ++-
 1 file changed, 57 insertions(+), 68 deletions(-)

diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c 
b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
index 3a78faba8d91..cbe6dbea9ab6 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
@@ -36,6 +36,8 @@
  * Description: Fast Path Operators
  */
 
+#define dev_fmt(fmt) "QPLIB: " fmt
+
 #include 
 #include 
 #include 
@@ -70,8 +72,7 @@ static void __bnxt_qplib_add_flush_qp(struct bnxt_qplib_qp 
*qp)
rcq = qp->rcq;
 
if (!qp->sq.flushed) {
-   dev_dbg(>hwq.pdev->dev,
-   "QPLIB: FP: Adding to SQ Flush list = %p",
+   dev_dbg(>hwq.pdev->dev, "FP: Adding to SQ Flush list = 
%p\n",
qp);
bnxt_qplib_cancel_phantom_processing(qp);
list_add_tail(>sq_flush, >sqf_head);
@@ -79,8 +80,7 @@ static void __bnxt_qplib_add_flush_qp(struct bnxt_qplib_qp 
*qp)
}
if (!qp->srq) {
if (!qp->rq.flushed) {
-   dev_dbg(>hwq.pdev->dev,
-   "QPLIB: FP: Adding to RQ Flush list = %p",
+   dev_dbg(>hwq.pdev->dev, "FP: Adding to RQ Flush 
list = %p\n",
qp);
list_add_tail(>rq_flush, >rqf_head);
qp->rq.flushed = true;
@@ -161,7 +161,7 @@ static void bnxt_qpn_cqn_sched_task(struct work_struct 
*work)
spin_lock_bh(>compl_lock);
if (atomic_read(>arm_state) && nq->cqn_handler) {
dev_dbg(>pdev->dev,
-   "%s:Trigger cq  = %p event nq = %p\n",
+   "%s: Trigger cq  = %p event nq = %p\n",
__func__, cq, nq);
nq->cqn_handler(nq, cq);
}
@@ -206,8 +206,7 @@ static int bnxt_qplib_alloc_qp_hdr_buf(struct 
bnxt_qplib_res *res,
>sq_hdr_buf_map, GFP_KERNEL);
if (!qp->sq_hdr_buf) {
rc = -ENOMEM;
-   dev_err(>pdev->dev,
-   "QPLIB: Failed to create sq_hdr_buf");
+   dev_err(>pdev->dev, "Failed to create 
sq_hdr_buf\n");
goto fail;
}
}
@@ -220,8 +219,7 @@ static int bnxt_qplib_alloc_qp_hdr_buf(struct 
bnxt_qplib_res *res,
GFP_KERNEL);
if (!qp->rq_hdr_buf) {
rc = -ENOMEM;
-   dev_err(>pdev->dev,
-   "QPLIB: Failed to create rq_hdr_buf");
+   dev_err(>pdev->dev, "Failed to create 
rq_hdr_buf\n");
goto fail;
}
}
@@ -276,8 +274,7 @@ static void bnxt_qplib_service_nq(unsigned long data)
if (!nq->cqn_handler(nq, (cq)))
num_cqne_processed++;
else
-   dev_warn(>pdev->dev,
-"QPLIB: cqn - type 0x%x not handled",
+   dev_warn(>pdev->dev, "cqn - type 0x%x not 
handled\n",
 type);
spin_unlock_bh(>compl_lock);
break;
@@ -297,16 +294,14 @@ static void bnxt_qplib_service_nq(unsigned long data)
  nqsrqe->event))
num_srqne_processed++;
else
-   dev_warn(>pdev->dev,
-"QPLIB: SRQ event 0x%x not handled",
+   dev_warn(>pdev->dev, "SRQ event 0x%x not 
handled\n",
 nqsrqe->event);
break;
}
case NQ_BASE_TYPE_DBQ_EVENT:
break;
default:
-   dev_warn(>pdev->dev,
-"QPLIB: nqe with type = 0x%x not handled",
+   dev_warn(>pdev->dev, "nqe with type = 0x%x not 
handled\n",
 type);
break;
}
@@ -393,7 +388,7 @@ int bnxt_qplib_enable_nq(struct pci_dev *pdev, struct 
bnxt_qplib_nq *nq,
rc = request_irq(nq->vector, bnxt_qplib_nq_irq, 0, nq->name, nq);
if (rc) {
dev_err(>pdev->dev,
-   "Failed to request IRQ for NQ: %#x", rc);
+