Re: [PATCH 6/6] net: phy: mdio: reset MDIO devices even if probe() is not implemented

[Florian Fainelli]

On 6/26/2020 8:53 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski 
> 
> Similarily to PHY drivers - there's no reason to require probe() to be
> implemented in order to call mdio_device_reset(). MDIO devices can have
> resets defined without needing to do anything in probe().
> 
> Signed-off-by: Bartosz Golaszewski 
> Reviewed-by: Andrew Lunn 

Reviewed-by: Florian Fainelli 
-- 
Florian

[PATCH 6/6] net: phy: mdio: reset MDIO devices even if probe() is not implemented

[Bartosz Golaszewski]

From: Bartosz Golaszewski 

Similarily to PHY drivers - there's no reason to require probe() to be
implemented in order to call mdio_device_reset(). MDIO devices can have
resets defined without needing to do anything in probe().

Signed-off-by: Bartosz Golaszewski 
Reviewed-by: Andrew Lunn 
---
 drivers/net/phy/mdio_device.c | 13 ++---
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/net/phy/mdio_device.c b/drivers/net/phy/mdio_device.c
index f60443e48622..be615504b829 100644
--- a/drivers/net/phy/mdio_device.c
+++ b/drivers/net/phy/mdio_device.c
@@ -150,10 +150,10 @@ static int mdio_probe(struct device *dev)
struct mdio_driver *mdiodrv = to_mdio_driver(drv);
int err = 0;
 
-   if (mdiodrv->probe) {
-   /* Deassert the reset signal */
-   mdio_device_reset(mdiodev, 0);
+   /* Deassert the reset signal */
+   mdio_device_reset(mdiodev, 0);
 
+   if (mdiodrv->probe) {
err = mdiodrv->probe(mdiodev);
if (err) {
/* Assert the reset signal */
@@ -170,12 +170,11 @@ static int mdio_remove(struct device *dev)
struct device_driver *drv = mdiodev->dev.driver;
struct mdio_driver *mdiodrv = to_mdio_driver(drv);
 
-   if (mdiodrv->remove) {
+   if (mdiodrv->remove)
mdiodrv->remove(mdiodev);
 
-   /* Assert the reset signal */
-   mdio_device_reset(mdiodev, 1);
-   }
+   /* Assert the reset signal */
+   mdio_device_reset(mdiodev, 1);
 
return 0;
 }
-- 
2.26.1