[PATCH 6/6] scsi: Cocci spatch "pool_zalloc-simple"

2017-09-21 Thread Thomas Meyer
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0.
Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci"

Signed-off-by: Thomas Meyer 
---

diff -u -p a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c
--- a/drivers/scsi/qla4xxx/ql4_mbx.c
+++ b/drivers/scsi/qla4xxx/ql4_mbx.c
@@ -1651,13 +1651,12 @@ int qla4xxx_set_chap(struct scsi_qla_hos
uint32_t chap_size = 0;
dma_addr_t chap_dma;
 
-   chap_table = dma_pool_alloc(ha->chap_dma_pool, GFP_KERNEL, _dma);
+   chap_table = dma_pool_zalloc(ha->chap_dma_pool, GFP_KERNEL, _dma);
if (chap_table == NULL) {
ret =  -ENOMEM;
goto exit_set_chap;
}
 
-   memset(chap_table, 0, sizeof(struct ql4_chap_table));
if (bidi)
chap_table->flags |= BIT_6; /* peer */
else
diff -u -p a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -825,12 +825,10 @@ static int qla4xxx_delete_chap(struct Sc
uint32_t chap_size;
int ret = 0;
 
-   chap_table = dma_pool_alloc(ha->chap_dma_pool, GFP_KERNEL, _dma);
+   chap_table = dma_pool_zalloc(ha->chap_dma_pool, GFP_KERNEL, _dma);
if (chap_table == NULL)
return -ENOMEM;
 
-   memset(chap_table, 0, sizeof(struct ql4_chap_table));
-
if (is_qla80XX(ha))
max_chap_entries = (ha->hw.flt_chap_size / 2) /
   sizeof(struct ql4_chap_table);


[PATCH 6/6] scsi: Cocci spatch "pool_zalloc-simple"

2017-09-21 Thread Thomas Meyer
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0.
Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci"

Signed-off-by: Thomas Meyer 
---

diff -u -p a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c
--- a/drivers/scsi/qla4xxx/ql4_mbx.c
+++ b/drivers/scsi/qla4xxx/ql4_mbx.c
@@ -1651,13 +1651,12 @@ int qla4xxx_set_chap(struct scsi_qla_hos
uint32_t chap_size = 0;
dma_addr_t chap_dma;
 
-   chap_table = dma_pool_alloc(ha->chap_dma_pool, GFP_KERNEL, _dma);
+   chap_table = dma_pool_zalloc(ha->chap_dma_pool, GFP_KERNEL, _dma);
if (chap_table == NULL) {
ret =  -ENOMEM;
goto exit_set_chap;
}
 
-   memset(chap_table, 0, sizeof(struct ql4_chap_table));
if (bidi)
chap_table->flags |= BIT_6; /* peer */
else
diff -u -p a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -825,12 +825,10 @@ static int qla4xxx_delete_chap(struct Sc
uint32_t chap_size;
int ret = 0;
 
-   chap_table = dma_pool_alloc(ha->chap_dma_pool, GFP_KERNEL, _dma);
+   chap_table = dma_pool_zalloc(ha->chap_dma_pool, GFP_KERNEL, _dma);
if (chap_table == NULL)
return -ENOMEM;
 
-   memset(chap_table, 0, sizeof(struct ql4_chap_table));
-
if (is_qla80XX(ha))
max_chap_entries = (ha->hw.flt_chap_size / 2) /
   sizeof(struct ql4_chap_table);