Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv->s_EeParameters

2014-04-30 Thread Chase Southwood 
Hartley,

Yes, you raise very good points.  In any case, I have added cover
letters to my submitting checklist so hopefully everything will be a
lot easier for everyone next go round.

Thanks,
Chase

On Wed, Apr 30, 2014 at 11:58 AM, Hartley Sweeten
 wrote:
> On Wednesday, April 30, 2014 12:52 AM, Chase Southwood wrote:
>> Thanks so much, I greatly appreciate the review.  I'll fix the
>> changelog for patch 4 and send once more (as I assume that's easier
>> for Greg).  Also, I should know better about the cover letter as
>> well...I was once told not to send them for strictly cleanup patchsets
>> (as Greg can't do anything with them and cleanups should be obvious)
>> but I've gotten in the habit of not doing a cover letter for any
>> patchsets.  I will send cover letters (and be more careful about my
>> other mistakes) in the future.
>
> Chase,
>
> Good job on the cleanup you have done so far.
>
> The cover letter does not get committed as part of the patch set. But
> when you are submitting a series it give a convenient  place to add
> the sign off tag for a series. Also, if you would have done a cover letter
> for this series you would have probably spotted the subject line issues
> in patches 5 and 6.
>
> Keep up the good work!
>
> Hartley
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv->s_EeParameters

2014-04-30 Thread Hartley Sweeten 
On Wednesday, April 30, 2014 12:52 AM, Chase Southwood wrote:
> Thanks so much, I greatly appreciate the review.  I'll fix the
> changelog for patch 4 and send once more (as I assume that's easier
> for Greg).  Also, I should know better about the cover letter as
> well...I was once told not to send them for strictly cleanup patchsets
> (as Greg can't do anything with them and cleanups should be obvious)
> but I've gotten in the habit of not doing a cover letter for any
> patchsets.  I will send cover letters (and be more careful about my
> other mistakes) in the future.

Chase,

Good job on the cleanup you have done so far.

The cover letter does not get committed as part of the patch set. But
when you are submitting a series it give a convenient  place to add
the sign off tag for a series. Also, if you would have done a cover letter
for this series you would have probably spotted the subject line issues
in patches 5 and 6.

Keep up the good work!

Hartley

Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv->s_EeParameters

2014-04-30 Thread Chase Southwood 
Ian and Hartley,

Thanks so much, I greatly appreciate the review.  I'll fix the
changelog for patch 4 and send once more (as I assume that's easier
for Greg).  Also, I should know better about the cover letter as
well...I was once told not to send them for strictly cleanup patchsets
(as Greg can't do anything with them and cleanups should be obvious)
but I've gotten in the habit of not doing a cover letter for any
patchsets.  I will send cover letters (and be more careful about my
other mistakes) in the future.

Thanks,
Chase

On Tue, Apr 29, 2014 at 3:33 PM, Hartley Sweeten
 wrote:
> On, Tuesday, April 29, 2014 1:38 AM, Chase Southwood wrote:
>> This driver no longer reads the eeprom to find the board specific data,
>> all the necessary data is in the boardinfo. Use the boardinfo directly
>> instead of passing through devpriv->s_EeParameters.
>>
>> Signed-off-by: Chase Southwood 
>> Cc: Ian Abbott 
>> Cc: H Hartley Sweeten 
>> ---
>> 2: Incorrect patch title fixed.
>>
>> Ian and Hartley,
>>
>> The auto_attach() function is starting to look much better now.  My next 
>> patchset
>> will be geared towards only allocating subdevices which are actually used.
>
> Other than Ian's comment on patch 4/6 everything looks good to me.
>
> For the series:
> Reviewed-by: H Hartley Sweeten 
>
> BTW, for a patch series you should include a cover letter (PATCH 00/xx).
>
> Regards,
> Hartley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters

2014-04-30 Thread Chase Southwood 
Ian and Hartley,

Thanks so much, I greatly appreciate the review.  I'll fix the
changelog for patch 4 and send once more (as I assume that's easier
for Greg).  Also, I should know better about the cover letter as
well...I was once told not to send them for strictly cleanup patchsets
(as Greg can't do anything with them and cleanups should be obvious)
but I've gotten in the habit of not doing a cover letter for any
patchsets.  I will send cover letters (and be more careful about my
other mistakes) in the future.

Thanks,
Chase

On Tue, Apr 29, 2014 at 3:33 PM, Hartley Sweeten
hartl...@visionengravers.com wrote:
 On, Tuesday, April 29, 2014 1:38 AM, Chase Southwood wrote:
 This driver no longer reads the eeprom to find the board specific data,
 all the necessary data is in the boardinfo. Use the boardinfo directly
 instead of passing through devpriv-s_EeParameters.

 Signed-off-by: Chase Southwood chase.southw...@gmail.com
 Cc: Ian Abbott abbo...@mev.co.uk
 Cc: H Hartley Sweeten hswee...@visionengravers.com
 ---
 2: Incorrect patch title fixed.

 Ian and Hartley,

 The auto_attach() function is starting to look much better now.  My next 
 patchset
 will be geared towards only allocating subdevices which are actually used.

 Other than Ian's comment on patch 4/6 everything looks good to me.

 For the series:
 Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com

 BTW, for a patch series you should include a cover letter (PATCH 00/xx).

 Regards,
 Hartley
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters

2014-04-30 Thread Hartley Sweeten 
On Wednesday, April 30, 2014 12:52 AM, Chase Southwood wrote:
 Thanks so much, I greatly appreciate the review.  I'll fix the
 changelog for patch 4 and send once more (as I assume that's easier
 for Greg).  Also, I should know better about the cover letter as
 well...I was once told not to send them for strictly cleanup patchsets
 (as Greg can't do anything with them and cleanups should be obvious)
 but I've gotten in the habit of not doing a cover letter for any
 patchsets.  I will send cover letters (and be more careful about my
 other mistakes) in the future.

Chase,

Good job on the cleanup you have done so far.

The cover letter does not get committed as part of the patch set. But
when you are submitting a series it give a convenient  place to add
the sign off tag for a series. Also, if you would have done a cover letter
for this series you would have probably spotted the subject line issues
in patches 5 and 6.

Keep up the good work!

Hartley

Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters

2014-04-30 Thread Chase Southwood 
Hartley,

Yes, you raise very good points.  In any case, I have added cover
letters to my submitting checklist so hopefully everything will be a
lot easier for everyone next go round.

Thanks,
Chase

On Wed, Apr 30, 2014 at 11:58 AM, Hartley Sweeten
hartl...@visionengravers.com wrote:
 On Wednesday, April 30, 2014 12:52 AM, Chase Southwood wrote:
 Thanks so much, I greatly appreciate the review.  I'll fix the
 changelog for patch 4 and send once more (as I assume that's easier
 for Greg).  Also, I should know better about the cover letter as
 well...I was once told not to send them for strictly cleanup patchsets
 (as Greg can't do anything with them and cleanups should be obvious)
 but I've gotten in the habit of not doing a cover letter for any
 patchsets.  I will send cover letters (and be more careful about my
 other mistakes) in the future.

 Chase,

 Good job on the cleanup you have done so far.

 The cover letter does not get committed as part of the patch set. But
 when you are submitting a series it give a convenient  place to add
 the sign off tag for a series. Also, if you would have done a cover letter
 for this series you would have probably spotted the subject line issues
 in patches 5 and 6.

 Keep up the good work!

 Hartley

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv->s_EeParameters

2014-04-29 Thread Hartley Sweeten 
On, Tuesday, April 29, 2014 1:38 AM, Chase Southwood wrote: 
> This driver no longer reads the eeprom to find the board specific data,
> all the necessary data is in the boardinfo. Use the boardinfo directly
> instead of passing through devpriv->s_EeParameters.
>
> Signed-off-by: Chase Southwood 
> Cc: Ian Abbott 
> Cc: H Hartley Sweeten 
> ---
> 2: Incorrect patch title fixed.
>
> Ian and Hartley,
>
> The auto_attach() function is starting to look much better now.  My next 
> patchset
> will be geared towards only allocating subdevices which are actually used.

Other than Ian's comment on patch 4/6 everything looks good to me.

For the series:
Reviewed-by: H Hartley Sweeten 

BTW, for a patch series you should include a cover letter (PATCH 00/xx).

Regards,
Hartley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv->s_EeParameters

2014-04-29 Thread Ian Abbott 

On 2014-04-29 09:38, Chase Southwood wrote:

This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing through devpriv->s_EeParameters.

Signed-off-by: Chase Southwood 
Cc: Ian Abbott 
Cc: H Hartley Sweeten 
---
2: Incorrect patch title fixed.

Ian and Hartley,

The auto_attach() function is starting to look much better now.  My next 
patchset
will be geared towards only allocating subdevices which are actually used.


Great!  All looking good except the description of PATCH 4/6 v2.

Revie

--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv->s_EeParameters

2014-04-29 Thread Chase Southwood 
This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing through devpriv->s_EeParameters.

Signed-off-by: Chase Southwood 
Cc: Ian Abbott 
Cc: H Hartley Sweeten 
---
2: Incorrect patch title fixed.

Ian and Hartley,

The auto_attach() function is starting to look much better now.  My next 
patchset
will be geared towards only allocating subdevices which are actually used.

Thanks,
Chase

 drivers/staging/comedi/drivers/addi_apci_1564.c | 27 +
 1 file changed, 5 insertions(+), 22 deletions(-)

diff --git a/drivers/staging/comedi/drivers/addi_apci_1564.c 
b/drivers/staging/comedi/drivers/addi_apci_1564.c
index d5be8d3..b34ae34 100644
--- a/drivers/staging/comedi/drivers/addi_apci_1564.c
+++ b/drivers/staging/comedi/drivers/addi_apci_1564.c
@@ -65,22 +65,6 @@ static int apci1564_auto_attach(struct comedi_device *dev,
dev->iobase = pci_resource_start(pcidev, 2);
devpriv->i_IobaseAmcc = pci_resource_start(pcidev, 1);
 
-   /* Initialize parameters that can be overridden in EEPROM */
-   devpriv->s_EeParameters.i_NbrAiChannel = this_board->i_NbrAiChannel;
-   devpriv->s_EeParameters.i_NbrAoChannel = this_board->i_NbrAoChannel;
-   devpriv->s_EeParameters.i_AiMaxdata = this_board->i_AiMaxdata;
-   devpriv->s_EeParameters.i_AoMaxdata = this_board->i_AoMaxdata;
-   devpriv->s_EeParameters.i_NbrDiChannel = this_board->i_NbrDiChannel;
-   devpriv->s_EeParameters.i_NbrDoChannel = this_board->i_NbrDoChannel;
-   devpriv->s_EeParameters.i_DoMaxdata = this_board->i_DoMaxdata;
-   devpriv->s_EeParameters.i_Timer = this_board->i_Timer;
-   devpriv->s_EeParameters.ui_MinAcquisitiontimeNs =
-   this_board->ui_MinAcquisitiontimeNs;
-   devpriv->s_EeParameters.ui_MinDelaytimeNs =
-   this_board->ui_MinDelaytimeNs;
-
-   /* ## */
-
if (pcidev->irq > 0) {
ret = request_irq(pcidev->irq, v_ADDI_Interrupt, IRQF_SHARED,
  dev->board_name, dev);
@@ -114,14 +98,13 @@ static int apci1564_auto_attach(struct comedi_device *dev,
 
/*  Allocate and Initialise DO Subdevice Structures */
s = >subdevices[3];
-   if (devpriv->s_EeParameters.i_NbrDoChannel) {
+   if (this_board->i_NbrDoChannel) {
s->type = COMEDI_SUBD_DO;
s->subdev_flags =
SDF_READABLE | SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
-   s->n_chan = devpriv->s_EeParameters.i_NbrDoChannel;
-   s->maxdata = devpriv->s_EeParameters.i_DoMaxdata;
-   s->len_chanlist =
-   devpriv->s_EeParameters.i_NbrDoChannel;
+   s->n_chan = this_board->i_NbrDoChannel;
+   s->maxdata = this_board->i_DoMaxdata;
+   s->len_chanlist = this_board->i_NbrDoChannel;
s->range_table = _digital;
 
/* insn_config - for digital output memory */
@@ -135,7 +118,7 @@ static int apci1564_auto_attach(struct comedi_device *dev,
 
/*  Allocate and Initialise Timer Subdevice Structures */
s = >subdevices[4];
-   if (devpriv->s_EeParameters.i_Timer) {
+   if (this_board->i_Timer) {
s->type = COMEDI_SUBD_TIMER;
s->subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
s->n_chan = 1;
-- 
1.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters

2014-04-29 Thread Chase Southwood 
This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing through devpriv-s_EeParameters.

Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
2: Incorrect patch title fixed.

Ian and Hartley,

The auto_attach() function is starting to look much better now.  My next 
patchset
will be geared towards only allocating subdevices which are actually used.

Thanks,
Chase

 drivers/staging/comedi/drivers/addi_apci_1564.c | 27 +
 1 file changed, 5 insertions(+), 22 deletions(-)

diff --git a/drivers/staging/comedi/drivers/addi_apci_1564.c 
b/drivers/staging/comedi/drivers/addi_apci_1564.c
index d5be8d3..b34ae34 100644
--- a/drivers/staging/comedi/drivers/addi_apci_1564.c
+++ b/drivers/staging/comedi/drivers/addi_apci_1564.c
@@ -65,22 +65,6 @@ static int apci1564_auto_attach(struct comedi_device *dev,
dev-iobase = pci_resource_start(pcidev, 2);
devpriv-i_IobaseAmcc = pci_resource_start(pcidev, 1);
 
-   /* Initialize parameters that can be overridden in EEPROM */
-   devpriv-s_EeParameters.i_NbrAiChannel = this_board-i_NbrAiChannel;
-   devpriv-s_EeParameters.i_NbrAoChannel = this_board-i_NbrAoChannel;
-   devpriv-s_EeParameters.i_AiMaxdata = this_board-i_AiMaxdata;
-   devpriv-s_EeParameters.i_AoMaxdata = this_board-i_AoMaxdata;
-   devpriv-s_EeParameters.i_NbrDiChannel = this_board-i_NbrDiChannel;
-   devpriv-s_EeParameters.i_NbrDoChannel = this_board-i_NbrDoChannel;
-   devpriv-s_EeParameters.i_DoMaxdata = this_board-i_DoMaxdata;
-   devpriv-s_EeParameters.i_Timer = this_board-i_Timer;
-   devpriv-s_EeParameters.ui_MinAcquisitiontimeNs =
-   this_board-ui_MinAcquisitiontimeNs;
-   devpriv-s_EeParameters.ui_MinDelaytimeNs =
-   this_board-ui_MinDelaytimeNs;
-
-   /* ## */
-
if (pcidev-irq  0) {
ret = request_irq(pcidev-irq, v_ADDI_Interrupt, IRQF_SHARED,
  dev-board_name, dev);
@@ -114,14 +98,13 @@ static int apci1564_auto_attach(struct comedi_device *dev,
 
/*  Allocate and Initialise DO Subdevice Structures */
s = dev-subdevices[3];
-   if (devpriv-s_EeParameters.i_NbrDoChannel) {
+   if (this_board-i_NbrDoChannel) {
s-type = COMEDI_SUBD_DO;
s-subdev_flags =
SDF_READABLE | SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
-   s-n_chan = devpriv-s_EeParameters.i_NbrDoChannel;
-   s-maxdata = devpriv-s_EeParameters.i_DoMaxdata;
-   s-len_chanlist =
-   devpriv-s_EeParameters.i_NbrDoChannel;
+   s-n_chan = this_board-i_NbrDoChannel;
+   s-maxdata = this_board-i_DoMaxdata;
+   s-len_chanlist = this_board-i_NbrDoChannel;
s-range_table = range_digital;
 
/* insn_config - for digital output memory */
@@ -135,7 +118,7 @@ static int apci1564_auto_attach(struct comedi_device *dev,
 
/*  Allocate and Initialise Timer Subdevice Structures */
s = dev-subdevices[4];
-   if (devpriv-s_EeParameters.i_Timer) {
+   if (this_board-i_Timer) {
s-type = COMEDI_SUBD_TIMER;
s-subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
s-n_chan = 1;
-- 
1.9.0

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters

2014-04-29 Thread Ian Abbott 

On 2014-04-29 09:38, Chase Southwood wrote:

This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing through devpriv-s_EeParameters.

Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
2: Incorrect patch title fixed.

Ian and Hartley,

The auto_attach() function is starting to look much better now.  My next 
patchset
will be geared towards only allocating subdevices which are actually used.


Great!  All looking good except the description of PATCH 4/6 v2.

Revie

--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters

2014-04-29 Thread Hartley Sweeten 
On, Tuesday, April 29, 2014 1:38 AM, Chase Southwood wrote: 
 This driver no longer reads the eeprom to find the board specific data,
 all the necessary data is in the boardinfo. Use the boardinfo directly
 instead of passing through devpriv-s_EeParameters.

 Signed-off-by: Chase Southwood chase.southw...@gmail.com
 Cc: Ian Abbott abbo...@mev.co.uk
 Cc: H Hartley Sweeten hswee...@visionengravers.com
 ---
 2: Incorrect patch title fixed.

 Ian and Hartley,

 The auto_attach() function is starting to look much better now.  My next 
 patchset
 will be geared towards only allocating subdevices which are actually used.

Other than Ian's comment on patch 4/6 everything looks good to me.

For the series:
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com

BTW, for a patch series you should include a cover letter (PATCH 00/xx).

Regards,
Hartley
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/