Re: [PATCH 6/9] perf, tools, stat: Document CSV format in manpage

2016-01-22 Thread Andi Kleen
> [jolsa@krava perf]$ sudo ./perf stat -e cycles,instructions -a -x, 
> 160517940,,cycles,2357448795,100.00,,Ghz,2357448795,100.00
> 
>  ^  what's this data?
> 
> 84822675,,instructions,2357537479,100.00,0.53,insn per cycle
> 
> 
> ,,,2357537479,100.00,,stalled cycles per insn,2357537479,100.00
> 
> this line is probably wrong, as noted in previous email..?

Yes the noise was printed twice.
I fixed it now (by removing the first variant, which is much simpler
in the code)

-Andi


Re: [PATCH 6/9] perf, tools, stat: Document CSV format in manpage

2016-01-22 Thread Jiri Olsa
On Tue, Jan 19, 2016 at 06:26:49PM -0800, Andi Kleen wrote:
> From: Andi Kleen 
> 
> With all the recently added fields in the perf stat CSV output
> we should finally document them in the man page. Do this here.
> 
> Signed-off-by: Andi Kleen 
> ---
>  tools/perf/Documentation/perf-stat.txt | 19 +++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/tools/perf/Documentation/perf-stat.txt 
> b/tools/perf/Documentation/perf-stat.txt
> index 52ef7a9..6629a8e 100644
> --- a/tools/perf/Documentation/perf-stat.txt
> +++ b/tools/perf/Documentation/perf-stat.txt
> @@ -211,6 +211,25 @@ $ perf stat -- make -j
>  
>   Wall-clock time elapsed:   719.554352 msecs
>  
> +CSV FORMAT
> +--
> +
> +With -x, perf stat is able to output a not-quite-CSV format output
> +(commas in the output are not put into "")
> +
> +The fields are in this order:
> +
> + - optional usec time stamp in fractions of second (with -I xxx)
> + - unit of the counter value or empty
> + - event name
> + - counter value
> + - run time of counter
> + - percentage of measurement time the counter was running
> + - optional metric value
> + - optional unit of metric
> +
> +Additional metrics may be printed with all earlier fields being empty.

[jolsa@krava perf]$ sudo ./perf stat -e cycles,instructions -a -x, 
160517940,,cycles,2357448795,100.00,,Ghz,2357448795,100.00

 ^  what's this data?

84822675,,instructions,2357537479,100.00,0.53,insn per cycle


,,,2357537479,100.00,,stalled cycles per insn,2357537479,100.00

this line is probably wrong, as noted in previous email..?


thanks,
jirka


Re: [PATCH 6/9] perf, tools, stat: Document CSV format in manpage

2016-01-22 Thread Jiri Olsa
On Tue, Jan 19, 2016 at 06:26:49PM -0800, Andi Kleen wrote:
> From: Andi Kleen 
> 
> With all the recently added fields in the perf stat CSV output
> we should finally document them in the man page. Do this here.
> 
> Signed-off-by: Andi Kleen 
> ---
>  tools/perf/Documentation/perf-stat.txt | 19 +++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/tools/perf/Documentation/perf-stat.txt 
> b/tools/perf/Documentation/perf-stat.txt
> index 52ef7a9..6629a8e 100644
> --- a/tools/perf/Documentation/perf-stat.txt
> +++ b/tools/perf/Documentation/perf-stat.txt
> @@ -211,6 +211,25 @@ $ perf stat -- make -j
>  
>   Wall-clock time elapsed:   719.554352 msecs
>  
> +CSV FORMAT
> +--
> +
> +With -x, perf stat is able to output a not-quite-CSV format output
> +(commas in the output are not put into "")
> +
> +The fields are in this order:
> +
> + - optional usec time stamp in fractions of second (with -I xxx)
> + - unit of the counter value or empty
> + - event name
> + - counter value
> + - run time of counter
> + - percentage of measurement time the counter was running
> + - optional metric value
> + - optional unit of metric
> +

[jolsa@krava perf]$ sudo ./perf stat -e cycles,instructions -a -x,
202537075,,cycles,4062752065,100.00,,Ghz,4062752065,100.00
71798923,,instructions,4063098840,100.00,0.35,insn per cycle

hum, isn't the first number the 'counter value' ? doc says it's 4th

jirka