Re: [PATCH 7/7] arm64: dts: tegra210-p2597: Remove no-1-8-v from sdmmc1
On Wed, 25 Jul 2018 09:58:37 +0300 Mikko Perttunen wrote: > Looks like patch 6 will probably cause tegra-sdhci to start advertising > faster modes (see " if (!IS_ERR(host->mmc->supply.vqmmc))" in > sdhci-tegra.c). With that patch and this, will the SDHCI core start to > try putting us into these higher modes? Clearly that won't work yet > before the upcoming patches. The SDHCI core won't do that yet at this point. The host capability bits for the higher speed modes are currently masked by tegra_sdhci_reset() in sdhci-tegra. The modes are unmasked in another patch after everything that's required to support the modes has been implemented. -Aapo
Re: [PATCH 7/7] arm64: dts: tegra210-p2597: Remove no-1-8-v from sdmmc1
On Wed, 25 Jul 2018 09:58:37 +0300 Mikko Perttunen wrote: > Looks like patch 6 will probably cause tegra-sdhci to start advertising > faster modes (see " if (!IS_ERR(host->mmc->supply.vqmmc))" in > sdhci-tegra.c). With that patch and this, will the SDHCI core start to > try putting us into these higher modes? Clearly that won't work yet > before the upcoming patches. The SDHCI core won't do that yet at this point. The host capability bits for the higher speed modes are currently masked by tegra_sdhci_reset() in sdhci-tegra. The modes are unmasked in another patch after everything that's required to support the modes has been implemented. -Aapo
Re: [PATCH 7/7] arm64: dts: tegra210-p2597: Remove no-1-8-v from sdmmc1
Looks like patch 6 will probably cause tegra-sdhci to start advertising
faster modes (see " if (!IS_ERR(host->mmc->supply.vqmmc))" in
sdhci-tegra.c). With that patch and this, will the SDHCI core start to
try putting us into these higher modes? Clearly that won't work yet
before the upcoming patches.
Mikko
On 20.07.2018 15:45, Aapo Vienamo wrote:
Allow sdmmc1 to set the signaling voltage to 1.8 V in order to support
faster signaling modes.
Signed-off-by: Aapo Vienamo
---
arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
index 9d5a0e6..365726d 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
@@ -1452,7 +1452,6 @@
sdhci@700b {
status = "okay";
bus-width = <4>;
- no-1-8-v;
cd-gpios = < TEGRA_GPIO(Z, 1) GPIO_ACTIVE_LOW>;
Re: [PATCH 7/7] arm64: dts: tegra210-p2597: Remove no-1-8-v from sdmmc1
Looks like patch 6 will probably cause tegra-sdhci to start advertising
faster modes (see " if (!IS_ERR(host->mmc->supply.vqmmc))" in
sdhci-tegra.c). With that patch and this, will the SDHCI core start to
try putting us into these higher modes? Clearly that won't work yet
before the upcoming patches.
Mikko
On 20.07.2018 15:45, Aapo Vienamo wrote:
Allow sdmmc1 to set the signaling voltage to 1.8 V in order to support
faster signaling modes.
Signed-off-by: Aapo Vienamo
---
arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
index 9d5a0e6..365726d 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
@@ -1452,7 +1452,6 @@
sdhci@700b {
status = "okay";
bus-width = <4>;
- no-1-8-v;
cd-gpios = < TEGRA_GPIO(Z, 1) GPIO_ACTIVE_LOW>;
[PATCH 7/7] arm64: dts: tegra210-p2597: Remove no-1-8-v from sdmmc1
Allow sdmmc1 to set the signaling voltage to 1.8 V in order to support
faster signaling modes.
Signed-off-by: Aapo Vienamo
---
arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
index 9d5a0e6..365726d 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
@@ -1452,7 +1452,6 @@
sdhci@700b {
status = "okay";
bus-width = <4>;
- no-1-8-v;
cd-gpios = < TEGRA_GPIO(Z, 1) GPIO_ACTIVE_LOW>;
--
2.7.4
[PATCH 7/7] arm64: dts: tegra210-p2597: Remove no-1-8-v from sdmmc1
Allow sdmmc1 to set the signaling voltage to 1.8 V in order to support
faster signaling modes.
Signed-off-by: Aapo Vienamo
---
arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
index 9d5a0e6..365726d 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
@@ -1452,7 +1452,6 @@
sdhci@700b {
status = "okay";
bus-width = <4>;
- no-1-8-v;
cd-gpios = < TEGRA_GPIO(Z, 1) GPIO_ACTIVE_LOW>;
--
2.7.4
