Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare
Hello Sylwester, On 23 January 2014 16:11, Sylwester Nawrocki wrote: > Hi, > > On 23/01/14 11:18, Naveen Krishna Ch wrote: >> Hello All, >> >> On 15 January 2014 14:47, Naveen Krishna Chatradhi >> wrote: >>> This patch set adds use of clk_prepare/clk_unprepare as >>> required by generic clock framework. >>> >>> Signed-off-by: Naveen Krishna Chatradhi >>> Reviewed-by: Tomasz Figa >>> --- >>> Changes since v3: >>> None >>> >>> drivers/crypto/s5p-sss.c |6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c >>> index f7c66c7..870e794 100644 >>> --- a/drivers/crypto/s5p-sss.c >>> +++ b/drivers/crypto/s5p-sss.c >>> @@ -648,7 +648,7 @@ static int s5p_aes_probe(struct platform_device *pdev) >>> return -ENOENT; >>> } >>> >>> - clk_enable(pdata->clk); >>> + clk_prepare_enable(pdata->clk); > > How about properly checking the return value ? Sure, Thanks. > > -- > Thanks, > Sylwester -- Shine bright, (: Nav :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare
Hello Sylwester, On 23 January 2014 16:11, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi, On 23/01/14 11:18, Naveen Krishna Ch wrote: Hello All, On 15 January 2014 14:47, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch set adds use of clk_prepare/clk_unprepare as required by generic clock framework. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- Changes since v3: None drivers/crypto/s5p-sss.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index f7c66c7..870e794 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -648,7 +648,7 @@ static int s5p_aes_probe(struct platform_device *pdev) return -ENOENT; } - clk_enable(pdata-clk); + clk_prepare_enable(pdata-clk); How about properly checking the return value ? Sure, Thanks. -- Thanks, Sylwester -- Shine bright, (: Nav :) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare
Hi, On 23/01/14 11:18, Naveen Krishna Ch wrote: > Hello All, > > On 15 January 2014 14:47, Naveen Krishna Chatradhi > wrote: >> This patch set adds use of clk_prepare/clk_unprepare as >> required by generic clock framework. >> >> Signed-off-by: Naveen Krishna Chatradhi >> Reviewed-by: Tomasz Figa >> --- >> Changes since v3: >> None >> >> drivers/crypto/s5p-sss.c |6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c >> index f7c66c7..870e794 100644 >> --- a/drivers/crypto/s5p-sss.c >> +++ b/drivers/crypto/s5p-sss.c >> @@ -648,7 +648,7 @@ static int s5p_aes_probe(struct platform_device *pdev) >> return -ENOENT; >> } >> >> - clk_enable(pdata->clk); >> + clk_prepare_enable(pdata->clk); How about properly checking the return value ? -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare
Hello All, On 15 January 2014 14:47, Naveen Krishna Chatradhi wrote: > This patch set adds use of clk_prepare/clk_unprepare as > required by generic clock framework. > > Signed-off-by: Naveen Krishna Chatradhi > Reviewed-by: Tomasz Figa > --- > Changes since v3: > None > > drivers/crypto/s5p-sss.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c > index f7c66c7..870e794 100644 > --- a/drivers/crypto/s5p-sss.c > +++ b/drivers/crypto/s5p-sss.c > @@ -648,7 +648,7 @@ static int s5p_aes_probe(struct platform_device *pdev) > return -ENOENT; > } > > - clk_enable(pdata->clk); > + clk_prepare_enable(pdata->clk); > > spin_lock_init(>lock); > pdata->ioaddr = devm_ioremap(dev, res->start, > @@ -711,7 +711,7 @@ static int s5p_aes_probe(struct platform_device *pdev) > tasklet_kill(>tasklet); > > err_irq: > - clk_disable(pdata->clk); > + clk_disable_unprepare(pdata->clk); > > s5p_dev = NULL; > > @@ -731,7 +731,7 @@ static int s5p_aes_remove(struct platform_device *pdev) > > tasklet_kill(>tasklet); > > - clk_disable(pdata->clk); > + clk_disable_unprepare(pdata->clk); > > s5p_dev = NULL; > > -- > 1.7.9.5 Any update on this patch, Please > -- Shine bright, (: Nav :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare
Hello All, On 15 January 2014 14:47, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch set adds use of clk_prepare/clk_unprepare as required by generic clock framework. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- Changes since v3: None drivers/crypto/s5p-sss.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index f7c66c7..870e794 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -648,7 +648,7 @@ static int s5p_aes_probe(struct platform_device *pdev) return -ENOENT; } - clk_enable(pdata-clk); + clk_prepare_enable(pdata-clk); spin_lock_init(pdata-lock); pdata-ioaddr = devm_ioremap(dev, res-start, @@ -711,7 +711,7 @@ static int s5p_aes_probe(struct platform_device *pdev) tasklet_kill(pdata-tasklet); err_irq: - clk_disable(pdata-clk); + clk_disable_unprepare(pdata-clk); s5p_dev = NULL; @@ -731,7 +731,7 @@ static int s5p_aes_remove(struct platform_device *pdev) tasklet_kill(pdata-tasklet); - clk_disable(pdata-clk); + clk_disable_unprepare(pdata-clk); s5p_dev = NULL; -- 1.7.9.5 Any update on this patch, Please -- Shine bright, (: Nav :) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare
Hi, On 23/01/14 11:18, Naveen Krishna Ch wrote: Hello All, On 15 January 2014 14:47, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch set adds use of clk_prepare/clk_unprepare as required by generic clock framework. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- Changes since v3: None drivers/crypto/s5p-sss.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index f7c66c7..870e794 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -648,7 +648,7 @@ static int s5p_aes_probe(struct platform_device *pdev) return -ENOENT; } - clk_enable(pdata-clk); + clk_prepare_enable(pdata-clk); How about properly checking the return value ? -- Thanks, Sylwester -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare
This patch set adds use of clk_prepare/clk_unprepare as required by generic clock framework. Signed-off-by: Naveen Krishna Chatradhi Reviewed-by: Tomasz Figa --- Changes since v3: None drivers/crypto/s5p-sss.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index f7c66c7..870e794 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -648,7 +648,7 @@ static int s5p_aes_probe(struct platform_device *pdev) return -ENOENT; } - clk_enable(pdata->clk); + clk_prepare_enable(pdata->clk); spin_lock_init(>lock); pdata->ioaddr = devm_ioremap(dev, res->start, @@ -711,7 +711,7 @@ static int s5p_aes_probe(struct platform_device *pdev) tasklet_kill(>tasklet); err_irq: - clk_disable(pdata->clk); + clk_disable_unprepare(pdata->clk); s5p_dev = NULL; @@ -731,7 +731,7 @@ static int s5p_aes_remove(struct platform_device *pdev) tasklet_kill(>tasklet); - clk_disable(pdata->clk); + clk_disable_unprepare(pdata->clk); s5p_dev = NULL; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare
This patch set adds use of clk_prepare/clk_unprepare as required by generic clock framework. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- Changes since v3: None drivers/crypto/s5p-sss.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index f7c66c7..870e794 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -648,7 +648,7 @@ static int s5p_aes_probe(struct platform_device *pdev) return -ENOENT; } - clk_enable(pdata-clk); + clk_prepare_enable(pdata-clk); spin_lock_init(pdata-lock); pdata-ioaddr = devm_ioremap(dev, res-start, @@ -711,7 +711,7 @@ static int s5p_aes_probe(struct platform_device *pdev) tasklet_kill(pdata-tasklet); err_irq: - clk_disable(pdata-clk); + clk_disable_unprepare(pdata-clk); s5p_dev = NULL; @@ -731,7 +731,7 @@ static int s5p_aes_remove(struct platform_device *pdev) tasklet_kill(pdata-tasklet); - clk_disable(pdata-clk); + clk_disable_unprepare(pdata-clk); s5p_dev = NULL; -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
