Re: [PATCH AUTOSEL 4.14 10/21] ARM: make lookup_processor_type() non-__init
On Wed, Nov 28, 2018 at 09:12:52AM -0500, Sasha Levin wrote: > On Fri, Nov 23, 2018 at 12:02:54AM +, Russell King - ARM Linux wrote: > >Hi Sasha, > > > >We need to keep track of which Spectre patches have been backported > >and which haven't. David Long has been doing the backport work, > >which doesn't include all the patches in my present spectre branch. > >You've picked up the last five, meaning there's a bunch in the middle > >of the entire series which haven't yet been considered - for example, > >the Spectre variant 1.1 patches. > > I'll drop all the ones you pointed out from my branches. Sometimes it's > difficult to tell if a certain patch is part of the spectre fix. Given that all the 32-bit ARM Spectre patches are sequential in a branch, it shouldn't be too difficult as it's possible to list all the commit IDs using: $ git rev-list v4.16..383fb3ee8024 where 383fb3ee8024 is the current head. I'm not anticipating at this time anything further. > >The entire series of 32-bit ARM Spectre patches can be listed in > >mainline via: > > > >$ git log v4.16..383fb3ee8024 > > > >where almost all of those need to be applied to stable kernels, with > >possible manual back-porting where they don't apply. > > Is it something that will be backported at some point? Yes, as I mentioned, this is work that David Long is undertaking, with a separate review process before submitting the backported patches for inclusion in the appropriate stable tree. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
Re: [PATCH AUTOSEL 4.14 10/21] ARM: make lookup_processor_type() non-__init
On Wed, Nov 28, 2018 at 09:12:52AM -0500, Sasha Levin wrote: > On Fri, Nov 23, 2018 at 12:02:54AM +, Russell King - ARM Linux wrote: > >Hi Sasha, > > > >We need to keep track of which Spectre patches have been backported > >and which haven't. David Long has been doing the backport work, > >which doesn't include all the patches in my present spectre branch. > >You've picked up the last five, meaning there's a bunch in the middle > >of the entire series which haven't yet been considered - for example, > >the Spectre variant 1.1 patches. > > I'll drop all the ones you pointed out from my branches. Sometimes it's > difficult to tell if a certain patch is part of the spectre fix. Given that all the 32-bit ARM Spectre patches are sequential in a branch, it shouldn't be too difficult as it's possible to list all the commit IDs using: $ git rev-list v4.16..383fb3ee8024 where 383fb3ee8024 is the current head. I'm not anticipating at this time anything further. > >The entire series of 32-bit ARM Spectre patches can be listed in > >mainline via: > > > >$ git log v4.16..383fb3ee8024 > > > >where almost all of those need to be applied to stable kernels, with > >possible manual back-porting where they don't apply. > > Is it something that will be backported at some point? Yes, as I mentioned, this is work that David Long is undertaking, with a separate review process before submitting the backported patches for inclusion in the appropriate stable tree. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
Re: [PATCH AUTOSEL 4.14 10/21] ARM: make lookup_processor_type() non-__init
On Fri, Nov 23, 2018 at 12:02:54AM +, Russell King - ARM Linux wrote: Hi Sasha, We need to keep track of which Spectre patches have been backported and which haven't. David Long has been doing the backport work, which doesn't include all the patches in my present spectre branch. You've picked up the last five, meaning there's a bunch in the middle of the entire series which haven't yet been considered - for example, the Spectre variant 1.1 patches. I'll drop all the ones you pointed out from my branches. Sometimes it's difficult to tell if a certain patch is part of the spectre fix. The entire series of 32-bit ARM Spectre patches can be listed in mainline via: $ git log v4.16..383fb3ee8024 where almost all of those need to be applied to stable kernels, with possible manual back-porting where they don't apply. Is it something that will be backported at some point? -- Thanks, Sasha
Re: [PATCH AUTOSEL 4.14 10/21] ARM: make lookup_processor_type() non-__init
On Fri, Nov 23, 2018 at 12:02:54AM +, Russell King - ARM Linux wrote: Hi Sasha, We need to keep track of which Spectre patches have been backported and which haven't. David Long has been doing the backport work, which doesn't include all the patches in my present spectre branch. You've picked up the last five, meaning there's a bunch in the middle of the entire series which haven't yet been considered - for example, the Spectre variant 1.1 patches. I'll drop all the ones you pointed out from my branches. Sometimes it's difficult to tell if a certain patch is part of the spectre fix. The entire series of 32-bit ARM Spectre patches can be listed in mainline via: $ git log v4.16..383fb3ee8024 where almost all of those need to be applied to stable kernels, with possible manual back-porting where they don't apply. Is it something that will be backported at some point? -- Thanks, Sasha
Re: [PATCH AUTOSEL 4.14 10/21] ARM: make lookup_processor_type() non-__init
Hi Sasha,
We need to keep track of which Spectre patches have been backported
and which haven't. David Long has been doing the backport work,
which doesn't include all the patches in my present spectre branch.
You've picked up the last five, meaning there's a bunch in the middle
of the entire series which haven't yet been considered - for example,
the Spectre variant 1.1 patches.
The entire series of 32-bit ARM Spectre patches can be listed in
mainline via:
$ git log v4.16..383fb3ee8024
where almost all of those need to be applied to stable kernels, with
possible manual back-porting where they don't apply.
On Thu, Nov 22, 2018 at 02:54:41PM -0500, Sasha Levin wrote:
> From: Russell King
>
> [ Upstream commit 899a42f836678a595f7d2bc36a5a0c2b03d08cbc ]
>
> Move lookup_processor_type() out of the __init section so it is callable
> from (eg) the secondary startup code during hotplug.
>
> Reviewed-by: Julien Thierry
> Signed-off-by: Russell King
> Signed-off-by: Sasha Levin
> ---
> arch/arm/kernel/head-common.S | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/kernel/head-common.S b/arch/arm/kernel/head-common.S
> index 8733012d231f..7e662bdd5cb3 100644
> --- a/arch/arm/kernel/head-common.S
> +++ b/arch/arm/kernel/head-common.S
> @@ -122,6 +122,9 @@ __mmap_switched_data:
> .long init_thread_union + THREAD_START_SP @ sp
> .size __mmap_switched_data, . - __mmap_switched_data
>
> + __FINIT
> + .text
> +
> /*
> * This provides a C-API version of __lookup_processor_type
> */
> @@ -133,9 +136,6 @@ ENTRY(lookup_processor_type)
> ldmfd sp!, {r4 - r6, r9, pc}
> ENDPROC(lookup_processor_type)
>
> - __FINIT
> - .text
> -
> /*
> * Read processor ID register (CP#15, CR0), and look up in the linker-built
> * supported processor list. Note that we can't use the absolute addresses
> --
> 2.17.1
>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
Re: [PATCH AUTOSEL 4.14 10/21] ARM: make lookup_processor_type() non-__init
Hi Sasha,
We need to keep track of which Spectre patches have been backported
and which haven't. David Long has been doing the backport work,
which doesn't include all the patches in my present spectre branch.
You've picked up the last five, meaning there's a bunch in the middle
of the entire series which haven't yet been considered - for example,
the Spectre variant 1.1 patches.
The entire series of 32-bit ARM Spectre patches can be listed in
mainline via:
$ git log v4.16..383fb3ee8024
where almost all of those need to be applied to stable kernels, with
possible manual back-porting where they don't apply.
On Thu, Nov 22, 2018 at 02:54:41PM -0500, Sasha Levin wrote:
> From: Russell King
>
> [ Upstream commit 899a42f836678a595f7d2bc36a5a0c2b03d08cbc ]
>
> Move lookup_processor_type() out of the __init section so it is callable
> from (eg) the secondary startup code during hotplug.
>
> Reviewed-by: Julien Thierry
> Signed-off-by: Russell King
> Signed-off-by: Sasha Levin
> ---
> arch/arm/kernel/head-common.S | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/kernel/head-common.S b/arch/arm/kernel/head-common.S
> index 8733012d231f..7e662bdd5cb3 100644
> --- a/arch/arm/kernel/head-common.S
> +++ b/arch/arm/kernel/head-common.S
> @@ -122,6 +122,9 @@ __mmap_switched_data:
> .long init_thread_union + THREAD_START_SP @ sp
> .size __mmap_switched_data, . - __mmap_switched_data
>
> + __FINIT
> + .text
> +
> /*
> * This provides a C-API version of __lookup_processor_type
> */
> @@ -133,9 +136,6 @@ ENTRY(lookup_processor_type)
> ldmfd sp!, {r4 - r6, r9, pc}
> ENDPROC(lookup_processor_type)
>
> - __FINIT
> - .text
> -
> /*
> * Read processor ID register (CP#15, CR0), and look up in the linker-built
> * supported processor list. Note that we can't use the absolute addresses
> --
> 2.17.1
>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
[PATCH AUTOSEL 4.14 10/21] ARM: make lookup_processor_type() non-__init
From: Russell King
[ Upstream commit 899a42f836678a595f7d2bc36a5a0c2b03d08cbc ]
Move lookup_processor_type() out of the __init section so it is callable
from (eg) the secondary startup code during hotplug.
Reviewed-by: Julien Thierry
Signed-off-by: Russell King
Signed-off-by: Sasha Levin
---
arch/arm/kernel/head-common.S | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/kernel/head-common.S b/arch/arm/kernel/head-common.S
index 8733012d231f..7e662bdd5cb3 100644
--- a/arch/arm/kernel/head-common.S
+++ b/arch/arm/kernel/head-common.S
@@ -122,6 +122,9 @@ __mmap_switched_data:
.long init_thread_union + THREAD_START_SP @ sp
.size __mmap_switched_data, . - __mmap_switched_data
+ __FINIT
+ .text
+
/*
* This provides a C-API version of __lookup_processor_type
*/
@@ -133,9 +136,6 @@ ENTRY(lookup_processor_type)
ldmfd sp!, {r4 - r6, r9, pc}
ENDPROC(lookup_processor_type)
- __FINIT
- .text
-
/*
* Read processor ID register (CP#15, CR0), and look up in the linker-built
* supported processor list. Note that we can't use the absolute addresses
--
2.17.1
[PATCH AUTOSEL 4.14 10/21] ARM: make lookup_processor_type() non-__init
From: Russell King
[ Upstream commit 899a42f836678a595f7d2bc36a5a0c2b03d08cbc ]
Move lookup_processor_type() out of the __init section so it is callable
from (eg) the secondary startup code during hotplug.
Reviewed-by: Julien Thierry
Signed-off-by: Russell King
Signed-off-by: Sasha Levin
---
arch/arm/kernel/head-common.S | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/kernel/head-common.S b/arch/arm/kernel/head-common.S
index 8733012d231f..7e662bdd5cb3 100644
--- a/arch/arm/kernel/head-common.S
+++ b/arch/arm/kernel/head-common.S
@@ -122,6 +122,9 @@ __mmap_switched_data:
.long init_thread_union + THREAD_START_SP @ sp
.size __mmap_switched_data, . - __mmap_switched_data
+ __FINIT
+ .text
+
/*
* This provides a C-API version of __lookup_processor_type
*/
@@ -133,9 +136,6 @@ ENTRY(lookup_processor_type)
ldmfd sp!, {r4 - r6, r9, pc}
ENDPROC(lookup_processor_type)
- __FINIT
- .text
-
/*
* Read processor ID register (CP#15, CR0), and look up in the linker-built
* supported processor list. Note that we can't use the absolute addresses
--
2.17.1
