Re: [PATCH AUTOSEL 5.2 09/44] intel_th: Use the correct style for SPDX License Identifier
On Tue, Aug 20, 2019 at 07:27:22AM -0700, Greg Kroah-Hartman wrote: On Tue, Aug 20, 2019 at 09:39:53AM -0400, Sasha Levin wrote: From: Nishad Kamdar [ Upstream commit fac7b714c514fcc41e1d6450c694b0a5f8d3 ] This patch corrects the SPDX License Identifier style in header files related to Drivers for Intel(R) Trace Hub controller. For C header files Documentation/process/license-rules.rst mandates C-like comments (opposed to C source files where C++ style should be used) Changes made by using a script provided by Joe Perches here: https://lkml.org/lkml/2019/2/7/46 Suggested-by: Joe Perches Signed-off-by: Nishad Kamdar Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/hwtracing/intel_th/msu.h | 2 +- drivers/hwtracing/intel_th/pti.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Not really a stable patch at all, unless you want to start backporting all SPDX changes (hint, NO we do not!) :) please drop this from everywhere. And what triggered this? It's just comment changes, shouldn't the autobot know to ignore those? It got a score just above my cutoff, and I missed it during review :( FWIW, there's no explicit rule to ignore documentation, AUTOSEL sort of learned to do it on it's own, but here it seems that the content of the commit message outweighed the code change metrics. -- Thanks, Sasha
Re: [PATCH AUTOSEL 5.2 09/44] intel_th: Use the correct style for SPDX License Identifier
On Tue, Aug 20, 2019 at 09:39:53AM -0400, Sasha Levin wrote: > From: Nishad Kamdar > > [ Upstream commit fac7b714c514fcc41e1d6450c694b0a5f8d3 ] > > This patch corrects the SPDX License Identifier style > in header files related to Drivers for Intel(R) Trace Hub > controller. > For C header files Documentation/process/license-rules.rst > mandates C-like comments (opposed to C source files where > C++ style should be used) > > Changes made by using a script provided by Joe Perches here: > https://lkml.org/lkml/2019/2/7/46 > > Suggested-by: Joe Perches > Signed-off-by: Nishad Kamdar > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Sasha Levin > --- > drivers/hwtracing/intel_th/msu.h | 2 +- > drivers/hwtracing/intel_th/pti.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Not really a stable patch at all, unless you want to start backporting all SPDX changes (hint, NO we do not!) :) please drop this from everywhere. And what triggered this? It's just comment changes, shouldn't the autobot know to ignore those? thanks, greg k-h
[PATCH AUTOSEL 5.2 09/44] intel_th: Use the correct style for SPDX License Identifier
From: Nishad Kamdar [ Upstream commit fac7b714c514fcc41e1d6450c694b0a5f8d3 ] This patch corrects the SPDX License Identifier style in header files related to Drivers for Intel(R) Trace Hub controller. For C header files Documentation/process/license-rules.rst mandates C-like comments (opposed to C source files where C++ style should be used) Changes made by using a script provided by Joe Perches here: https://lkml.org/lkml/2019/2/7/46 Suggested-by: Joe Perches Signed-off-by: Nishad Kamdar Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/hwtracing/intel_th/msu.h | 2 +- drivers/hwtracing/intel_th/pti.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/intel_th/msu.h b/drivers/hwtracing/intel_th/msu.h index 574c16004cb2e..13d9b141d 100644 --- a/drivers/hwtracing/intel_th/msu.h +++ b/drivers/hwtracing/intel_th/msu.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0 +/* SPDX-License-Identifier: GPL-2.0 */ /* * Intel(R) Trace Hub Memory Storage Unit (MSU) data structures * diff --git a/drivers/hwtracing/intel_th/pti.h b/drivers/hwtracing/intel_th/pti.h index e9381babc84c3..7dfc0431333b7 100644 --- a/drivers/hwtracing/intel_th/pti.h +++ b/drivers/hwtracing/intel_th/pti.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0 +/* SPDX-License-Identifier: GPL-2.0 */ /* * Intel(R) Trace Hub PTI output data structures * -- 2.20.1
