Re: [PATCH AUTOSEL 5.8 11/42] nvme: skip noiob for zoned devices
On Mon, Aug 31, 2020 at 09:38:18AM -0600, Keith Busch wrote: On Mon, Aug 31, 2020 at 11:29:03AM -0400, Sasha Levin wrote: From: Keith Busch [ Upstream commit c41ad98bebb8f4f0335b3c50dbb7583a6149dce4 ] Zoned block devices reuse the chunk_sectors queue limit to define zone boundaries. If a such a device happens to also report an optimal boundary, do not use that to define the chunk_sectors as that may intermittently interfere with io splitting and zone size queries. Signed-off-by: Keith Busch Signed-off-by: Sagi Grimberg Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin You can safely drop this from stable: nvme zoned devices were only introduced to linux in 5.9. Dropped, thanks! -- Thanks, Sasha
[PATCH AUTOSEL 5.8 11/42] nvme: skip noiob for zoned devices
From: Keith Busch [ Upstream commit c41ad98bebb8f4f0335b3c50dbb7583a6149dce4 ] Zoned block devices reuse the chunk_sectors queue limit to define zone boundaries. If a such a device happens to also report an optimal boundary, do not use that to define the chunk_sectors as that may intermittently interfere with io splitting and zone size queries. Signed-off-by: Keith Busch Signed-off-by: Sagi Grimberg Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index f38548e6d55ec..6ea0bab621df3 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -1975,7 +1975,7 @@ static int __nvme_revalidate_disk(struct gendisk *disk, struct nvme_id_ns *id) } } - if (iob) + if (iob && !blk_queue_is_zoned(ns->queue)) blk_queue_chunk_sectors(ns->queue, rounddown_pow_of_two(iob)); nvme_update_disk_info(disk, ns, id); #ifdef CONFIG_NVME_MULTIPATH -- 2.25.1
Re: [PATCH AUTOSEL 5.8 11/42] nvme: skip noiob for zoned devices
On Mon, Aug 31, 2020 at 11:29:03AM -0400, Sasha Levin wrote: > From: Keith Busch > > [ Upstream commit c41ad98bebb8f4f0335b3c50dbb7583a6149dce4 ] > > Zoned block devices reuse the chunk_sectors queue limit to define zone > boundaries. If a such a device happens to also report an optimal > boundary, do not use that to define the chunk_sectors as that may > intermittently interfere with io splitting and zone size queries. > > Signed-off-by: Keith Busch > Signed-off-by: Sagi Grimberg > Signed-off-by: Jens Axboe > Signed-off-by: Sasha Levin You can safely drop this from stable: nvme zoned devices were only introduced to linux in 5.9.
