Re: [PATCH RESEND] mpt3sas: Fix for block device of raid exists even after deleting raid disk
> "Sreekanth" == Sreekanth Reddywrites: Sreekanth> While merging mpt3sas & mpt2sas code, we posted below patch Sreekanth> for WarpDrive support, [...] Sreekanth> Due to above hunk, we are not initializing raid_device's Sreekanth> starget for raid volumes, and so during raid disk deletion Sreekanth> driver is not calling scsi_remove_target() API as driver Sreekanth> observes starget field of raid_device's structure as NULL. Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH RESEND] mpt3sas: Fix for block device of raid exists even after deleting raid disk
> "Sreekanth" == Sreekanth Reddy writes: Sreekanth> While merging mpt3sas & mpt2sas code, we posted below patch Sreekanth> for WarpDrive support, [...] Sreekanth> Due to above hunk, we are not initializing raid_device's Sreekanth> starget for raid volumes, and so during raid disk deletion Sreekanth> driver is not calling scsi_remove_target() API as driver Sreekanth> observes starget field of raid_device's structure as NULL. Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering
[PATCH RESEND] mpt3sas: Fix for block device of raid exists even after deleting raid disk
While merging mpt3sas & mpt2sas code, we posted below patch for WarpDrive support, mpt3sas: Ported WarpDrive product SSS6200 support commit id is 7786ab6aff In this patch and in the below hunk, we have added is_warpdrive check condition on the wrong line --- scsih_target_alloc(struct scsi_target *starget) sas_target_priv_data->handle = raid_device->handle; sas_target_priv_data->sas_address = raid_device->wwid; sas_target_priv_data->flags |= MPT_TARGET_FLAGS_VOLUME; - raid_device->starget = starget; + sas_target_priv_data->raid_device = raid_device; + if (ioc->is_warpdrive) + raid_device->starget = starget; } spin_unlock_irqrestore(>raid_device_lock, flags); return 0; -- Actually that check should be for below line sas_target_priv_data->raid_device = raid_device; Due to above hunk, we are not initializing raid_device's starget for raid volumes, and so during raid disk deletion driver is not calling scsi_remove_target() API as driver observes starget field of raid_device's structure as NULL. Signed-off-by: Sreekanth ReddyCc: --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index 981be7b..618c9df8 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -1279,9 +1279,9 @@ scsih_target_alloc(struct scsi_target *starget) sas_target_priv_data->handle = raid_device->handle; sas_target_priv_data->sas_address = raid_device->wwid; sas_target_priv_data->flags |= MPT_TARGET_FLAGS_VOLUME; - sas_target_priv_data->raid_device = raid_device; if (ioc->is_warpdrive) - raid_device->starget = starget; + sas_target_priv_data->raid_device = raid_device; + raid_device->starget = starget; } spin_unlock_irqrestore(>raid_device_lock, flags); return 0; -- 2.4.3
[PATCH RESEND] mpt3sas: Fix for block device of raid exists even after deleting raid disk
While merging mpt3sas & mpt2sas code, we posted below patch for WarpDrive support, mpt3sas: Ported WarpDrive product SSS6200 support commit id is 7786ab6aff In this patch and in the below hunk, we have added is_warpdrive check condition on the wrong line --- scsih_target_alloc(struct scsi_target *starget) sas_target_priv_data->handle = raid_device->handle; sas_target_priv_data->sas_address = raid_device->wwid; sas_target_priv_data->flags |= MPT_TARGET_FLAGS_VOLUME; - raid_device->starget = starget; + sas_target_priv_data->raid_device = raid_device; + if (ioc->is_warpdrive) + raid_device->starget = starget; } spin_unlock_irqrestore(>raid_device_lock, flags); return 0; -- Actually that check should be for below line sas_target_priv_data->raid_device = raid_device; Due to above hunk, we are not initializing raid_device's starget for raid volumes, and so during raid disk deletion driver is not calling scsi_remove_target() API as driver observes starget field of raid_device's structure as NULL. Signed-off-by: Sreekanth Reddy Cc: --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index 981be7b..618c9df8 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -1279,9 +1279,9 @@ scsih_target_alloc(struct scsi_target *starget) sas_target_priv_data->handle = raid_device->handle; sas_target_priv_data->sas_address = raid_device->wwid; sas_target_priv_data->flags |= MPT_TARGET_FLAGS_VOLUME; - sas_target_priv_data->raid_device = raid_device; if (ioc->is_warpdrive) - raid_device->starget = starget; + sas_target_priv_data->raid_device = raid_device; + raid_device->starget = starget; } spin_unlock_irqrestore(>raid_device_lock, flags); return 0; -- 2.4.3