Re: [PATCH RESEND 1/2 v3] menuconfig: Add Save/Load buttons
Wang, All, On Wednesday 19 December 2012 Wang YanQing wrote: > If menuconfig have Save/Load button like alternative > .config editors, xconfig, nconfig, etc.We will have > a obvious benefit when use menuconfig just like > when we use others, we can Save/Load our .config quickly > and conveniently. > > This patch add the Save/Load button for menuconfig. > > [remove trailing space while at it for below line: > "*) Formerly when I used Page Down and Page Up, the cursor would be set" > ] > > Changes: > V1-V2: > 1:use PATH_MAX instead of hard code suggested by Yann E. MORIN > 2:drop the spurious empty-line removal suggested by Yann E. MORIN > V2-V3: > 1:ajust buttons position well centered reported by Yann E. MORIN > > Signed-off-by: Wang YanQing Reviewd-by: "Yann E. MORIN" Tested-by: "Yann E. MORIN" Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `.---: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL| v conspiracy. | '--^---^--^' -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RESEND 1/2 v3] menuconfig: Add Save/Load buttons
Wang, All, On Wednesday 19 December 2012 Wang YanQing wrote: If menuconfig have Save/Load button like alternative .config editors, xconfig, nconfig, etc.We will have a obvious benefit when use menuconfig just like when we use others, we can Save/Load our .config quickly and conveniently. This patch add the Save/Load button for menuconfig. [remove trailing space while at it for below line: *) Formerly when I used Page Down and Page Up, the cursor would be set ] Changes: V1-V2: 1:use PATH_MAX instead of hard code suggested by Yann E. MORIN 2:drop the spurious empty-line removal suggested by Yann E. MORIN V2-V3: 1:ajust buttons position well centered reported by Yann E. MORIN Signed-off-by: Wang YanQing udkni...@gmail.com Reviewd-by: Yann E. MORIN yann.morin.1...@free.fr Tested-by: Yann E. MORIN yann.morin.1...@free.fr Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `.---: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL| v conspiracy. | '--^---^--^' -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH RESEND 1/2 v3] menuconfig: Add Save/Load buttons
If menuconfig have Save/Load button like alternative
.config editors, xconfig, nconfig, etc.We will have
a obvious benefit when use menuconfig just like
when we use others, we can Save/Load our .config quickly
and conveniently.
This patch add the Save/Load button for menuconfig.
[remove trailing space while at it for below line:
"*) Formerly when I used Page Down and Page Up, the cursor would be set"
]
Changes:
V1-V2:
1:use PATH_MAX instead of hard code suggested by Yann E. MORIN
2:drop the spurious empty-line removal suggested by Yann E. MORIN
V2-V3:
1:ajust buttons position well centered reported by Yann E. MORIN
Signed-off-by: Wang YanQing
---
Hi Yann E. MORIN, can you give your Rev'ed-by and Tested-by to this patch,
Thanks very much for your help, I just don't know how to computer out the
right position :)
The Changes appear in commit log is ok, I found I am not the first guy
do it, it maybe useful in some case :)
scripts/kconfig/lxdialog/menubox.c | 20 +++-
scripts/kconfig/mconf.c| 30 +-
2 files changed, 36 insertions(+), 14 deletions(-)
diff --git a/scripts/kconfig/lxdialog/menubox.c
b/scripts/kconfig/lxdialog/menubox.c
index 1d60473..8b534d5 100644
--- a/scripts/kconfig/lxdialog/menubox.c
+++ b/scripts/kconfig/lxdialog/menubox.c
@@ -26,7 +26,7 @@
*
**) A bugfix for the Page-Down problem
*
- **) Formerly when I used Page Down and Page Up, the cursor would be set
+ **) Formerly when I used Page Down and Page Up, the cursor would be set
*to the first position in the menu box. Now lxdialog is a bit
*smarter and works more like other menu systems (just have a look at
*it).
@@ -154,12 +154,14 @@ static void print_arrows(WINDOW * win, int item_no, int
scroll, int y, int x,
*/
static void print_buttons(WINDOW * win, int height, int width, int selected)
{
- int x = width / 2 - 16;
+ int x = width / 2 - 28;
int y = height - 2;
print_button(win, gettext("Select"), y, x, selected == 0);
print_button(win, gettext(" Exit "), y, x + 12, selected == 1);
print_button(win, gettext(" Help "), y, x + 24, selected == 2);
+ print_button(win, gettext(" Save "), y, x + 36, selected == 3);
+ print_button(win, gettext(" Load "), y, x + 48, selected == 4);
wmove(win, y, x + 1 + 12 * selected);
wrefresh(win);
@@ -372,7 +374,7 @@ do_resize:
case TAB:
case KEY_RIGHT:
button = ((key == KEY_LEFT ? --button : ++button) < 0)
- ? 2 : (button > 2 ? 0 : button);
+ ? 4 : (button > 4 ? 0 : button);
print_buttons(dialog, height, width, button);
wrefresh(menu);
@@ -399,17 +401,17 @@ do_resize:
return 2;
case 's':
case 'y':
- return 3;
+ return 5;
case 'n':
- return 4;
+ return 6;
case 'm':
- return 5;
+ return 7;
case ' ':
- return 6;
+ return 8;
case '/':
- return 7;
+ return 9;
case 'z':
- return 8;
+ return 10;
case '\n':
return button;
}
diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
index 53975cf..9fb90f0 100644
--- a/scripts/kconfig/mconf.c
+++ b/scripts/kconfig/mconf.c
@@ -280,6 +280,7 @@ static struct menu *current_menu;
static int child_count;
static int single_menu_mode;
static int show_all_options;
+static int save_and_exit;
static void conf(struct menu *menu, struct menu *active_menu);
static void conf_choice(struct menu *menu);
@@ -651,6 +652,12 @@ static void conf(struct menu *menu, struct menu
*active_menu)
show_helptext(_("README"), _(mconf_readme));
break;
case 3:
+ conf_save();
+ break;
+ case 4:
+ conf_load();
+ break;
+ case 5:
if (item_is_tag('t')) {
if (sym_set_tristate_value(sym, yes))
break;
@@ -658,24 +665,24 @@ static void conf(struct menu *menu, struct menu
*active_menu)
show_textbox(NULL, setmod_text, 6, 74);
}
break;
-
[PATCH RESEND 1/2 v3] menuconfig: Add Save/Load buttons
If menuconfig have Save/Load button like alternative
.config editors, xconfig, nconfig, etc.We will have
a obvious benefit when use menuconfig just like
when we use others, we can Save/Load our .config quickly
and conveniently.
This patch add the Save/Load button for menuconfig.
[remove trailing space while at it for below line:
*) Formerly when I used Page Down and Page Up, the cursor would be set
]
Changes:
V1-V2:
1:use PATH_MAX instead of hard code suggested by Yann E. MORIN
2:drop the spurious empty-line removal suggested by Yann E. MORIN
V2-V3:
1:ajust buttons position well centered reported by Yann E. MORIN
Signed-off-by: Wang YanQing udkni...@gmail.com
---
Hi Yann E. MORIN, can you give your Rev'ed-by and Tested-by to this patch,
Thanks very much for your help, I just don't know how to computer out the
right position :)
The Changes appear in commit log is ok, I found I am not the first guy
do it, it maybe useful in some case :)
scripts/kconfig/lxdialog/menubox.c | 20 +++-
scripts/kconfig/mconf.c| 30 +-
2 files changed, 36 insertions(+), 14 deletions(-)
diff --git a/scripts/kconfig/lxdialog/menubox.c
b/scripts/kconfig/lxdialog/menubox.c
index 1d60473..8b534d5 100644
--- a/scripts/kconfig/lxdialog/menubox.c
+++ b/scripts/kconfig/lxdialog/menubox.c
@@ -26,7 +26,7 @@
*
**) A bugfix for the Page-Down problem
*
- **) Formerly when I used Page Down and Page Up, the cursor would be set
+ **) Formerly when I used Page Down and Page Up, the cursor would be set
*to the first position in the menu box. Now lxdialog is a bit
*smarter and works more like other menu systems (just have a look at
*it).
@@ -154,12 +154,14 @@ static void print_arrows(WINDOW * win, int item_no, int
scroll, int y, int x,
*/
static void print_buttons(WINDOW * win, int height, int width, int selected)
{
- int x = width / 2 - 16;
+ int x = width / 2 - 28;
int y = height - 2;
print_button(win, gettext(Select), y, x, selected == 0);
print_button(win, gettext( Exit ), y, x + 12, selected == 1);
print_button(win, gettext( Help ), y, x + 24, selected == 2);
+ print_button(win, gettext( Save ), y, x + 36, selected == 3);
+ print_button(win, gettext( Load ), y, x + 48, selected == 4);
wmove(win, y, x + 1 + 12 * selected);
wrefresh(win);
@@ -372,7 +374,7 @@ do_resize:
case TAB:
case KEY_RIGHT:
button = ((key == KEY_LEFT ? --button : ++button) 0)
- ? 2 : (button 2 ? 0 : button);
+ ? 4 : (button 4 ? 0 : button);
print_buttons(dialog, height, width, button);
wrefresh(menu);
@@ -399,17 +401,17 @@ do_resize:
return 2;
case 's':
case 'y':
- return 3;
+ return 5;
case 'n':
- return 4;
+ return 6;
case 'm':
- return 5;
+ return 7;
case ' ':
- return 6;
+ return 8;
case '/':
- return 7;
+ return 9;
case 'z':
- return 8;
+ return 10;
case '\n':
return button;
}
diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
index 53975cf..9fb90f0 100644
--- a/scripts/kconfig/mconf.c
+++ b/scripts/kconfig/mconf.c
@@ -280,6 +280,7 @@ static struct menu *current_menu;
static int child_count;
static int single_menu_mode;
static int show_all_options;
+static int save_and_exit;
static void conf(struct menu *menu, struct menu *active_menu);
static void conf_choice(struct menu *menu);
@@ -651,6 +652,12 @@ static void conf(struct menu *menu, struct menu
*active_menu)
show_helptext(_(README), _(mconf_readme));
break;
case 3:
+ conf_save();
+ break;
+ case 4:
+ conf_load();
+ break;
+ case 5:
if (item_is_tag('t')) {
if (sym_set_tristate_value(sym, yes))
break;
@@ -658,24 +665,24 @@ static void conf(struct menu *menu, struct menu
*active_menu)
show_textbox(NULL, setmod_text, 6, 74);
}
break;
-
