Re: [PATCH RFC v2 0/3] cleanups for pstore and ramoops

2018-11-14 Thread Joel Fernandes
On Wed, Nov 14, 2018 at 01:14:57AM -0600, Kees Cook wrote:
> On Sat, Nov 3, 2018 at 6:38 PM, Joel Fernandes (Google)
>  wrote:
> > Here are some simple cleanups and fixes for ramoops in pstore. Let me know
> > what you think, thanks.
> 
> I took these and slightly tweaked code locations for the first one.
> I'll send out the series for review when I'm back from Plumber's.

Cool, thanks!

 - Joel



Re: [PATCH RFC v2 0/3] cleanups for pstore and ramoops

2018-11-14 Thread Joel Fernandes
On Wed, Nov 14, 2018 at 01:14:57AM -0600, Kees Cook wrote:
> On Sat, Nov 3, 2018 at 6:38 PM, Joel Fernandes (Google)
>  wrote:
> > Here are some simple cleanups and fixes for ramoops in pstore. Let me know
> > what you think, thanks.
> 
> I took these and slightly tweaked code locations for the first one.
> I'll send out the series for review when I'm back from Plumber's.

Cool, thanks!

 - Joel



Re: [PATCH RFC v2 0/3] cleanups for pstore and ramoops

2018-11-13 Thread Kees Cook
On Sat, Nov 3, 2018 at 6:38 PM, Joel Fernandes (Google)
 wrote:
> Here are some simple cleanups and fixes for ramoops in pstore. Let me know
> what you think, thanks.

I took these and slightly tweaked code locations for the first one.
I'll send out the series for review when I'm back from Plumber's.

-Kees

>
> Joel Fernandes (Google) (3):
> pstore: map pstore types to names
> pstore: simplify ramoops_get_next_prz arguments
> pstore: donot treat empty buffers as valid
>
> fs/pstore/inode.c  | 53 +-
> fs/pstore/ram.c| 52 +++--
> fs/pstore/ram_core.c   |  2 +-
> include/linux/pstore.h | 37 ++
> include/linux/pstore_ram.h |  2 ++
> 5 files changed, 67 insertions(+), 79 deletions(-)
>
> --
> 2.19.1.930.g4563a0d9d0-goog
>



-- 
Kees Cook


Re: [PATCH RFC v2 0/3] cleanups for pstore and ramoops

2018-11-13 Thread Kees Cook
On Sat, Nov 3, 2018 at 6:38 PM, Joel Fernandes (Google)
 wrote:
> Here are some simple cleanups and fixes for ramoops in pstore. Let me know
> what you think, thanks.

I took these and slightly tweaked code locations for the first one.
I'll send out the series for review when I'm back from Plumber's.

-Kees

>
> Joel Fernandes (Google) (3):
> pstore: map pstore types to names
> pstore: simplify ramoops_get_next_prz arguments
> pstore: donot treat empty buffers as valid
>
> fs/pstore/inode.c  | 53 +-
> fs/pstore/ram.c| 52 +++--
> fs/pstore/ram_core.c   |  2 +-
> include/linux/pstore.h | 37 ++
> include/linux/pstore_ram.h |  2 ++
> 5 files changed, 67 insertions(+), 79 deletions(-)
>
> --
> 2.19.1.930.g4563a0d9d0-goog
>



-- 
Kees Cook


[PATCH RFC v2 0/3] cleanups for pstore and ramoops

2018-11-03 Thread Joel Fernandes (Google)
Here are some simple cleanups and fixes for ramoops in pstore. Let me know
what you think, thanks.

Joel Fernandes (Google) (3):
pstore: map pstore types to names
pstore: simplify ramoops_get_next_prz arguments
pstore: donot treat empty buffers as valid

fs/pstore/inode.c  | 53 +-
fs/pstore/ram.c| 52 +++--
fs/pstore/ram_core.c   |  2 +-
include/linux/pstore.h | 37 ++
include/linux/pstore_ram.h |  2 ++
5 files changed, 67 insertions(+), 79 deletions(-)

--
2.19.1.930.g4563a0d9d0-goog



[PATCH RFC v2 0/3] cleanups for pstore and ramoops

2018-11-03 Thread Joel Fernandes (Google)
Here are some simple cleanups and fixes for ramoops in pstore. Let me know
what you think, thanks.

Joel Fernandes (Google) (3):
pstore: map pstore types to names
pstore: simplify ramoops_get_next_prz arguments
pstore: donot treat empty buffers as valid

fs/pstore/inode.c  | 53 +-
fs/pstore/ram.c| 52 +++--
fs/pstore/ram_core.c   |  2 +-
include/linux/pstore.h | 37 ++
include/linux/pstore_ram.h |  2 ++
5 files changed, 67 insertions(+), 79 deletions(-)

--
2.19.1.930.g4563a0d9d0-goog