Re: [PATCH RT 1/9] Revert "fs: jbd2: pull your plug when waiting for space"

2017-12-11 Thread Sebastian Andrzej Siewior 
On 2017-12-11 10:53:06 [-0500], Steven Rostedt wrote:
> 
> Yep. Not sure why I didn't include it in 4.4. I added it to my queue,
> and started testing it, which is one of the reasons I haven't posted it
> yet. Also, my internet connectivity has be really poor while traveling
> this time.

Ah okay then. I misunderstood you then as I though that you would skip
that patch and the revert (and keep things as they are). Sorry for that.

> -- Steve

Sebastian

Re: [PATCH RT 1/9] Revert "fs: jbd2: pull your plug when waiting for space"

2017-12-11 Thread Sebastian Andrzej Siewior 
On 2017-12-11 10:53:06 [-0500], Steven Rostedt wrote:
> 
> Yep. Not sure why I didn't include it in 4.4. I added it to my queue,
> and started testing it, which is one of the reasons I haven't posted it
> yet. Also, my internet connectivity has be really poor while traveling
> this time.

Ah okay then. I misunderstood you then as I though that you would skip
that patch and the revert (and keep things as they are). Sorry for that.

> -- Steve

Sebastian

Re: [PATCH RT 1/9] Revert "fs: jbd2: pull your plug when waiting for space"

2017-12-11 Thread Steven Rostedt 
On Mon, 11 Dec 2017 16:37:09 +0100
Sebastian Andrzej Siewior  wrote:
 
> > Now it does appear I'm missing that for 4.4. I wonder why I didn't pull
> > it in there. Perhaps it wasn't needed, which means this isn't needed
> > either.  
> 
> I strongly suggest to include "locking/rt-mutex: fix deadlock in device
> mapper / block-IO". We had a workaround in the jbd/ext3 code which then
> moved into jbd2/ext4 after people complained about the same problem. I
> wasn't sure about the root-cause back then but now with explanation we
> have in the fix patch I'm sure this is one of the bugs we have since day
> one.

Yep. Not sure why I didn't include it in 4.4. I added it to my queue,
and started testing it, which is one of the reasons I haven't posted it
yet. Also, my internet connectivity has be really poor while traveling
this time.

-- Steve

Re: [PATCH RT 1/9] Revert "fs: jbd2: pull your plug when waiting for space"

2017-12-11 Thread Steven Rostedt 
On Mon, 11 Dec 2017 16:37:09 +0100
Sebastian Andrzej Siewior  wrote:
 
> > Now it does appear I'm missing that for 4.4. I wonder why I didn't pull
> > it in there. Perhaps it wasn't needed, which means this isn't needed
> > either.  
> 
> I strongly suggest to include "locking/rt-mutex: fix deadlock in device
> mapper / block-IO". We had a workaround in the jbd/ext3 code which then
> moved into jbd2/ext4 after people complained about the same problem. I
> wasn't sure about the root-cause back then but now with explanation we
> have in the fix patch I'm sure this is one of the bugs we have since day
> one.

Yep. Not sure why I didn't include it in 4.4. I added it to my queue,
and started testing it, which is one of the reasons I haven't posted it
yet. Also, my internet connectivity has be really poor while traveling
this time.

-- Steve

Re: [PATCH RT 1/9] Revert "fs: jbd2: pull your plug when waiting for space"

2017-12-11 Thread Sebastian Andrzej Siewior 
On 2017-12-08 13:15:24 [-0500], Steven Rostedt wrote:
> On Mon, 4 Dec 2017 09:45:45 +0100
> Sebastian Andrzej Siewior  wrote:
> 
> > On 2017-12-01 20:36:59 [-0500], Steven Rostedt wrote:
> > > 4.4.102-rt117-rc1 stable review patch.
> > > If anyone has any objections, please let me know.  
> > 
> > Same comment as in the 4.9.65-rt57-rc2 review (that you might need
> > locking-rt-mutex-fix-deadlock-in-device-mapper-block.patch).
> 
> Now it does appear I'm missing that for 4.4. I wonder why I didn't pull
> it in there. Perhaps it wasn't needed, which means this isn't needed
> either.

I strongly suggest to include "locking/rt-mutex: fix deadlock in device
mapper / block-IO". We had a workaround in the jbd/ext3 code which then
moved into jbd2/ext4 after people complained about the same problem. I
wasn't sure about the root-cause back then but now with explanation we
have in the fix patch I'm sure this is one of the bugs we have since day
one.

> Thanks!
> 
> -- Steve

Sebastian

Re: [PATCH RT 1/9] Revert "fs: jbd2: pull your plug when waiting for space"

2017-12-11 Thread Sebastian Andrzej Siewior 
On 2017-12-08 13:15:24 [-0500], Steven Rostedt wrote:
> On Mon, 4 Dec 2017 09:45:45 +0100
> Sebastian Andrzej Siewior  wrote:
> 
> > On 2017-12-01 20:36:59 [-0500], Steven Rostedt wrote:
> > > 4.4.102-rt117-rc1 stable review patch.
> > > If anyone has any objections, please let me know.  
> > 
> > Same comment as in the 4.9.65-rt57-rc2 review (that you might need
> > locking-rt-mutex-fix-deadlock-in-device-mapper-block.patch).
> 
> Now it does appear I'm missing that for 4.4. I wonder why I didn't pull
> it in there. Perhaps it wasn't needed, which means this isn't needed
> either.

I strongly suggest to include "locking/rt-mutex: fix deadlock in device
mapper / block-IO". We had a workaround in the jbd/ext3 code which then
moved into jbd2/ext4 after people complained about the same problem. I
wasn't sure about the root-cause back then but now with explanation we
have in the fix patch I'm sure this is one of the bugs we have since day
one.

> Thanks!
> 
> -- Steve

Sebastian

Re: [PATCH RT 1/9] Revert "fs: jbd2: pull your plug when waiting for space"

2017-12-08 Thread Steven Rostedt 
On Mon, 4 Dec 2017 09:45:45 +0100
Sebastian Andrzej Siewior  wrote:

> On 2017-12-01 20:36:59 [-0500], Steven Rostedt wrote:
> > 4.4.102-rt117-rc1 stable review patch.
> > If anyone has any objections, please let me know.  
> 
> Same comment as in the 4.9.65-rt57-rc2 review (that you might need
> locking-rt-mutex-fix-deadlock-in-device-mapper-block.patch).

Now it does appear I'm missing that for 4.4. I wonder why I didn't pull
it in there. Perhaps it wasn't needed, which means this isn't needed
either.

Thanks!

-- Steve

Re: [PATCH RT 1/9] Revert "fs: jbd2: pull your plug when waiting for space"

2017-12-08 Thread Steven Rostedt 
On Mon, 4 Dec 2017 09:45:45 +0100
Sebastian Andrzej Siewior  wrote:

> On 2017-12-01 20:36:59 [-0500], Steven Rostedt wrote:
> > 4.4.102-rt117-rc1 stable review patch.
> > If anyone has any objections, please let me know.  
> 
> Same comment as in the 4.9.65-rt57-rc2 review (that you might need
> locking-rt-mutex-fix-deadlock-in-device-mapper-block.patch).

Now it does appear I'm missing that for 4.4. I wonder why I didn't pull
it in there. Perhaps it wasn't needed, which means this isn't needed
either.

Thanks!

-- Steve

Re: [PATCH RT 1/9] Revert "fs: jbd2: pull your plug when waiting for space"

2017-12-04 Thread Sebastian Andrzej Siewior 
On 2017-12-01 20:36:59 [-0500], Steven Rostedt wrote:
> 4.4.102-rt117-rc1 stable review patch.
> If anyone has any objections, please let me know.

Same comment as in the 4.9.65-rt57-rc2 review (that you might need
locking-rt-mutex-fix-deadlock-in-device-mapper-block.patch).

Sebastian

Re: [PATCH RT 1/9] Revert "fs: jbd2: pull your plug when waiting for space"

2017-12-04 Thread Sebastian Andrzej Siewior 
On 2017-12-01 20:36:59 [-0500], Steven Rostedt wrote:
> 4.4.102-rt117-rc1 stable review patch.
> If anyone has any objections, please let me know.

Same comment as in the 4.9.65-rt57-rc2 review (that you might need
locking-rt-mutex-fix-deadlock-in-device-mapper-block.patch).

Sebastian

[PATCH RT 1/9] Revert "fs: jbd2: pull your plug when waiting for space"

2017-12-01 Thread Steven Rostedt 
4.4.102-rt117-rc1 stable review patch.
If anyone has any objections, please let me know.

--

From: Sebastian Andrzej Siewior 

This reverts commit "fs: jbd2: pull your plug when waiting for space".
This was a duct-tape fix which shouldn't be needed since commit
"locking/rt-mutex: fix deadlock in device mapper / block-IO".

Cc: stable...@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Steven Rostedt (VMware) 
---
 fs/jbd2/checkpoint.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/jbd2/checkpoint.c b/fs/jbd2/checkpoint.c
index 6e18a06aaabe..684996c8a3a4 100644
--- a/fs/jbd2/checkpoint.c
+++ b/fs/jbd2/checkpoint.c
@@ -116,8 +116,6 @@ void __jbd2_log_wait_for_space(journal_t *journal)
nblocks = jbd2_space_needed(journal);
while (jbd2_log_space_left(journal) < nblocks) {
write_unlock(>j_state_lock);
-   if (current->plug)
-   io_schedule();
mutex_lock(>j_checkpoint_mutex);
 
/*
-- 
2.13.2

[PATCH RT 1/9] Revert "fs: jbd2: pull your plug when waiting for space"

2017-12-01 Thread Steven Rostedt 
4.4.102-rt117-rc1 stable review patch.
If anyone has any objections, please let me know.

--

From: Sebastian Andrzej Siewior 

This reverts commit "fs: jbd2: pull your plug when waiting for space".
This was a duct-tape fix which shouldn't be needed since commit
"locking/rt-mutex: fix deadlock in device mapper / block-IO".

Cc: stable...@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Steven Rostedt (VMware) 
---
 fs/jbd2/checkpoint.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/jbd2/checkpoint.c b/fs/jbd2/checkpoint.c
index 6e18a06aaabe..684996c8a3a4 100644
--- a/fs/jbd2/checkpoint.c
+++ b/fs/jbd2/checkpoint.c
@@ -116,8 +116,6 @@ void __jbd2_log_wait_for_space(journal_t *journal)
nblocks = jbd2_space_needed(journal);
while (jbd2_log_space_left(journal) < nblocks) {
write_unlock(>j_state_lock);
-   if (current->plug)
-   io_schedule();
mutex_lock(>j_checkpoint_mutex);
 
/*
-- 
2.13.2