Re: [PATCH V1] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l

2019-10-16 Thread kgunda 

On 2019-10-16 13:45, Vinod Koul wrote:

On 04-10-19, 16:50, Kiran Gunda wrote:

Add support for the PM6150 and PM6150L GPIO support to the
Qualcomm PMIC GPIO binding.

Signed-off-by: Kiran Gunda 
---
 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4 
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++
 2 files changed, 6 insertions(+)

diff --git 
a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt 
b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt

index c32bf32..2f48cca 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
@@ -23,6 +23,8 @@ PMIC's from Qualcomm.
"qcom,pms405-gpio"
"qcom,pm8150-gpio"
"qcom,pm8150b-gpio"
+   "qcom,pm6150-gpio"
+   "qcom,pm6150l-gpio"

And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
if the device is on an spmi bus or an ssbi bus respectively
@@ -100,6 +102,8 @@ to specify in a pin configuration subnode:
 and gpio8)
gpio1-gpio12 for pm8150b (holes on gpio3, gpio4, gpio7)
gpio1-gpio12 for pm8150l (hole on gpio7)
+   gpio1-gpio10 for pm6150
+   gpio1-gpio12 for pm6150l


No holes on these?


Yes. No holes.

Other than this:

Reviewed-by: Vinod Koul 



 - function:
Usage: required
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c 
b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c

index f1fece5..387917c 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1121,6 +1121,8 @@ static int pmic_gpio_remove(struct 
platform_device *pdev)

{ .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 },
/* pm8150l has 12 GPIOs with holes on 7 */
{ .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
+   { .compatible = "qcom,pm6150-gpio", .data = (void *) 10 },
+   { .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 },
{ },
 };

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,

 a Linux Foundation Collaborative Project

Re: [PATCH V1] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l

2019-10-16 Thread Vinod Koul 
On 04-10-19, 16:50, Kiran Gunda wrote:
> Add support for the PM6150 and PM6150L GPIO support to the
> Qualcomm PMIC GPIO binding.
> 
> Signed-off-by: Kiran Gunda 
> ---
>  Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4 
>  drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt 
> b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> index c32bf32..2f48cca 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> @@ -23,6 +23,8 @@ PMIC's from Qualcomm.
>   "qcom,pms405-gpio"
>   "qcom,pm8150-gpio"
>   "qcom,pm8150b-gpio"
> + "qcom,pm6150-gpio"
> + "qcom,pm6150l-gpio"
>  
>   And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
>   if the device is on an spmi bus or an ssbi bus respectively
> @@ -100,6 +102,8 @@ to specify in a pin configuration subnode:
>and gpio8)
>   gpio1-gpio12 for pm8150b (holes on gpio3, gpio4, gpio7)
>   gpio1-gpio12 for pm8150l (hole on gpio7)
> + gpio1-gpio10 for pm6150
> + gpio1-gpio12 for pm6150l

No holes on these?

Other than this:

Reviewed-by: Vinod Koul 

>  
>  - function:
>   Usage: required
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c 
> b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index f1fece5..387917c 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -1121,6 +1121,8 @@ static int pmic_gpio_remove(struct platform_device 
> *pdev)
>   { .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 },
>   /* pm8150l has 12 GPIOs with holes on 7 */
>   { .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
> + { .compatible = "qcom,pm6150-gpio", .data = (void *) 10 },
> + { .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 },
>   { },
>  };
>  
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>  a Linux Foundation Collaborative Project

-- 
~Vinod

Re: [PATCH V1] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l

2019-10-09 Thread Linus Walleij 
On Fri, Oct 4, 2019 at 1:20 PM Kiran Gunda  wrote:

> Add support for the PM6150 and PM6150L GPIO support to the
> Qualcomm PMIC GPIO binding.
>
> Signed-off-by: Kiran Gunda 

Patch applied.

Yours,
Linus Walleij

Re: [PATCH V1] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l

2019-10-04 Thread Bjorn Andersson 
On Fri 04 Oct 04:20 PDT 2019, Kiran Gunda wrote:

> Add support for the PM6150 and PM6150L GPIO support to the
> Qualcomm PMIC GPIO binding.
> 
> Signed-off-by: Kiran Gunda 

Acked-by: Bjorn Andersson 

> ---
>  Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4 
>  drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt 
> b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> index c32bf32..2f48cca 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> @@ -23,6 +23,8 @@ PMIC's from Qualcomm.
>   "qcom,pms405-gpio"
>   "qcom,pm8150-gpio"
>   "qcom,pm8150b-gpio"
> + "qcom,pm6150-gpio"
> + "qcom,pm6150l-gpio"
>  
>   And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
>   if the device is on an spmi bus or an ssbi bus respectively
> @@ -100,6 +102,8 @@ to specify in a pin configuration subnode:
>and gpio8)
>   gpio1-gpio12 for pm8150b (holes on gpio3, gpio4, gpio7)
>   gpio1-gpio12 for pm8150l (hole on gpio7)
> + gpio1-gpio10 for pm6150
> + gpio1-gpio12 for pm6150l
>  
>  - function:
>   Usage: required
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c 
> b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index f1fece5..387917c 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -1121,6 +1121,8 @@ static int pmic_gpio_remove(struct platform_device 
> *pdev)
>   { .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 },
>   /* pm8150l has 12 GPIOs with holes on 7 */
>   { .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
> + { .compatible = "qcom,pm6150-gpio", .data = (void *) 10 },
> + { .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 },
>   { },
>  };
>  
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>  a Linux Foundation Collaborative Project
>

[PATCH V1] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l

2019-10-04 Thread Kiran Gunda 
Add support for the PM6150 and PM6150L GPIO support to the
Qualcomm PMIC GPIO binding.

Signed-off-by: Kiran Gunda 
---
 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4 
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt 
b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
index c32bf32..2f48cca 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
@@ -23,6 +23,8 @@ PMIC's from Qualcomm.
"qcom,pms405-gpio"
"qcom,pm8150-gpio"
"qcom,pm8150b-gpio"
+   "qcom,pm6150-gpio"
+   "qcom,pm6150l-gpio"
 
And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
if the device is on an spmi bus or an ssbi bus respectively
@@ -100,6 +102,8 @@ to specify in a pin configuration subnode:
 and gpio8)
gpio1-gpio12 for pm8150b (holes on gpio3, gpio4, gpio7)
gpio1-gpio12 for pm8150l (hole on gpio7)
+   gpio1-gpio10 for pm6150
+   gpio1-gpio12 for pm6150l
 
 - function:
Usage: required
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c 
b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index f1fece5..387917c 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1121,6 +1121,8 @@ static int pmic_gpio_remove(struct platform_device *pdev)
{ .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 },
/* pm8150l has 12 GPIOs with holes on 7 */
{ .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
+   { .compatible = "qcom,pm6150-gpio", .data = (void *) 10 },
+   { .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 },
{ },
 };
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
 a Linux Foundation Collaborative Project