Re: [PATCH V2] Subject: [PATCH] staging: rtl8723bs: core: Using comparison to true is error prone

On Sat, Jul 25, 2020 at 03:34:34PM +0200, Greg KH wrote:
> On Sat, Jul 25, 2020 at 02:28:06PM +0100, John Oldman wrote:
> > clear below issues reported by checkpatch.pl:
> > 
> > CHECK: Using comparison to true is error prone
> 
> Your subject line is very odd :(

Thanks, I should read all before I send: I will re-send the patch.

> 
> > Signed-off-by: John Oldman 
> > ---
> > v1: Initial attempt.
> > v2: Removed unneccessary parentheses around 'pregistrypriv->ht_enable'
> > Also considered clearing 'CHECK: Logical continuations should be on the 
> > previous line' report
> > but this results in exceeding line length guideline.
> >  drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c 
> > b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> > index ca98274ae390..7aacbe1b763e 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> > @@ -363,8 +363,9 @@ int rtw_generate_ie(struct registry_priv *pregistrypriv)
> > }
> > 
> > /* HT Cap. */
> > -   if (((pregistrypriv->wireless_mode_11_5N) || 
> > (pregistrypriv->wireless_mode_11_24N))
> > -   && (pregistrypriv->ht_enable == true)) {
> > +   if (((pregistrypriv->wireless_mode & WIRELESS_11_5N)
> > + || (pregistrypriv->wireless_mode & WIRELESS_11_24N))
> > + && pregistrypriv->ht_enable) {
> 
>  || and && go on the end of the line, not the front.
> 
> But you also changed other things that were not needed here, and you did
> not say that in your changelog text :(
> 
> thanks,
> 
> greg k-h

Re: [PATCH V2] Subject: [PATCH] staging: rtl8723bs: core: Using comparison to true is error prone

[Greg KH]

On Sat, Jul 25, 2020 at 02:28:06PM +0100, John Oldman wrote:
> clear below issues reported by checkpatch.pl:
> 
> CHECK: Using comparison to true is error prone

Your subject line is very odd :(

> Signed-off-by: John Oldman 
> ---
> v1: Initial attempt.
> v2: Removed unneccessary parentheses around 'pregistrypriv->ht_enable'
> Also considered clearing 'CHECK: Logical continuations should be on the 
> previous line' report
> but this results in exceeding line length guideline.
>  drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c 
> b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> index ca98274ae390..7aacbe1b763e 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> @@ -363,8 +363,9 @@ int rtw_generate_ie(struct registry_priv *pregistrypriv)
>   }
> 
>   /* HT Cap. */
> - if (((pregistrypriv->wireless_mode_11_5N) || 
> (pregistrypriv->wireless_mode_11_24N))
> - && (pregistrypriv->ht_enable == true)) {
> + if (((pregistrypriv->wireless_mode & WIRELESS_11_5N)
> +   || (pregistrypriv->wireless_mode & WIRELESS_11_24N))
> +   && pregistrypriv->ht_enable) {

 || and && go on the end of the line, not the front.

But you also changed other things that were not needed here, and you did
not say that in your changelog text :(

thanks,

greg k-h

[PATCH V2] Subject: [PATCH] staging: rtl8723bs: core: Using comparison to true is error prone

[John Oldman]

clear below issues reported by checkpatch.pl:

CHECK: Using comparison to true is error prone

Signed-off-by: John Oldman 
---
v1: Initial attempt.
v2: Removed unneccessary parentheses around 'pregistrypriv->ht_enable'
Also considered clearing 'CHECK: Logical continuations should be on the 
previous line' report
but this results in exceeding line length guideline.
 drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c 
b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
index ca98274ae390..7aacbe1b763e 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
@@ -363,8 +363,9 @@ int rtw_generate_ie(struct registry_priv *pregistrypriv)
}

/* HT Cap. */
-   if (((pregistrypriv->wireless_mode_11_5N) || 
(pregistrypriv->wireless_mode_11_24N))
-   && (pregistrypriv->ht_enable == true)) {
+   if (((pregistrypriv->wireless_mode & WIRELESS_11_5N)
+ || (pregistrypriv->wireless_mode & WIRELESS_11_24N))
+ && pregistrypriv->ht_enable) {
/* todo: */
}

--
2.17.1