Re: [PATCH V2] arm: mmp: build sram driver alone
On Thu, Dec 5, 2013 at 10:00 AM, Dan Williams wrote: > On Wed, Dec 4, 2013 at 5:36 PM, Qiao Zhou wrote: >> sram driver can be used by many chips besides CPU_MMP2, and so build >> it alone. Also need to select MMP_SRAM for MMP_TDMA driver. >> >> Reported-by: Dan Williams >> Signed-off-by: Qiao Zhou >> --- > > Looks good, thanks for fixing it up. > > -- > Dan Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V2] arm: mmp: build sram driver alone
On Thu, Dec 5, 2013 at 10:00 AM, Dan Williams dan.j.willi...@intel.com wrote: On Wed, Dec 4, 2013 at 5:36 PM, Qiao Zhou zhouq...@marvell.com wrote: sram driver can be used by many chips besides CPU_MMP2, and so build it alone. Also need to select MMP_SRAM for MMP_TDMA driver. Reported-by: Dan Williams dan.j.willi...@intel.com Signed-off-by: Qiao Zhou zhouq...@marvell.com --- Looks good, thanks for fixing it up. -- Dan Applied. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V2] arm: mmp: build sram driver alone
On Wed, Dec 4, 2013 at 5:36 PM, Qiao Zhou wrote: > sram driver can be used by many chips besides CPU_MMP2, and so build > it alone. Also need to select MMP_SRAM for MMP_TDMA driver. > > Reported-by: Dan Williams > Signed-off-by: Qiao Zhou > --- Looks good, thanks for fixing it up. -- Dan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH V2] arm-mmp-build-sram-driver-alone
V2 -> V1: combine the two patches together according to Dan's suggestion below. >Please combine the patches for two reasons: >1/ patch1 by itself makes the problem worse it prevents the mmp_tdma >driver from building even if CPU_MMP2 is selected. >2/ patch2 does not have a changelog and is the only user of the >enabling in patch1 V1 -> V0: No need for help text for MMP_SRAM in Kconfig and move it into MMP_TDMA text in Kconfig. Qiao Zhou (1): arm: mmp: build sram driver alone arch/arm/mach-mmp/Kconfig |3 +++ arch/arm/mach-mmp/Makefile |3 ++- drivers/dma/Kconfig|2 ++ 3 files changed, 7 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH V2] arm: mmp: build sram driver alone
sram driver can be used by many chips besides CPU_MMP2, and so build it alone. Also need to select MMP_SRAM for MMP_TDMA driver. Reported-by: Dan Williams Signed-off-by: Qiao Zhou --- arch/arm/mach-mmp/Kconfig |3 +++ arch/arm/mach-mmp/Makefile |3 ++- drivers/dma/Kconfig|2 ++ 3 files changed, 7 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig index ebdda83..ebdba87 100644 --- a/arch/arm/mach-mmp/Kconfig +++ b/arch/arm/mach-mmp/Kconfig @@ -136,4 +136,7 @@ config USB_EHCI_MV_U2O help Enables support for OTG controller which can be switched to host mode. +config MMP_SRAM + bool + endif diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile index 9b702a1..98f0f63 100644 --- a/arch/arm/mach-mmp/Makefile +++ b/arch/arm/mach-mmp/Makefile @@ -7,7 +7,8 @@ obj-y += common.o devices.o time.o # SoC support obj-$(CONFIG_CPU_PXA168) += pxa168.o obj-$(CONFIG_CPU_PXA910) += pxa910.o -obj-$(CONFIG_CPU_MMP2) += mmp2.o sram.o +obj-$(CONFIG_CPU_MMP2) += mmp2.o +obj-$(CONFIG_MMP_SRAM) += sram.o ifeq ($(CONFIG_COMMON_CLK), ) obj-y += clock.o diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index dd2874e..599f0ae 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -288,9 +288,11 @@ config MMP_TDMA bool "MMP Two-Channel DMA support" depends on ARCH_MMP select DMA_ENGINE + select MMP_SRAM help Support the MMP Two-Channel DMA engine. This engine used for MMP Audio DMA and pxa910 SQU. + It needs sram driver under mach-mmp. Say Y here if you enabled MMP ADMA, otherwise say N. -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH V2] arm: mmp: build sram driver alone
sram driver can be used by many chips besides CPU_MMP2, and so build it alone. Also need to select MMP_SRAM for MMP_TDMA driver. Reported-by: Dan Williams dan.j.willi...@intel.com Signed-off-by: Qiao Zhou zhouq...@marvell.com --- arch/arm/mach-mmp/Kconfig |3 +++ arch/arm/mach-mmp/Makefile |3 ++- drivers/dma/Kconfig|2 ++ 3 files changed, 7 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig index ebdda83..ebdba87 100644 --- a/arch/arm/mach-mmp/Kconfig +++ b/arch/arm/mach-mmp/Kconfig @@ -136,4 +136,7 @@ config USB_EHCI_MV_U2O help Enables support for OTG controller which can be switched to host mode. +config MMP_SRAM + bool + endif diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile index 9b702a1..98f0f63 100644 --- a/arch/arm/mach-mmp/Makefile +++ b/arch/arm/mach-mmp/Makefile @@ -7,7 +7,8 @@ obj-y += common.o devices.o time.o # SoC support obj-$(CONFIG_CPU_PXA168) += pxa168.o obj-$(CONFIG_CPU_PXA910) += pxa910.o -obj-$(CONFIG_CPU_MMP2) += mmp2.o sram.o +obj-$(CONFIG_CPU_MMP2) += mmp2.o +obj-$(CONFIG_MMP_SRAM) += sram.o ifeq ($(CONFIG_COMMON_CLK), ) obj-y += clock.o diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index dd2874e..599f0ae 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -288,9 +288,11 @@ config MMP_TDMA bool MMP Two-Channel DMA support depends on ARCH_MMP select DMA_ENGINE + select MMP_SRAM help Support the MMP Two-Channel DMA engine. This engine used for MMP Audio DMA and pxa910 SQU. + It needs sram driver under mach-mmp. Say Y here if you enabled MMP ADMA, otherwise say N. -- 1.7.0.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH V2] arm-mmp-build-sram-driver-alone
V2 - V1: combine the two patches together according to Dan's suggestion below. Please combine the patches for two reasons: 1/ patch1 by itself makes the problem worse it prevents the mmp_tdma driver from building even if CPU_MMP2 is selected. 2/ patch2 does not have a changelog and is the only user of the enabling in patch1 V1 - V0: No need for help text for MMP_SRAM in Kconfig and move it into MMP_TDMA text in Kconfig. Qiao Zhou (1): arm: mmp: build sram driver alone arch/arm/mach-mmp/Kconfig |3 +++ arch/arm/mach-mmp/Makefile |3 ++- drivers/dma/Kconfig|2 ++ 3 files changed, 7 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V2] arm: mmp: build sram driver alone
On Wed, Dec 4, 2013 at 5:36 PM, Qiao Zhou zhouq...@marvell.com wrote: sram driver can be used by many chips besides CPU_MMP2, and so build it alone. Also need to select MMP_SRAM for MMP_TDMA driver. Reported-by: Dan Williams dan.j.willi...@intel.com Signed-off-by: Qiao Zhou zhouq...@marvell.com --- Looks good, thanks for fixing it up. -- Dan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
