Re: [PATCH V2] ata: ahci: ceva: Updated code by using dev_err_probe()

[Jens Axboe]

On 3/5/21 2:10 AM, Piyush Mehta wrote:
> Updated code with already prepared dev_err_probe(). It reduces code size
> and simplifies EPROBE_DEFER handling.

Applied, thanks.

-- 
Jens Axboe

Re: [PATCH V2] ata: ahci: ceva: Updated code by using dev_err_probe()

[Michal Simek]

Hi Jens,

On 3/5/21 10:10 AM, Piyush Mehta wrote:
> Updated code with already prepared dev_err_probe(). It reduces code size
> and simplifies EPROBE_DEFER handling.
> 
> Also, unify message format for similar error cases.
> 
> Signed-off-by: Piyush Mehta 
> Acked-by: Michal Simek 
> ---
> This patch is based on ahci-ceva patches:
> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-next=5542fabd9e07d6c49c07862e73070c325f93d390
> 
> Tree: 
> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/tree/?h=for-next
> 
> Changes for V2:
> - Address review comment- remove curly brackets {}. 
> ---
>  drivers/ata/ahci_ceva.c | 8 +++-
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/ata/ahci_ceva.c b/drivers/ata/ahci_ceva.c
> index b980218..50b56cd 100644
> --- a/drivers/ata/ahci_ceva.c
> +++ b/drivers/ata/ahci_ceva.c
> @@ -206,11 +206,9 @@ static int ceva_ahci_probe(struct platform_device *pdev)
>  
>   cevapriv->rst = devm_reset_control_get_optional_exclusive(>dev,
> NULL);
> - if (IS_ERR(cevapriv->rst)) {
> - if (PTR_ERR(cevapriv->rst) != -EPROBE_DEFER)
> - dev_err(>dev, "failed to get reset: %ld\n",
> - PTR_ERR(cevapriv->rst));
> - }
> + if (IS_ERR(cevapriv->rst))
> + dev_err_probe(>dev, PTR_ERR(cevapriv->rst),
> +   "failed to get reset\n");
>  
>   hpriv = ahci_platform_get_resources(pdev, 0);
>   if (IS_ERR(hpriv))
> 

Can you please apply this to your tree?

Thanks,
Michal

[PATCH V2] ata: ahci: ceva: Updated code by using dev_err_probe()

[Piyush Mehta]

Updated code with already prepared dev_err_probe(). It reduces code size
and simplifies EPROBE_DEFER handling.

Also, unify message format for similar error cases.

Signed-off-by: Piyush Mehta 
Acked-by: Michal Simek 
---
This patch is based on ahci-ceva patches:
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-next=5542fabd9e07d6c49c07862e73070c325f93d390

Tree: 
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/tree/?h=for-next

Changes for V2:
- Address review comment- remove curly brackets {}. 
---
 drivers/ata/ahci_ceva.c | 8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/ata/ahci_ceva.c b/drivers/ata/ahci_ceva.c
index b980218..50b56cd 100644
--- a/drivers/ata/ahci_ceva.c
+++ b/drivers/ata/ahci_ceva.c
@@ -206,11 +206,9 @@ static int ceva_ahci_probe(struct platform_device *pdev)
 
cevapriv->rst = devm_reset_control_get_optional_exclusive(>dev,
  NULL);
-   if (IS_ERR(cevapriv->rst)) {
-   if (PTR_ERR(cevapriv->rst) != -EPROBE_DEFER)
-   dev_err(>dev, "failed to get reset: %ld\n",
-   PTR_ERR(cevapriv->rst));
-   }
+   if (IS_ERR(cevapriv->rst))
+   dev_err_probe(>dev, PTR_ERR(cevapriv->rst),
+ "failed to get reset\n");
 
hpriv = ahci_platform_get_resources(pdev, 0);
if (IS_ERR(hpriv))
-- 
2.7.4