Re: [PATCH V2 1/2] ata: ahci: append new hflag AHCI_HFLAG_NO_FBS
On Thu, Apr 10, 2014 at 01:24:27PM +0800, Kefeng Wang wrote:
> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
> index 6bd4f66..573edb3 100644
> --- a/drivers/ata/libahci.c
> +++ b/drivers/ata/libahci.c
> @@ -452,6 +452,11 @@ void ahci_save_initial_config(struct device *dev,
> cap &= ~HOST_CAP_SNTF;
> }
>
> + if ((cap & HOST_CAP_FBS) && (hpriv->flags & AHCI_HFLAG_NO_FBS)) {
> + dev_info(dev, "controller can't do FBS, turning off CAP_FBS\n");
> + cap &= ~HOST_CAP_FBS;
> + }
Can you please put this chunk after YES_FBS?
> if (!(cap & HOST_CAP_FBS) && (hpriv->flags & AHCI_HFLAG_YES_FBS)) {
> dev_info(dev, "controller can do FBS, turning on CAP_FBS\n");
> cap |= HOST_CAP_FBS;
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V2 1/2] ata: ahci: append new hflag AHCI_HFLAG_NO_FBS
On Thu, Apr 10, 2014 at 01:24:27PM +0800, Kefeng Wang wrote:
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 6bd4f66..573edb3 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -452,6 +452,11 @@ void ahci_save_initial_config(struct device *dev,
cap = ~HOST_CAP_SNTF;
}
+ if ((cap HOST_CAP_FBS) (hpriv-flags AHCI_HFLAG_NO_FBS)) {
+ dev_info(dev, controller can't do FBS, turning off CAP_FBS\n);
+ cap = ~HOST_CAP_FBS;
+ }
Can you please put this chunk after YES_FBS?
if (!(cap HOST_CAP_FBS) (hpriv-flags AHCI_HFLAG_YES_FBS)) {
dev_info(dev, controller can do FBS, turning on CAP_FBS\n);
cap |= HOST_CAP_FBS;
Thanks.
--
tejun
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH V2 1/2] ata: ahci: append new hflag AHCI_HFLAG_NO_FBS
From: Kefeng Wang
Append AHCI_HFLAG_NO_FBS to force turning off FBS flag.
Signed-off-by: Haojian Zhuang
Signed-off-by: Kefeng Wang
---
drivers/ata/ahci.h|1 +
drivers/ata/libahci.c |5 +
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h
index 51af275..60db49b 100644
--- a/drivers/ata/ahci.h
+++ b/drivers/ata/ahci.h
@@ -235,6 +235,7 @@ enum {
port start (wait until
error-handling stage) */
AHCI_HFLAG_MULTI_MSI= (1 << 16), /* multiple PCI MSIs */
+ AHCI_HFLAG_NO_FBS = (1 << 17), /* no FBS */
/* ap->flags bits */
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 6bd4f66..573edb3 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -452,6 +452,11 @@ void ahci_save_initial_config(struct device *dev,
cap &= ~HOST_CAP_SNTF;
}
+ if ((cap & HOST_CAP_FBS) && (hpriv->flags & AHCI_HFLAG_NO_FBS)) {
+ dev_info(dev, "controller can't do FBS, turning off CAP_FBS\n");
+ cap &= ~HOST_CAP_FBS;
+ }
+
if (!(cap & HOST_CAP_FBS) && (hpriv->flags & AHCI_HFLAG_YES_FBS)) {
dev_info(dev, "controller can do FBS, turning on CAP_FBS\n");
cap |= HOST_CAP_FBS;
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH V2 1/2] ata: ahci: append new hflag AHCI_HFLAG_NO_FBS
From: Kefeng Wang kefeng.w...@linaro.org
Append AHCI_HFLAG_NO_FBS to force turning off FBS flag.
Signed-off-by: Haojian Zhuang haojian.zhu...@linaro.org
Signed-off-by: Kefeng Wang kefeng.w...@linaro.org
---
drivers/ata/ahci.h|1 +
drivers/ata/libahci.c |5 +
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h
index 51af275..60db49b 100644
--- a/drivers/ata/ahci.h
+++ b/drivers/ata/ahci.h
@@ -235,6 +235,7 @@ enum {
port start (wait until
error-handling stage) */
AHCI_HFLAG_MULTI_MSI= (1 16), /* multiple PCI MSIs */
+ AHCI_HFLAG_NO_FBS = (1 17), /* no FBS */
/* ap-flags bits */
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 6bd4f66..573edb3 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -452,6 +452,11 @@ void ahci_save_initial_config(struct device *dev,
cap = ~HOST_CAP_SNTF;
}
+ if ((cap HOST_CAP_FBS) (hpriv-flags AHCI_HFLAG_NO_FBS)) {
+ dev_info(dev, controller can't do FBS, turning off CAP_FBS\n);
+ cap = ~HOST_CAP_FBS;
+ }
+
if (!(cap HOST_CAP_FBS) (hpriv-flags AHCI_HFLAG_YES_FBS)) {
dev_info(dev, controller can do FBS, turning on CAP_FBS\n);
cap |= HOST_CAP_FBS;
--
1.7.1
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
