Re: [PATCH V3 0/8] Tegra XUSB charger detect support
On 14-05-2020 15:09, Felipe Balbi wrote: Nagarjuna Kristam writes: This patch series adds charger detect support on XUSB hardware used in Tegra210 and Tegra186 SoCs. This patchset is composed with : - dt bindings of XUSB Pad Controller - Tegra XUSB device mode driver to add vbus_draw support - Tegra PHY driver for charger detect support Tests done: - Connect USB cable from ubuntu host to micro-B port of DUT to detect SDP_TYPE charger - Connect USB cable from external powered USB hub(which inturn connects to ubuntu host) to micro-B port of DUT to detect CDP_TYPE charger. - Connect USB cable from USB charger to micro-B port of DUT to detect DCP_TYPE charger. DUT: Jetson-tx1, Jetson tx2. V3: - Added ACKed-by details for PHY driver and DT changes. - Functions and its arguments are aligned. - Tabs are used for alignment of MACRO's - For vbus_draw USDC callback, usb_phy set_power error is propogated. - Fixed various comments given by thierry. V2: - Added ACKed-by details for DT patches. - All patches rebased. Nagarjuna Kristam (8): dt-bindings: phy: tegra-xusb: Add charger-detect property usb: gadget: tegra-xudc: Add vbus_draw support phy: tegra: xusb: Add support for UTMI pad power control phy: tegra: xusb: Add USB2 pad power control support for Tegra210 phy: tegra: xusb: Add soc ops API to enable UTMI PAD protection phy: tegra: xusb: Add support for charger detect phy: tegra: xusb: Enable charger detect for Tegra186 phy: tegra: xusb: Enable charger detect for Tegra210 Is there a hard-dependency between gadget and phy patches? -- balbiNo dependency. They can be merged independently. - Nagarjuna
Re: [PATCH V3 0/8] Tegra XUSB charger detect support
Nagarjuna Kristam writes: > This patch series adds charger detect support on XUSB hardware used in > Tegra210 and Tegra186 SoCs. > > This patchset is composed with : > - dt bindings of XUSB Pad Controller > - Tegra XUSB device mode driver to add vbus_draw support > - Tegra PHY driver for charger detect support > > Tests done: > - Connect USB cable from ubuntu host to micro-B port of DUT to detect >SDP_TYPE charger > - Connect USB cable from external powered USB hub(which inturn connects >to ubuntu host) to micro-B port of DUT to detect CDP_TYPE charger. > - Connect USB cable from USB charger to micro-B port of DUT to detect >DCP_TYPE charger. > DUT: Jetson-tx1, Jetson tx2. > > V3: > - Added ACKed-by details for PHY driver and DT changes. > - Functions and its arguments are aligned. > - Tabs are used for alignment of MACRO's > - For vbus_draw USDC callback, usb_phy set_power error is propogated. > - Fixed various comments given by thierry. > V2: > - Added ACKed-by details for DT patches. > - All patches rebased. > > Nagarjuna Kristam (8): > dt-bindings: phy: tegra-xusb: Add charger-detect property > usb: gadget: tegra-xudc: Add vbus_draw support > phy: tegra: xusb: Add support for UTMI pad power control > phy: tegra: xusb: Add USB2 pad power control support for Tegra210 > phy: tegra: xusb: Add soc ops API to enable UTMI PAD protection > phy: tegra: xusb: Add support for charger detect > phy: tegra: xusb: Enable charger detect for Tegra186 > phy: tegra: xusb: Enable charger detect for Tegra210 Is there a hard-dependency between gadget and phy patches? -- balbi signature.asc Description: PGP signature
[PATCH V3 0/8] Tegra XUSB charger detect support
This patch series adds charger detect support on XUSB hardware used in Tegra210 and Tegra186 SoCs. This patchset is composed with : - dt bindings of XUSB Pad Controller - Tegra XUSB device mode driver to add vbus_draw support - Tegra PHY driver for charger detect support Tests done: - Connect USB cable from ubuntu host to micro-B port of DUT to detect SDP_TYPE charger - Connect USB cable from external powered USB hub(which inturn connects to ubuntu host) to micro-B port of DUT to detect CDP_TYPE charger. - Connect USB cable from USB charger to micro-B port of DUT to detect DCP_TYPE charger. DUT: Jetson-tx1, Jetson tx2. V3: - Added ACKed-by details for PHY driver and DT changes. - Functions and its arguments are aligned. - Tabs are used for alignment of MACRO's - For vbus_draw USDC callback, usb_phy set_power error is propogated. - Fixed various comments given by thierry. V2: - Added ACKed-by details for DT patches. - All patches rebased. Nagarjuna Kristam (8): dt-bindings: phy: tegra-xusb: Add charger-detect property usb: gadget: tegra-xudc: Add vbus_draw support phy: tegra: xusb: Add support for UTMI pad power control phy: tegra: xusb: Add USB2 pad power control support for Tegra210 phy: tegra: xusb: Add soc ops API to enable UTMI PAD protection phy: tegra: xusb: Add support for charger detect phy: tegra: xusb: Enable charger detect for Tegra186 phy: tegra: xusb: Enable charger detect for Tegra210 .../bindings/phy/nvidia,tegra124-xusb-padctl.txt | 4 + drivers/phy/tegra/Makefile | 2 +- drivers/phy/tegra/cd.c | 283 + drivers/phy/tegra/xusb-tegra186.c | 92 +-- drivers/phy/tegra/xusb-tegra210.c | 223 +++- drivers/phy/tegra/xusb.c | 80 ++ drivers/phy/tegra/xusb.h | 22 ++ drivers/usb/gadget/udc/tegra-xudc.c| 17 ++ 8 files changed, 638 insertions(+), 85 deletions(-) create mode 100644 drivers/phy/tegra/cd.c -- 2.7.4
