Re: [PATCH V3 1/5] firmware: imx: scu-seco: Add Secure Controller APIS

2020-11-11 Thread Daniel Baluta
On Tue, Nov 10, 2020 at 4:15 PM  wrote:
>
> From: Franck LENORMAND 

Looks good to me. Thanks Franck!

Reviewed-by: Daniel Baluta 


[PATCH V3 1/5] firmware: imx: scu-seco: Add Secure Controller APIS

2020-11-10 Thread franck . lenormand
From: Franck LENORMAND 

This patch adds the APIs:
 - imx_sc_seco_build_info: get commit and sha of SECO
 - imx_sc_seco_secvio_enable: enable SNVS IRQ handling
 - imx_sc_seco_secvio_config: configure SNVS register
 - imx_sc_seco_secvio_dgo_config: configure SNVS DGO register

Signed-off-by: Franck LENORMAND 
---
 drivers/firmware/imx/Makefile |   2 +-
 drivers/firmware/imx/imx-scu.c|   8 +-
 drivers/firmware/imx/seco.c   | 253 ++
 include/linux/firmware/imx/ipc.h  |   1 +
 include/linux/firmware/imx/sci.h  |   1 +
 include/linux/firmware/imx/svc/seco.h |  73 ++
 6 files changed, 334 insertions(+), 4 deletions(-)
 create mode 100644 drivers/firmware/imx/seco.c
 create mode 100644 include/linux/firmware/imx/svc/seco.h

diff --git a/drivers/firmware/imx/Makefile b/drivers/firmware/imx/Makefile
index b76acba..f23e2b0 100644
--- a/drivers/firmware/imx/Makefile
+++ b/drivers/firmware/imx/Makefile
@@ -1,4 +1,4 @@
 # SPDX-License-Identifier: GPL-2.0
 obj-$(CONFIG_IMX_DSP)  += imx-dsp.o
-obj-$(CONFIG_IMX_SCU)  += imx-scu.o misc.o imx-scu-irq.o rm.o 
imx-scu-soc.o
+obj-$(CONFIG_IMX_SCU)  += imx-scu.o misc.o imx-scu-irq.o rm.o 
imx-scu-soc.o seco.o
 obj-$(CONFIG_IMX_SCU_PD)   += scu-pd.o
diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c
index dca79ca..bf768d2 100644
--- a/drivers/firmware/imx/imx-scu.c
+++ b/drivers/firmware/imx/imx-scu.c
@@ -241,9 +241,11 @@ int imx_scu_call_rpc(struct imx_sc_ipc *sc_ipc, void *msg, 
bool have_resp)
 * APIs are defined as void function in SCU firmware, so they
 * should be treated as return success always.
 */
-   if ((saved_svc == IMX_SC_RPC_SVC_MISC) &&
-   (saved_func == IMX_SC_MISC_FUNC_UNIQUE_ID ||
-saved_func == IMX_SC_MISC_FUNC_GET_BUTTON_STATUS))
+   if ((saved_svc == IMX_SC_RPC_SVC_MISC &&
+(saved_func == IMX_SC_MISC_FUNC_UNIQUE_ID ||
+ saved_func == IMX_SC_MISC_FUNC_GET_BUTTON_STATUS)) ||
+   (saved_svc == IMX_SC_RPC_SVC_SECO &&
+(saved_func == IMX_SC_SECO_FUNC_BUILD_INFO)))
ret = 0;
}
 
diff --git a/drivers/firmware/imx/seco.c b/drivers/firmware/imx/seco.c
new file mode 100644
index 000..fd11bd4
--- /dev/null
+++ b/drivers/firmware/imx/seco.c
@@ -0,0 +1,253 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2020 NXP
+ *
+ * File containing client-side RPC functions for the SECO service. These
+ * functions are ported to clients that communicate to the SC.
+ */
+
+#include 
+
+struct imx_sc_msg_seco_get_build_id {
+   struct imx_sc_rpc_msg hdr;
+   u32 version;
+   u32 commit;
+};
+
+/**
+ * imx_sc_seco_build_info() - Get version and commit ID of the SECO
+ *
+ * @ipc: IPC handle
+ * @version: Version of the SECO
+ * @commit: Commit ID of the SECO
+ *
+ * @return Returns 0 for success and < 0 for errors
+ */
+int imx_sc_seco_build_info(struct imx_sc_ipc *ipc, uint32_t *version,
+  uint32_t *commit)
+{
+   int ret;
+   struct imx_sc_msg_seco_get_build_id msg;
+   struct imx_sc_rpc_msg *hdr = 
+
+   hdr->ver = IMX_SC_RPC_VERSION;
+   hdr->svc = IMX_SC_RPC_SVC_SECO;
+   hdr->func = IMX_SC_SECO_FUNC_BUILD_INFO;
+   hdr->size = 1;
+
+   ret = imx_scu_call_rpc(ipc, , true);
+   if (ret)
+   return ret;
+
+   if (version)
+   *version = msg.version;
+   if (commit)
+   *commit = msg.commit;
+
+   return 0;
+}
+EXPORT_SYMBOL(imx_sc_seco_build_info);
+
+/**
+ * imx_sc_seco_secvio_enable() - Enable the processing of secvio IRQ from the
+ * SNVS by the SECO
+ *
+ * @ipc: IPC handle
+ *
+ * @return Returns 0 for success and < 0 for errors
+ */
+int imx_sc_seco_secvio_enable(struct imx_sc_ipc *ipc)
+{
+   struct imx_sc_rpc_msg msg;
+   int ret;
+
+   msg.ver = IMX_SC_RPC_VERSION;
+   msg.svc = IMX_SC_RPC_SVC_SECO;
+   msg.func = IMX_SC_SECO_FUNC_SECVIO_ENABLE;
+   msg.size = 1;
+
+   ret = imx_scu_call_rpc(ipc, , true);
+   if (ret)
+   return ret;
+
+   return 0;
+}
+EXPORT_SYMBOL(imx_sc_seco_secvio_enable);
+
+struct imx_sc_msg_seco_config {
+   struct imx_sc_rpc_msg hdr;
+   union {
+   struct req_seco_config {
+   u32 data0;
+   u32 data1;
+   u32 data2;
+   u32 data3;
+   u32 data4;
+   u8 id;
+   u8 access;
+   u8 size;
+   } __packed __aligned(4) req;
+   struct resp_seco_config {
+   u32 data0;
+   u32 data1;
+   u32 data2;
+   u32 data3;
+