Re: [PATCH V3 2/2] x86: IOSF: Change IOSF_MBI Kconfig to default y

2014-02-26 Thread H. Peter Anvin
On 02/26/2014 11:40 AM, David E. Box wrote:
> From: "David E. Box" 
> 
> The IOSF Mailbox interface is an access mechanism used by multiple drivers to
> communicate with key configuration registers on new Intel SOC platforms. The
> interface is ubiquitous enough that we need to ensure the availability of the
> driver in non-EXPERT configured x86 kernels.
> 
> Signed-off-by: David E. Box 

Hi David,

Could you please update the patch description to explain to people who
may not be familiar why the IOSF driver can't be a module?

-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH V3 2/2] x86: IOSF: Change IOSF_MBI Kconfig to default y

2014-02-26 Thread David E. Box
From: "David E. Box" 

The IOSF Mailbox interface is an access mechanism used by multiple drivers to
communicate with key configuration registers on new Intel SOC platforms. The
interface is ubiquitous enough that we need to ensure the availability of the
driver in non-EXPERT configured x86 kernels.

Signed-off-by: David E. Box 
---
 arch/x86/Kconfig |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index d3b1f8b..4de5205 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -2385,11 +2385,12 @@ config X86_DMA_REMAP
depends on STA2X11
 
 config IOSF_MBI
-   bool
+   bool "IOSF MBI support" if EXPERT
+   default y
depends on PCI
---help---
  To be selected by modules requiring access to the Intel OnChip System
- Fabric (IOSF) Sideband MailBox Interface (MBI). For MBI platforms
+ Fabric (IOSF) Sideband MailBox Interface (MBI). For IOSF platforms
  enumerable by PCI.
 
 source "net/Kconfig"
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH V3 2/2] x86: IOSF: Change IOSF_MBI Kconfig to default y

2014-02-26 Thread David E. Box
From: David E. Box david.e@linux.intel.com

The IOSF Mailbox interface is an access mechanism used by multiple drivers to
communicate with key configuration registers on new Intel SOC platforms. The
interface is ubiquitous enough that we need to ensure the availability of the
driver in non-EXPERT configured x86 kernels.

Signed-off-by: David E. Box david.e@linux.intel.com
---
 arch/x86/Kconfig |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index d3b1f8b..4de5205 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -2385,11 +2385,12 @@ config X86_DMA_REMAP
depends on STA2X11
 
 config IOSF_MBI
-   bool
+   bool IOSF MBI support if EXPERT
+   default y
depends on PCI
---help---
  To be selected by modules requiring access to the Intel OnChip System
- Fabric (IOSF) Sideband MailBox Interface (MBI). For MBI platforms
+ Fabric (IOSF) Sideband MailBox Interface (MBI). For IOSF platforms
  enumerable by PCI.
 
 source net/Kconfig
-- 
1.7.10.4

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH V3 2/2] x86: IOSF: Change IOSF_MBI Kconfig to default y

2014-02-26 Thread H. Peter Anvin
On 02/26/2014 11:40 AM, David E. Box wrote:
 From: David E. Box david.e@linux.intel.com
 
 The IOSF Mailbox interface is an access mechanism used by multiple drivers to
 communicate with key configuration registers on new Intel SOC platforms. The
 interface is ubiquitous enough that we need to ensure the availability of the
 driver in non-EXPERT configured x86 kernels.
 
 Signed-off-by: David E. Box david.e@linux.intel.com

Hi David,

Could you please update the patch description to explain to people who
may not be familiar why the IOSF driver can't be a module?

-hpa


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/