RE: [PATCH V3 2/5] input: keyboard: imx_sc: Add i.MX system controller key support

2019-09-15 Thread Anson Huang 
Hi, Dmitry

> On Tue, Sep 03, 2019 at 05:36:37PM -0400, Anson Huang wrote:
> > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
> > inside, the system controller is in charge of controlling power, clock
> > and scu key etc..
> >
> > Adds i.MX system controller key driver support, Linux kernel has to
> > communicate with system controller via MU (message unit) IPC to get
> > scu key's status.
> >
> > Signed-off-by: Anson Huang 
> > ---
> > Changes since V2:
> > - use private platform data instead of global data;
> > - use "key" instead of "pwrkey";
> > - fix some data format.
> > ---
> >  drivers/input/keyboard/Kconfig  |   7 ++
> >  drivers/input/keyboard/Makefile |   1 +
> >  drivers/input/keyboard/imx_sc_key.c | 178
> > 
> >  3 files changed, 186 insertions(+)
> >  create mode 100644 drivers/input/keyboard/imx_sc_key.c
> >
> > diff --git a/drivers/input/keyboard/Kconfig
> > b/drivers/input/keyboard/Kconfig index 2e6d288..607acf2 100644
> > --- a/drivers/input/keyboard/Kconfig
> > +++ b/drivers/input/keyboard/Kconfig
> > @@ -469,6 +469,13 @@ config KEYBOARD_IMX
> >   To compile this driver as a module, choose M here: the
> >   module will be called imx_keypad.
> >
> > +config KEYBOARD_IMX_SC_KEY
> > +   tristate "IMX SCU Key Driver"
> > +   depends on IMX_SCU
> > +   help
> > + This is the system controller key driver for NXP i.MX SoCs with
> > + system controller inside.
> > +
> >  config KEYBOARD_NEWTON
> > tristate "Newton keyboard"
> > select SERIO
> > diff --git a/drivers/input/keyboard/Makefile
> > b/drivers/input/keyboard/Makefile index 9510325..f5b1752 100644
> > --- a/drivers/input/keyboard/Makefile
> > +++ b/drivers/input/keyboard/Makefile
> > @@ -29,6 +29,7 @@ obj-$(CONFIG_KEYBOARD_HIL)+= hil_kbd.o
> >  obj-$(CONFIG_KEYBOARD_HIL_OLD) += hilkbd.o
> >  obj-$(CONFIG_KEYBOARD_IPAQ_MICRO)  += ipaq-micro-keys.o
> >  obj-$(CONFIG_KEYBOARD_IMX) += imx_keypad.o
> > +obj-$(CONFIG_KEYBOARD_IMX_SC_KEY)  += imx_sc_key.o
> >  obj-$(CONFIG_KEYBOARD_HP6XX)   += jornada680_kbd.o
> >  obj-$(CONFIG_KEYBOARD_HP7XX)   += jornada720_kbd.o
> >  obj-$(CONFIG_KEYBOARD_LKKBD)   += lkkbd.o
> > diff --git a/drivers/input/keyboard/imx_sc_key.c
> > b/drivers/input/keyboard/imx_sc_key.c
> > new file mode 100644
> > index 000..e69479b
> > --- /dev/null
> > +++ b/drivers/input/keyboard/imx_sc_key.c
> > @@ -0,0 +1,178 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright 2019 NXP.
> > + */
> > +
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +
> > +#define DEBOUNCE_TIME  100
> > +#define REPEAT_INTERVAL60
> > +
> > +#define SC_IRQ_BUTTON  1
> > +#define SC_IRQ_GROUP_WAKE  3
> > +#define IMX_SC_MISC_FUNC_GET_BUTTON_STATUS 18
> > +
> > +struct imx_key_drv_data {
> > +   int keycode;
> > +   bool keystate;  /* 1: pressed, 0: release */
> > +   bool delay_check;
> > +   struct delayed_work check_work;
> > +   struct input_dev *input;
> > +   struct imx_sc_ipc *key_ipc_handle;
> > +   struct notifier_block key_notifier;
> > +};
> > +
> > +struct imx_sc_msg_key {
> > +   struct imx_sc_rpc_msg hdr;
> > +   u8 state;
> > +};
> > +
> > +static int imx_sc_key_notify(struct notifier_block *nb,
> > +unsigned long event, void *group) {
> > +   struct imx_key_drv_data *priv =
> > +container_of(nb,
> > + struct imx_key_drv_data,
> > + key_notifier);
> > +
> > +   if ((event & SC_IRQ_BUTTON) && (*(u8 *)group ==
> SC_IRQ_GROUP_WAKE)
> > +   && !priv->delay_check) {
> > +   priv->delay_check = 1;
> > +   schedule_delayed_work(&priv->check_work,
> > + msecs_to_jiffies(REPEAT_INTERVAL));
> > +   }
> > +
> > +   return 0;
> > +}
> > +
> > +static void imx_sc_check_for_events(struct work_struct *work) {
> > +   struct imx_key_drv_data *priv =
> > +container_of(work,
> > + struct imx_key_drv_data,
> > + check_work.work);
> > +   struct input_dev *input = priv->input;
> > +   struct imx_sc_msg_key msg;
> > +   struct imx_sc_rpc_msg *hdr = &msg.hdr;
> > +   bool state;
> > +   int ret;
> > +
> > +   hdr->ver = IMX_SC_RPC_VERSION;
> > +   hdr->svc = IMX_SC_RPC_SVC_MISC;
> > +   hdr->func = IMX_SC_MISC_FUNC_GET_BUTTON_STATUS;
> > +   hdr->size = 1;
> > +
> > +   ret = imx_scu_call_rpc(priv->key_ipc_handle, &msg, true);
> > +   if (ret) {
> > +   dev_err(&input->dev, "read imx sc key failed, ret %d\n", ret);
> > +   return;
> > +   }
> > +
> > +   state = (bool)msg.state;
> > +
> > +   if (!state && !priv->keystate

Re: [PATCH V3 2/5] input: keyboard: imx_sc: Add i.MX system controller key support

2019-09-12 Thread Dmitry Torokhov 
Hi Anson,

On Tue, Sep 03, 2019 at 05:36:37PM -0400, Anson Huang wrote:
> i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
> inside, the system controller is in charge of controlling power,
> clock and scu key etc..
> 
> Adds i.MX system controller key driver support, Linux kernel has
> to communicate with system controller via MU (message unit) IPC
> to get scu key's status.
> 
> Signed-off-by: Anson Huang 
> ---
> Changes since V2:
>   - use private platform data instead of global data;
>   - use "key" instead of "pwrkey";
>   - fix some data format.
> ---
>  drivers/input/keyboard/Kconfig  |   7 ++
>  drivers/input/keyboard/Makefile |   1 +
>  drivers/input/keyboard/imx_sc_key.c | 178 
> 
>  3 files changed, 186 insertions(+)
>  create mode 100644 drivers/input/keyboard/imx_sc_key.c
> 
> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
> index 2e6d288..607acf2 100644
> --- a/drivers/input/keyboard/Kconfig
> +++ b/drivers/input/keyboard/Kconfig
> @@ -469,6 +469,13 @@ config KEYBOARD_IMX
> To compile this driver as a module, choose M here: the
> module will be called imx_keypad.
>  
> +config KEYBOARD_IMX_SC_KEY
> + tristate "IMX SCU Key Driver"
> + depends on IMX_SCU
> + help
> +   This is the system controller key driver for NXP i.MX SoCs with
> +   system controller inside.
> +
>  config KEYBOARD_NEWTON
>   tristate "Newton keyboard"
>   select SERIO
> diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makefile
> index 9510325..f5b1752 100644
> --- a/drivers/input/keyboard/Makefile
> +++ b/drivers/input/keyboard/Makefile
> @@ -29,6 +29,7 @@ obj-$(CONFIG_KEYBOARD_HIL)  += hil_kbd.o
>  obj-$(CONFIG_KEYBOARD_HIL_OLD)   += hilkbd.o
>  obj-$(CONFIG_KEYBOARD_IPAQ_MICRO)+= ipaq-micro-keys.o
>  obj-$(CONFIG_KEYBOARD_IMX)   += imx_keypad.o
> +obj-$(CONFIG_KEYBOARD_IMX_SC_KEY)+= imx_sc_key.o
>  obj-$(CONFIG_KEYBOARD_HP6XX) += jornada680_kbd.o
>  obj-$(CONFIG_KEYBOARD_HP7XX) += jornada720_kbd.o
>  obj-$(CONFIG_KEYBOARD_LKKBD) += lkkbd.o
> diff --git a/drivers/input/keyboard/imx_sc_key.c 
> b/drivers/input/keyboard/imx_sc_key.c
> new file mode 100644
> index 000..e69479b
> --- /dev/null
> +++ b/drivers/input/keyboard/imx_sc_key.c
> @@ -0,0 +1,178 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright 2019 NXP.
> + */
> +
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +
> +#define DEBOUNCE_TIME100
> +#define REPEAT_INTERVAL  60
> +
> +#define SC_IRQ_BUTTON1
> +#define SC_IRQ_GROUP_WAKE3
> +#define IMX_SC_MISC_FUNC_GET_BUTTON_STATUS   18
> +
> +struct imx_key_drv_data {
> + int keycode;
> + bool keystate;  /* 1: pressed, 0: release */
> + bool delay_check;
> + struct delayed_work check_work;
> + struct input_dev *input;
> + struct imx_sc_ipc *key_ipc_handle;
> + struct notifier_block key_notifier;
> +};
> +
> +struct imx_sc_msg_key {
> + struct imx_sc_rpc_msg hdr;
> + u8 state;
> +};
> +
> +static int imx_sc_key_notify(struct notifier_block *nb,
> +  unsigned long event, void *group)
> +{
> + struct imx_key_drv_data *priv =
> +  container_of(nb,
> +   struct imx_key_drv_data,
> +   key_notifier);
> +
> + if ((event & SC_IRQ_BUTTON) && (*(u8 *)group == SC_IRQ_GROUP_WAKE)
> + && !priv->delay_check) {
> + priv->delay_check = 1;
> + schedule_delayed_work(&priv->check_work,
> +   msecs_to_jiffies(REPEAT_INTERVAL));
> + }
> +
> + return 0;
> +}
> +
> +static void imx_sc_check_for_events(struct work_struct *work)
> +{
> + struct imx_key_drv_data *priv =
> +  container_of(work,
> +   struct imx_key_drv_data,
> +   check_work.work);
> + struct input_dev *input = priv->input;
> + struct imx_sc_msg_key msg;
> + struct imx_sc_rpc_msg *hdr = &msg.hdr;
> + bool state;
> + int ret;
> +
> + hdr->ver = IMX_SC_RPC_VERSION;
> + hdr->svc = IMX_SC_RPC_SVC_MISC;
> + hdr->func = IMX_SC_MISC_FUNC_GET_BUTTON_STATUS;
> + hdr->size = 1;
> +
> + ret = imx_scu_call_rpc(priv->key_ipc_handle, &msg, true);
> + if (ret) {
> + dev_err(&input->dev, "read imx sc key failed, ret %d\n", ret);
> + return;
> + }
> +
> + state = (bool)msg.state;
> +
> + if (!state && !priv->keystate)
> + state = true;
> +
> + if (state ^ priv->keystate) {
> + pm_wakeup_event(input->dev.parent, 0);
> + priv->keystate = state;
> +

Re: [PATCH V3 2/5] input: keyboard: imx_sc: Add i.MX system controller key support

2019-09-03 Thread Oleksij Rempel 




On 03.09.19 23:36, Anson Huang wrote:

i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
inside, the system controller is in charge of controlling power,
clock and scu key etc..

Adds i.MX system controller key driver support, Linux kernel has
to communicate with system controller via MU (message unit) IPC
to get scu key's status.

Signed-off-by: Anson Huang 


Reviewed-by: Oleksij Rempel 


---
Changes since V2:
- use private platform data instead of global data;
- use "key" instead of "pwrkey";
- fix some data format.
---
  drivers/input/keyboard/Kconfig  |   7 ++
  drivers/input/keyboard/Makefile |   1 +
  drivers/input/keyboard/imx_sc_key.c | 178 
  3 files changed, 186 insertions(+)
  create mode 100644 drivers/input/keyboard/imx_sc_key.c

diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
index 2e6d288..607acf2 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -469,6 +469,13 @@ config KEYBOARD_IMX
  To compile this driver as a module, choose M here: the
  module will be called imx_keypad.
  
+config KEYBOARD_IMX_SC_KEY

+   tristate "IMX SCU Key Driver"
+   depends on IMX_SCU
+   help
+ This is the system controller key driver for NXP i.MX SoCs with
+ system controller inside.
+
  config KEYBOARD_NEWTON
tristate "Newton keyboard"
select SERIO
diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makefile
index 9510325..f5b1752 100644
--- a/drivers/input/keyboard/Makefile
+++ b/drivers/input/keyboard/Makefile
@@ -29,6 +29,7 @@ obj-$(CONFIG_KEYBOARD_HIL)+= hil_kbd.o
  obj-$(CONFIG_KEYBOARD_HIL_OLD)+= hilkbd.o
  obj-$(CONFIG_KEYBOARD_IPAQ_MICRO) += ipaq-micro-keys.o
  obj-$(CONFIG_KEYBOARD_IMX)+= imx_keypad.o
+obj-$(CONFIG_KEYBOARD_IMX_SC_KEY)  += imx_sc_key.o
  obj-$(CONFIG_KEYBOARD_HP6XX)  += jornada680_kbd.o
  obj-$(CONFIG_KEYBOARD_HP7XX)  += jornada720_kbd.o
  obj-$(CONFIG_KEYBOARD_LKKBD)  += lkkbd.o
diff --git a/drivers/input/keyboard/imx_sc_key.c 
b/drivers/input/keyboard/imx_sc_key.c
new file mode 100644
index 000..e69479b
--- /dev/null
+++ b/drivers/input/keyboard/imx_sc_key.c
@@ -0,0 +1,178 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2019 NXP.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#define DEBOUNCE_TIME  100
+#define REPEAT_INTERVAL60
+
+#define SC_IRQ_BUTTON  1
+#define SC_IRQ_GROUP_WAKE  3
+#define IMX_SC_MISC_FUNC_GET_BUTTON_STATUS 18
+
+struct imx_key_drv_data {
+   int keycode;
+   bool keystate;  /* 1: pressed, 0: release */
+   bool delay_check;
+   struct delayed_work check_work;
+   struct input_dev *input;
+   struct imx_sc_ipc *key_ipc_handle;
+   struct notifier_block key_notifier;
+};
+
+struct imx_sc_msg_key {
+   struct imx_sc_rpc_msg hdr;
+   u8 state;
+};
+
+static int imx_sc_key_notify(struct notifier_block *nb,
+unsigned long event, void *group)
+{
+   struct imx_key_drv_data *priv =
+container_of(nb,
+ struct imx_key_drv_data,
+ key_notifier);
+
+   if ((event & SC_IRQ_BUTTON) && (*(u8 *)group == SC_IRQ_GROUP_WAKE)
+   && !priv->delay_check) {
+   priv->delay_check = 1;
+   schedule_delayed_work(&priv->check_work,
+ msecs_to_jiffies(REPEAT_INTERVAL));
+   }
+
+   return 0;
+}
+
+static void imx_sc_check_for_events(struct work_struct *work)
+{
+   struct imx_key_drv_data *priv =
+container_of(work,
+ struct imx_key_drv_data,
+ check_work.work);
+   struct input_dev *input = priv->input;
+   struct imx_sc_msg_key msg;
+   struct imx_sc_rpc_msg *hdr = &msg.hdr;
+   bool state;
+   int ret;
+
+   hdr->ver = IMX_SC_RPC_VERSION;
+   hdr->svc = IMX_SC_RPC_SVC_MISC;
+   hdr->func = IMX_SC_MISC_FUNC_GET_BUTTON_STATUS;
+   hdr->size = 1;
+
+   ret = imx_scu_call_rpc(priv->key_ipc_handle, &msg, true);
+   if (ret) {
+   dev_err(&input->dev, "read imx sc key failed, ret %d\n", ret);
+   return;
+   }
+
+   state = (bool)msg.state;
+
+   if (!state && !priv->keystate)
+   state = true;
+
+   if (state ^ priv->keystate) {
+   pm_wakeup_event(input->dev.parent, 0);
+   priv->keystate = state;
+   input_event(input, EV_KEY, priv->keycode, state);
+   input_sync(input);
+   if (!state)
+   priv->delay_c

[PATCH V3 2/5] input: keyboard: imx_sc: Add i.MX system controller key support

2019-09-03 Thread Anson Huang 
i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
inside, the system controller is in charge of controlling power,
clock and scu key etc..

Adds i.MX system controller key driver support, Linux kernel has
to communicate with system controller via MU (message unit) IPC
to get scu key's status.

Signed-off-by: Anson Huang 
---
Changes since V2:
- use private platform data instead of global data;
- use "key" instead of "pwrkey";
- fix some data format.
---
 drivers/input/keyboard/Kconfig  |   7 ++
 drivers/input/keyboard/Makefile |   1 +
 drivers/input/keyboard/imx_sc_key.c | 178 
 3 files changed, 186 insertions(+)
 create mode 100644 drivers/input/keyboard/imx_sc_key.c

diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
index 2e6d288..607acf2 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -469,6 +469,13 @@ config KEYBOARD_IMX
  To compile this driver as a module, choose M here: the
  module will be called imx_keypad.
 
+config KEYBOARD_IMX_SC_KEY
+   tristate "IMX SCU Key Driver"
+   depends on IMX_SCU
+   help
+ This is the system controller key driver for NXP i.MX SoCs with
+ system controller inside.
+
 config KEYBOARD_NEWTON
tristate "Newton keyboard"
select SERIO
diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makefile
index 9510325..f5b1752 100644
--- a/drivers/input/keyboard/Makefile
+++ b/drivers/input/keyboard/Makefile
@@ -29,6 +29,7 @@ obj-$(CONFIG_KEYBOARD_HIL)+= hil_kbd.o
 obj-$(CONFIG_KEYBOARD_HIL_OLD) += hilkbd.o
 obj-$(CONFIG_KEYBOARD_IPAQ_MICRO)  += ipaq-micro-keys.o
 obj-$(CONFIG_KEYBOARD_IMX) += imx_keypad.o
+obj-$(CONFIG_KEYBOARD_IMX_SC_KEY)  += imx_sc_key.o
 obj-$(CONFIG_KEYBOARD_HP6XX)   += jornada680_kbd.o
 obj-$(CONFIG_KEYBOARD_HP7XX)   += jornada720_kbd.o
 obj-$(CONFIG_KEYBOARD_LKKBD)   += lkkbd.o
diff --git a/drivers/input/keyboard/imx_sc_key.c 
b/drivers/input/keyboard/imx_sc_key.c
new file mode 100644
index 000..e69479b
--- /dev/null
+++ b/drivers/input/keyboard/imx_sc_key.c
@@ -0,0 +1,178 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2019 NXP.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#define DEBOUNCE_TIME  100
+#define REPEAT_INTERVAL60
+
+#define SC_IRQ_BUTTON  1
+#define SC_IRQ_GROUP_WAKE  3
+#define IMX_SC_MISC_FUNC_GET_BUTTON_STATUS 18
+
+struct imx_key_drv_data {
+   int keycode;
+   bool keystate;  /* 1: pressed, 0: release */
+   bool delay_check;
+   struct delayed_work check_work;
+   struct input_dev *input;
+   struct imx_sc_ipc *key_ipc_handle;
+   struct notifier_block key_notifier;
+};
+
+struct imx_sc_msg_key {
+   struct imx_sc_rpc_msg hdr;
+   u8 state;
+};
+
+static int imx_sc_key_notify(struct notifier_block *nb,
+unsigned long event, void *group)
+{
+   struct imx_key_drv_data *priv =
+container_of(nb,
+ struct imx_key_drv_data,
+ key_notifier);
+
+   if ((event & SC_IRQ_BUTTON) && (*(u8 *)group == SC_IRQ_GROUP_WAKE)
+   && !priv->delay_check) {
+   priv->delay_check = 1;
+   schedule_delayed_work(&priv->check_work,
+ msecs_to_jiffies(REPEAT_INTERVAL));
+   }
+
+   return 0;
+}
+
+static void imx_sc_check_for_events(struct work_struct *work)
+{
+   struct imx_key_drv_data *priv =
+container_of(work,
+ struct imx_key_drv_data,
+ check_work.work);
+   struct input_dev *input = priv->input;
+   struct imx_sc_msg_key msg;
+   struct imx_sc_rpc_msg *hdr = &msg.hdr;
+   bool state;
+   int ret;
+
+   hdr->ver = IMX_SC_RPC_VERSION;
+   hdr->svc = IMX_SC_RPC_SVC_MISC;
+   hdr->func = IMX_SC_MISC_FUNC_GET_BUTTON_STATUS;
+   hdr->size = 1;
+
+   ret = imx_scu_call_rpc(priv->key_ipc_handle, &msg, true);
+   if (ret) {
+   dev_err(&input->dev, "read imx sc key failed, ret %d\n", ret);
+   return;
+   }
+
+   state = (bool)msg.state;
+
+   if (!state && !priv->keystate)
+   state = true;
+
+   if (state ^ priv->keystate) {
+   pm_wakeup_event(input->dev.parent, 0);
+   priv->keystate = state;
+   input_event(input, EV_KEY, priv->keycode, state);
+   input_sync(input);
+   if (!state)
+   priv->delay_check = 0;
+   pm_relax(priv->input->dev.parent);
+   }
+
+   if (state)