Re: [PATCH V4 2/3] arm64: dts: tegra: Add SDMMC Auto-cal settings

2019-01-21 Thread Ulf Hansson
On Thu, 10 Jan 2019 at 23:46, Sowjanya Komatineni
 wrote:
>
> Add SDMMC initial pad offsets used by auto calibration process.
>
> Add SDMMC fixed drive strengths for Tegra210, Tegra186 and
> Tegra194 which are used when calibration timeouts.
>
> Fixed drive strengths are based on Pre SI Analysis of the pads.
>
> Signed-off-by: Sowjanya Komatineni 

For clarity, I am leaving this one for arm-soc.

Kind regards
Uffe


> ---
>  arch/arm64/boot/dts/nvidia/tegra186.dtsi |  2 ++
>  arch/arm64/boot/dts/nvidia/tegra194.dtsi | 34 +++
>  arch/arm64/boot/dts/nvidia/tegra210.dtsi | 57 
> ++--
>  3 files changed, 91 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi 
> b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
> index 22815db4a3ed..169aee59ceac 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
> @@ -315,6 +315,8 @@
> nvidia,pad-autocal-pull-down-offset-hs400 = <0x05>;
> nvidia,pad-autocal-pull-up-offset-1v8-timeout = <0x0a>;
> nvidia,pad-autocal-pull-down-offset-1v8-timeout = <0x0a>;
> +   nvidia,pad-autocal-pull-up-offset-3v3-timeout = <0x0a>;
> +   nvidia,pad-autocal-pull-down-offset-3v3-timeout = <0x0a>;
> nvidia,default-tap = <0x5>;
> nvidia,default-trim = <0x9>;
> nvidia,dqs-trim = <63>;
> diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi 
> b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
> index 6dfa1ca0b851..596a36705c0f 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra194.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
> @@ -303,6 +303,17 @@
> clock-names = "sdhci";
> resets = < TEGRA194_RESET_SDMMC1>;
> reset-names = "sdhci";
> +   nvidia,pad-autocal-pull-up-offset-3v3-timeout =
> +   
> <0x07>;
> +   nvidia,pad-autocal-pull-down-offset-3v3-timeout =
> +   
> <0x07>;
> +   nvidia,pad-autocal-pull-up-offset-1v8-timeout = 
> <0x06>;
> +   nvidia,pad-autocal-pull-down-offset-1v8-timeout =
> +   
> <0x07>;
> +   nvidia,pad-autocal-pull-up-offset-sdr104 = <0x00>;
> +   nvidia,pad-autocal-pull-down-offset-sdr104 = <0x00>;
> +   nvidia,default-tap = <0x9>;
> +   nvidia,default-trim = <0x5>;
> status = "disabled";
> };
>
> @@ -314,6 +325,18 @@
> clock-names = "sdhci";
> resets = < TEGRA194_RESET_SDMMC3>;
> reset-names = "sdhci";
> +   nvidia,pad-autocal-pull-up-offset-1v8 = <0x00>;
> +   nvidia,pad-autocal-pull-down-offset-1v8 = <0x7a>;
> +   nvidia,pad-autocal-pull-up-offset-3v3-timeout = 
> <0x07>;
> +   nvidia,pad-autocal-pull-down-offset-3v3-timeout =
> +   
> <0x07>;
> +   nvidia,pad-autocal-pull-up-offset-1v8-timeout = 
> <0x06>;
> +   nvidia,pad-autocal-pull-down-offset-1v8-timeout =
> +   
> <0x07>;
> +   nvidia,pad-autocal-pull-up-offset-sdr104 = <0x00>;
> +   nvidia,pad-autocal-pull-down-offset-sdr104 = <0x00>;
> +   nvidia,default-tap = <0x9>;
> +   nvidia,default-trim = <0x5>;
> status = "disabled";
> };
>
> @@ -325,6 +348,17 @@
> clock-names = "sdhci";
> resets = < TEGRA194_RESET_SDMMC4>;
> reset-names = "sdhci";
> +   nvidia,pad-autocal-pull-up-offset-hs400 = <0x00>;
> +   nvidia,pad-autocal-pull-down-offset-hs400 = <0x00>;
> +   nvidia,pad-autocal-pull-up-offset-1v8-timeout = 
> <0x0a>;
> +   nvidia,pad-autocal-pull-down-offset-1v8-timeout =
> +   
> <0x0a>;
> +   nvidia,pad-autocal-pull-up-offset-3v3-timeout = 
> <0x0a>;
> +   nvidia,pad-autocal-pull-down-offset-3v3-timeout =
> +   
> <0x0a>;
> +   nvidia,default-tap = <0x8>;
> +   nvidia,default-trim = <0x14>;
> +   nvidia,dqs-trim = <40>;
> status = "disabled";
> };
>

[PATCH V4 2/3] arm64: dts: tegra: Add SDMMC Auto-cal settings

2019-01-10 Thread Sowjanya Komatineni
Add SDMMC initial pad offsets used by auto calibration process.

Add SDMMC fixed drive strengths for Tegra210, Tegra186 and
Tegra194 which are used when calibration timeouts.

Fixed drive strengths are based on Pre SI Analysis of the pads.

Signed-off-by: Sowjanya Komatineni 
---
 arch/arm64/boot/dts/nvidia/tegra186.dtsi |  2 ++
 arch/arm64/boot/dts/nvidia/tegra194.dtsi | 34 +++
 arch/arm64/boot/dts/nvidia/tegra210.dtsi | 57 ++--
 3 files changed, 91 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi 
b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
index 22815db4a3ed..169aee59ceac 100644
--- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
@@ -315,6 +315,8 @@
nvidia,pad-autocal-pull-down-offset-hs400 = <0x05>;
nvidia,pad-autocal-pull-up-offset-1v8-timeout = <0x0a>;
nvidia,pad-autocal-pull-down-offset-1v8-timeout = <0x0a>;
+   nvidia,pad-autocal-pull-up-offset-3v3-timeout = <0x0a>;
+   nvidia,pad-autocal-pull-down-offset-3v3-timeout = <0x0a>;
nvidia,default-tap = <0x5>;
nvidia,default-trim = <0x9>;
nvidia,dqs-trim = <63>;
diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi 
b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
index 6dfa1ca0b851..596a36705c0f 100644
--- a/arch/arm64/boot/dts/nvidia/tegra194.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
@@ -303,6 +303,17 @@
clock-names = "sdhci";
resets = < TEGRA194_RESET_SDMMC1>;
reset-names = "sdhci";
+   nvidia,pad-autocal-pull-up-offset-3v3-timeout =
+   <0x07>;
+   nvidia,pad-autocal-pull-down-offset-3v3-timeout =
+   <0x07>;
+   nvidia,pad-autocal-pull-up-offset-1v8-timeout = <0x06>;
+   nvidia,pad-autocal-pull-down-offset-1v8-timeout =
+   <0x07>;
+   nvidia,pad-autocal-pull-up-offset-sdr104 = <0x00>;
+   nvidia,pad-autocal-pull-down-offset-sdr104 = <0x00>;
+   nvidia,default-tap = <0x9>;
+   nvidia,default-trim = <0x5>;
status = "disabled";
};
 
@@ -314,6 +325,18 @@
clock-names = "sdhci";
resets = < TEGRA194_RESET_SDMMC3>;
reset-names = "sdhci";
+   nvidia,pad-autocal-pull-up-offset-1v8 = <0x00>;
+   nvidia,pad-autocal-pull-down-offset-1v8 = <0x7a>;
+   nvidia,pad-autocal-pull-up-offset-3v3-timeout = <0x07>;
+   nvidia,pad-autocal-pull-down-offset-3v3-timeout =
+   <0x07>;
+   nvidia,pad-autocal-pull-up-offset-1v8-timeout = <0x06>;
+   nvidia,pad-autocal-pull-down-offset-1v8-timeout =
+   <0x07>;
+   nvidia,pad-autocal-pull-up-offset-sdr104 = <0x00>;
+   nvidia,pad-autocal-pull-down-offset-sdr104 = <0x00>;
+   nvidia,default-tap = <0x9>;
+   nvidia,default-trim = <0x5>;
status = "disabled";
};
 
@@ -325,6 +348,17 @@
clock-names = "sdhci";
resets = < TEGRA194_RESET_SDMMC4>;
reset-names = "sdhci";
+   nvidia,pad-autocal-pull-up-offset-hs400 = <0x00>;
+   nvidia,pad-autocal-pull-down-offset-hs400 = <0x00>;
+   nvidia,pad-autocal-pull-up-offset-1v8-timeout = <0x0a>;
+   nvidia,pad-autocal-pull-down-offset-1v8-timeout =
+   <0x0a>;
+   nvidia,pad-autocal-pull-up-offset-3v3-timeout = <0x0a>;
+   nvidia,pad-autocal-pull-down-offset-3v3-timeout =
+   <0x0a>;
+   nvidia,default-tap = <0x8>;
+   nvidia,default-trim = <0x14>;
+   nvidia,dqs-trim = <40>;
status = "disabled";
};
 
diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi 
b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
index 2205d66b0443..41408df9d4e9 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
@@ -476,6 +476,48 @@
compatible = "nvidia,tegra210-pinmux";
reg = <0x0