Re: [PATCH V4 3/3] pinctrl: imx: Support building i.MX pinctrl core driver as module

2020-09-29 Thread Linus Walleij
On Tue, Sep 8, 2020 at 10:18 AM Anson Huang  wrote:

> Change PINCTRL_IMX to tristate to support loadable module build.
>
> And i.MX common pinctrl driver should depend on CONFIG_OF to make sure
> no build error when i.MX common pinctrl driver is enabled for different
> architectures without CONFIG_OF.
>
> Also add module author, description and license.
>
> Signed-off-by: Anson Huang 
> Reviewed-by: Dong Aisheng 

All three patches applied, thanks a lot for working this out!

Yours,
Linus Walleij


[PATCH V4 3/3] pinctrl: imx: Support building i.MX pinctrl core driver as module

2020-09-08 Thread Anson Huang
Change PINCTRL_IMX to tristate to support loadable module build.

And i.MX common pinctrl driver should depend on CONFIG_OF to make sure
no build error when i.MX common pinctrl driver is enabled for different
architectures without CONFIG_OF.

Also add module author, description and license.

Signed-off-by: Anson Huang 
Reviewed-by: Dong Aisheng 
---
changes since V3:
- remove the prompt for PINCTRL_IMX.
---
 drivers/pinctrl/freescale/Kconfig   | 3 ++-
 drivers/pinctrl/freescale/pinctrl-imx.c | 5 +
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/freescale/Kconfig 
b/drivers/pinctrl/freescale/Kconfig
index 7198916..a1fbb3b 100644
--- a/drivers/pinctrl/freescale/Kconfig
+++ b/drivers/pinctrl/freescale/Kconfig
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config PINCTRL_IMX
-   bool
+   tristate
+   depends on OF
select GENERIC_PINCTRL_GROUPS
select GENERIC_PINMUX_FUNCTIONS
select GENERIC_PINCONF
diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c 
b/drivers/pinctrl/freescale/pinctrl-imx.c
index b80c450..daf28bc 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx.c
@@ -11,6 +11,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -898,3 +899,7 @@ const struct dev_pm_ops imx_pinctrl_pm_ops = {
imx_pinctrl_resume)
 };
 EXPORT_SYMBOL_GPL(imx_pinctrl_pm_ops);
+
+MODULE_AUTHOR("Dong Aisheng ");
+MODULE_DESCRIPTION("NXP i.MX common pinctrl driver");
+MODULE_LICENSE("GPL v2");
-- 
2.7.4