RE: [PATCH V5 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding
Hi, Thierry Best Regards! Anson Huang > -Original Message- > From: Thierry Reding [mailto:thierry.red...@gmail.com] > Sent: 2019年3月18日 17:59 > To: Anson Huang > Cc: robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; > s.ha...@pengutronix.de; ker...@pengutronix.de; feste...@gmail.com; > li...@armlinux.org.uk; ota...@ossystems.com.br; ste...@agner.ch; > Leonard Crestez ; Robin Gong > ; jan.tu...@emtrion.com; linux- > p...@vger.kernel.org; devicet...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; linux-kernel@vger.kernel.org; u.kleine- > koe...@pengutronix.de; dl-linux-imx > Subject: Re: [PATCH V5 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding > > On Mon, Mar 18, 2019 at 07:41:32AM +, Anson Huang wrote: > > Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM > binding. > > > > Signed-off-by: Anson Huang > > --- > > No changes. > > --- > > Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt | 19 > > +++ > > 1 file changed, 19 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > > > > diff --git a/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > > b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > > new file mode 100644 > > index 000..d47b8fb > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > > @@ -0,0 +1,19 @@ > > +Freescale i.MX TPM PWM controller > > + > > +Required properties: > > +- compatible : Should be "fsl,imx-tpm-pwm". > > Should this perhaps only be "fsl,imx-tpm"? Sounds to me like this is a > hardware block called "TPM" that can be used as a PWM. The compatible > string should describe the hardware block, not the mode in which it is used. OK, will fix it. > > > +- reg: Physical base address and length of the controller's registers. > > +- #pwm-cells: Should be 2. See pwm.txt in this directory for a description > of the cells format. > > +- clocks : The clock provided by the SoC to drive the PWM. > > +- interrupts: The interrupt for the pwm controller. > > pwm -> PWM OK. Thanks, Anson > > Thierry
Re: [PATCH V5 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding
On Mon, Mar 18, 2019 at 07:41:32AM +, Anson Huang wrote: > Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM binding. > > Signed-off-by: Anson Huang > --- > No changes. > --- > Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt | 19 > +++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > > diff --git a/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > new file mode 100644 > index 000..d47b8fb > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt > @@ -0,0 +1,19 @@ > +Freescale i.MX TPM PWM controller > + > +Required properties: > +- compatible : Should be "fsl,imx-tpm-pwm". Should this perhaps only be "fsl,imx-tpm"? Sounds to me like this is a hardware block called "TPM" that can be used as a PWM. The compatible string should describe the hardware block, not the mode in which it is used. > +- reg: Physical base address and length of the controller's registers. > +- #pwm-cells: Should be 2. See pwm.txt in this directory for a description > of the cells format. > +- clocks : The clock provided by the SoC to drive the PWM. > +- interrupts: The interrupt for the pwm controller. pwm -> PWM Thierry signature.asc Description: PGP signature
RE: [PATCH V5 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding
Hi, Stefan
Best Regards!
Anson Huang
> -Original Message-
> From: Stefan Agner [mailto:ste...@agner.ch]
> Sent: 2019年3月18日 16:19
> To: Anson Huang
> Cc: thierry.red...@gmail.com; robh...@kernel.org; mark.rutl...@arm.com;
> shawn...@kernel.org; s.ha...@pengutronix.de; ker...@pengutronix.de;
> feste...@gmail.com; li...@armlinux.org.uk; ota...@ossystems.com.br;
> Leonard Crestez ; Robin Gong
> ; jan.tu...@emtrion.com; linux-
> p...@vger.kernel.org; devicet...@vger.kernel.org; linux-arm-
> ker...@lists.infradead.org; linux-kernel@vger.kernel.org; u.kleine-
> koe...@pengutronix.de; dl-linux-imx
> Subject: Re: [PATCH V5 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding
>
> On 18.03.2019 08:41, Anson Huang wrote:
> > Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM
> binding.
> >
> > Signed-off-by: Anson Huang
> > ---
> > No changes.
> > ---
> > Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt | 19
> > +++
> > 1 file changed, 19 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> > b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> > new file mode 100644
> > index 000..d47b8fb
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> > @@ -0,0 +1,19 @@
> > +Freescale i.MX TPM PWM controller
> > +
> > +Required properties:
> > +- compatible : Should be "fsl,imx-tpm-pwm".
> > +- reg: Physical base address and length of the controller's registers.
> > +- #pwm-cells: Should be 2. See pwm.txt in this directory for a
> > description of the cells format.
>
> It seems that the driver supports polarity. Can we use 3 cells so we can
> specify the polarity in the device tree?
>
> Also use 3 cells in the base device tree to enable other boards making use of
> the polarity (arch/arm/boot/dts/imx7ulp.dtsi).
It makes sense, I will change it to 3 cells and specify the polarity in
backlight node.
Anson.
>
> --
> Stefan
>
> > +- clocks : The clock provided by the SoC to drive the PWM.
> > +- interrupts: The interrupt for the pwm controller.
> > +
> > +Example:
> > +
> > +pwm0: tpm@4025 {
> > + compatible = "fsl,imx-tpm-pwm";
> > + reg = <0x4025 0x1000>;
> > + assigned-clocks = <&clks IMX7ULP_CLK_LPTPM4>;
> > + assigned-clock-parents = <&clks IMX7ULP_CLK_SOSC_BUS_CLK>;
> > + clocks = <&clks IMX7ULP_CLK_LPTPM4>;
> > + #pwm-cells = <2>;
> > +};
Re: [PATCH V5 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding
On 18.03.2019 08:41, Anson Huang wrote:
> Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM binding.
>
> Signed-off-by: Anson Huang
> ---
> No changes.
> ---
> Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt | 19
> +++
> 1 file changed, 19 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
>
> diff --git a/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> new file mode 100644
> index 000..d47b8fb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> @@ -0,0 +1,19 @@
> +Freescale i.MX TPM PWM controller
> +
> +Required properties:
> +- compatible : Should be "fsl,imx-tpm-pwm".
> +- reg: Physical base address and length of the controller's registers.
> +- #pwm-cells: Should be 2. See pwm.txt in this directory for a
> description of the cells format.
It seems that the driver supports polarity. Can we use 3 cells so we can
specify the polarity in the device tree?
Also use 3 cells in the base device tree to enable other boards making
use of the polarity (arch/arm/boot/dts/imx7ulp.dtsi).
--
Stefan
> +- clocks : The clock provided by the SoC to drive the PWM.
> +- interrupts: The interrupt for the pwm controller.
> +
> +Example:
> +
> +pwm0: tpm@4025 {
> + compatible = "fsl,imx-tpm-pwm";
> + reg = <0x4025 0x1000>;
> + assigned-clocks = <&clks IMX7ULP_CLK_LPTPM4>;
> + assigned-clock-parents = <&clks IMX7ULP_CLK_SOSC_BUS_CLK>;
> + clocks = <&clks IMX7ULP_CLK_LPTPM4>;
> + #pwm-cells = <2>;
> +};
[PATCH V5 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding
Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM binding.
Signed-off-by: Anson Huang
---
No changes.
---
Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt | 19 +++
1 file changed, 19 insertions(+)
create mode 100644 Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
diff --git a/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
new file mode 100644
index 000..d47b8fb
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
@@ -0,0 +1,19 @@
+Freescale i.MX TPM PWM controller
+
+Required properties:
+- compatible : Should be "fsl,imx-tpm-pwm".
+- reg: Physical base address and length of the controller's registers.
+- #pwm-cells: Should be 2. See pwm.txt in this directory for a description of
the cells format.
+- clocks : The clock provided by the SoC to drive the PWM.
+- interrupts: The interrupt for the pwm controller.
+
+Example:
+
+pwm0: tpm@4025 {
+ compatible = "fsl,imx-tpm-pwm";
+ reg = <0x4025 0x1000>;
+ assigned-clocks = <&clks IMX7ULP_CLK_LPTPM4>;
+ assigned-clock-parents = <&clks IMX7ULP_CLK_SOSC_BUS_CLK>;
+ clocks = <&clks IMX7ULP_CLK_LPTPM4>;
+ #pwm-cells = <2>;
+};
--
2.7.4
