Re: [PATCH V6 1/4] clk: bulk: add of_clk_bulk_get()
Quoting Dong Aisheng (2018-08-30 21:45:53) > 'clock-names' property is optional in DT, so of_clk_bulk_get() is > introduced here to handle this for DT users without 'clock-names' > specified. Later clk_bulk_get_all() will be implemented on top of > it and this API will be kept private until someone proves they need > it because they don't have a struct device pointer. > > Cc: Stephen Boyd > Cc: Michael Turquette > Cc: Russell King > Reported-by: Shawn Guo > Tested-by: Thor Thayer > Signed-off-by: Dong Aisheng > --- Applied to clk-next
Re: [PATCH V6 1/4] clk: bulk: add of_clk_bulk_get()
Quoting Dong Aisheng (2018-08-30 21:45:53) > 'clock-names' property is optional in DT, so of_clk_bulk_get() is > introduced here to handle this for DT users without 'clock-names' > specified. Later clk_bulk_get_all() will be implemented on top of > it and this API will be kept private until someone proves they need > it because they don't have a struct device pointer. > > Cc: Stephen Boyd > Cc: Michael Turquette > Cc: Russell King > Reported-by: Shawn Guo > Tested-by: Thor Thayer > Signed-off-by: Dong Aisheng > --- Applied to clk-next
[PATCH V6 1/4] clk: bulk: add of_clk_bulk_get()
'clock-names' property is optional in DT, so of_clk_bulk_get() is
introduced here to handle this for DT users without 'clock-names'
specified. Later clk_bulk_get_all() will be implemented on top of
it and this API will be kept private until someone proves they need
it because they don't have a struct device pointer.
Cc: Stephen Boyd
Cc: Michael Turquette
Cc: Russell King
Reported-by: Shawn Guo
Tested-by: Thor Thayer
Signed-off-by: Dong Aisheng
---
v3->v4:
* no changes
v2->v3:
* remove #if define condition
* remove EXPORT_SYMBOL
---
drivers/clk/clk-bulk.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/drivers/clk/clk-bulk.c b/drivers/clk/clk-bulk.c
index 6904ed6..4460ac5 100644
--- a/drivers/clk/clk-bulk.c
+++ b/drivers/clk/clk-bulk.c
@@ -19,6 +19,35 @@
#include
#include
#include
+#include
+
+static int __must_check of_clk_bulk_get(struct device_node *np, int num_clks,
+ struct clk_bulk_data *clks)
+{
+ int ret;
+ int i;
+
+ for (i = 0; i < num_clks; i++)
+ clks[i].clk = NULL;
+
+ for (i = 0; i < num_clks; i++) {
+ clks[i].clk = of_clk_get(np, i);
+ if (IS_ERR(clks[i].clk)) {
+ ret = PTR_ERR(clks[i].clk);
+ pr_err("%pOF: Failed to get clk index: %d ret: %d\n",
+ np, i, ret);
+ clks[i].clk = NULL;
+ goto err;
+ }
+ }
+
+ return 0;
+
+err:
+ clk_bulk_put(i, clks);
+
+ return ret;
+}
void clk_bulk_put(int num_clks, struct clk_bulk_data *clks)
{
--
2.7.4
[PATCH V6 1/4] clk: bulk: add of_clk_bulk_get()
'clock-names' property is optional in DT, so of_clk_bulk_get() is
introduced here to handle this for DT users without 'clock-names'
specified. Later clk_bulk_get_all() will be implemented on top of
it and this API will be kept private until someone proves they need
it because they don't have a struct device pointer.
Cc: Stephen Boyd
Cc: Michael Turquette
Cc: Russell King
Reported-by: Shawn Guo
Tested-by: Thor Thayer
Signed-off-by: Dong Aisheng
---
v3->v4:
* no changes
v2->v3:
* remove #if define condition
* remove EXPORT_SYMBOL
---
drivers/clk/clk-bulk.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/drivers/clk/clk-bulk.c b/drivers/clk/clk-bulk.c
index 6904ed6..4460ac5 100644
--- a/drivers/clk/clk-bulk.c
+++ b/drivers/clk/clk-bulk.c
@@ -19,6 +19,35 @@
#include
#include
#include
+#include
+
+static int __must_check of_clk_bulk_get(struct device_node *np, int num_clks,
+ struct clk_bulk_data *clks)
+{
+ int ret;
+ int i;
+
+ for (i = 0; i < num_clks; i++)
+ clks[i].clk = NULL;
+
+ for (i = 0; i < num_clks; i++) {
+ clks[i].clk = of_clk_get(np, i);
+ if (IS_ERR(clks[i].clk)) {
+ ret = PTR_ERR(clks[i].clk);
+ pr_err("%pOF: Failed to get clk index: %d ret: %d\n",
+ np, i, ret);
+ clks[i].clk = NULL;
+ goto err;
+ }
+ }
+
+ return 0;
+
+err:
+ clk_bulk_put(i, clks);
+
+ return ret;
+}
void clk_bulk_put(int num_clks, struct clk_bulk_data *clks)
{
--
2.7.4
