Re: [PATCH V9 18/21] dt-bindings: csky CPU Bindings
On Thu, Oct 18, 2018 at 09:31:35AM -0500, Rob Herring wrote: > On Tue, 16 Oct 2018 10:58:37 +0800, Guo Ren wrote: > > This patch adds the documentation to describe that how to add cpu nodes in > > dts for SMP. > > > > Signed-off-by: Guo Ren > > Cc: Rob Herring > > --- > > Changelog: > > - Add compatible. > > - Remove status part. > > --- > > --- > > Documentation/devicetree/bindings/csky/cpus.txt | 73 > > + > > 1 file changed, 73 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/csky/cpus.txt > > > > Reviewed-by: Rob Herring Thx Rob Best Regards Guo Ren
Re: [PATCH V9 18/21] dt-bindings: csky CPU Bindings
On Thu, Oct 18, 2018 at 09:31:35AM -0500, Rob Herring wrote: > On Tue, 16 Oct 2018 10:58:37 +0800, Guo Ren wrote: > > This patch adds the documentation to describe that how to add cpu nodes in > > dts for SMP. > > > > Signed-off-by: Guo Ren > > Cc: Rob Herring > > --- > > Changelog: > > - Add compatible. > > - Remove status part. > > --- > > --- > > Documentation/devicetree/bindings/csky/cpus.txt | 73 > > + > > 1 file changed, 73 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/csky/cpus.txt > > > > Reviewed-by: Rob Herring Thx Rob Best Regards Guo Ren
Re: [PATCH V9 18/21] dt-bindings: csky CPU Bindings
On Tue, 16 Oct 2018 10:58:37 +0800, Guo Ren wrote: > This patch adds the documentation to describe that how to add cpu nodes in > dts for SMP. > > Signed-off-by: Guo Ren > Cc: Rob Herring > --- > Changelog: > - Add compatible. > - Remove status part. > --- > --- > Documentation/devicetree/bindings/csky/cpus.txt | 73 > + > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/csky/cpus.txt > Reviewed-by: Rob Herring
Re: [PATCH V9 18/21] dt-bindings: csky CPU Bindings
On Tue, 16 Oct 2018 10:58:37 +0800, Guo Ren wrote: > This patch adds the documentation to describe that how to add cpu nodes in > dts for SMP. > > Signed-off-by: Guo Ren > Cc: Rob Herring > --- > Changelog: > - Add compatible. > - Remove status part. > --- > --- > Documentation/devicetree/bindings/csky/cpus.txt | 73 > + > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/csky/cpus.txt > Reviewed-by: Rob Herring
Re: [PATCH V9 18/21] dt-bindings: csky CPU Bindings
On Thu, Oct 18, 2018 at 11:21:30AM +0800, Guo Ren wrote: > On Wed, Oct 17, 2018 at 05:50:33PM +0200, Arnd Bergmann wrote: > > On Tue, Oct 16, 2018 at 5:30 AM Guo Ren wrote: > > > > > > This patch adds the documentation to describe that how to add cpu nodes in > > > dts for SMP. > > > > > > Signed-off-by: Guo Ren > > > Cc: Rob Herring > > > > I don't see anything wrong, but I'll let Rob or some other DT maintainer > > provide an Ack when they are happy. > Yes, Rob help a lot for reviewing the DT-docs of csky subsystem. Thx Bob :) Sorry, Thx Rob. > > Best Regards > Guo Ren
Re: [PATCH V9 18/21] dt-bindings: csky CPU Bindings
On Thu, Oct 18, 2018 at 11:21:30AM +0800, Guo Ren wrote: > On Wed, Oct 17, 2018 at 05:50:33PM +0200, Arnd Bergmann wrote: > > On Tue, Oct 16, 2018 at 5:30 AM Guo Ren wrote: > > > > > > This patch adds the documentation to describe that how to add cpu nodes in > > > dts for SMP. > > > > > > Signed-off-by: Guo Ren > > > Cc: Rob Herring > > > > I don't see anything wrong, but I'll let Rob or some other DT maintainer > > provide an Ack when they are happy. > Yes, Rob help a lot for reviewing the DT-docs of csky subsystem. Thx Bob :) Sorry, Thx Rob. > > Best Regards > Guo Ren
Re: [PATCH V9 18/21] dt-bindings: csky CPU Bindings
On Wed, Oct 17, 2018 at 05:50:33PM +0200, Arnd Bergmann wrote: > On Tue, Oct 16, 2018 at 5:30 AM Guo Ren wrote: > > > > This patch adds the documentation to describe that how to add cpu nodes in > > dts for SMP. > > > > Signed-off-by: Guo Ren > > Cc: Rob Herring > > I don't see anything wrong, but I'll let Rob or some other DT maintainer > provide an Ack when they are happy. Yes, Rob help a lot for reviewing the DT-docs of csky subsystem. Thx Bob :) Best Regards Guo Ren
Re: [PATCH V9 18/21] dt-bindings: csky CPU Bindings
On Wed, Oct 17, 2018 at 05:50:33PM +0200, Arnd Bergmann wrote: > On Tue, Oct 16, 2018 at 5:30 AM Guo Ren wrote: > > > > This patch adds the documentation to describe that how to add cpu nodes in > > dts for SMP. > > > > Signed-off-by: Guo Ren > > Cc: Rob Herring > > I don't see anything wrong, but I'll let Rob or some other DT maintainer > provide an Ack when they are happy. Yes, Rob help a lot for reviewing the DT-docs of csky subsystem. Thx Bob :) Best Regards Guo Ren
Re: [PATCH V9 18/21] dt-bindings: csky CPU Bindings
On Tue, Oct 16, 2018 at 5:30 AM Guo Ren wrote: > > This patch adds the documentation to describe that how to add cpu nodes in > dts for SMP. > > Signed-off-by: Guo Ren > Cc: Rob Herring I don't see anything wrong, but I'll let Rob or some other DT maintainer provide an Ack when they are happy. Arnd
Re: [PATCH V9 18/21] dt-bindings: csky CPU Bindings
On Tue, Oct 16, 2018 at 5:30 AM Guo Ren wrote: > > This patch adds the documentation to describe that how to add cpu nodes in > dts for SMP. > > Signed-off-by: Guo Ren > Cc: Rob Herring I don't see anything wrong, but I'll let Rob or some other DT maintainer provide an Ack when they are happy. Arnd
[PATCH V9 18/21] dt-bindings: csky CPU Bindings
This patch adds the documentation to describe that how to add cpu nodes in dts for SMP. Signed-off-by: Guo Ren Cc: Rob Herring --- Changelog: - Add compatible. - Remove status part. --- --- Documentation/devicetree/bindings/csky/cpus.txt | 73 + 1 file changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/csky/cpus.txt diff --git a/Documentation/devicetree/bindings/csky/cpus.txt b/Documentation/devicetree/bindings/csky/cpus.txt new file mode 100644 index 000..ae79412 --- /dev/null +++ b/Documentation/devicetree/bindings/csky/cpus.txt @@ -0,0 +1,73 @@ +== +C-SKY CPU Bindings +== + +The device tree allows to describe the layout of CPUs in a system through +the "cpus" node, which in turn contains a number of subnodes (ie "cpu") +defining properties for every cpu. + +Only SMP system need to care about the cpus node and single processor +needn't define cpus node at all. + += +cpus and cpu node bindings definition += + +- cpus node + + Description: Container of cpu nodes + + The node name must be "cpus". + + A cpus node must define the following properties: + + - #address-cells + Usage: required + Value type: + Definition: must be set to 1 + - #size-cells + Usage: required + Value type: + Definition: must be set to 0 + +- cpu node + + Description: Describes one of SMP cores + + PROPERTIES + + - device_type + Usage: required + Value type: + Definition: must be "cpu" + - reg + Usage: required + Value type: + Definition: CPU index + - compatible: + Usage: required + Value type: + Definition: must contain "csky", eg: + "csky,610" + "csky,807" + "csky,810" + "csky,860" + +Example: + + + cpus { + #address-cells = <1>; + #size-cells = <0>; + cpu@0 { + device_type = "cpu"; + reg = <0>; + status = "ok"; + }; + + cpu@1 { + device_type = "cpu"; + reg = <1>; + status = "ok"; + }; + }; -- 2.7.4
[PATCH V9 18/21] dt-bindings: csky CPU Bindings
This patch adds the documentation to describe that how to add cpu nodes in dts for SMP. Signed-off-by: Guo Ren Cc: Rob Herring --- Changelog: - Add compatible. - Remove status part. --- --- Documentation/devicetree/bindings/csky/cpus.txt | 73 + 1 file changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/csky/cpus.txt diff --git a/Documentation/devicetree/bindings/csky/cpus.txt b/Documentation/devicetree/bindings/csky/cpus.txt new file mode 100644 index 000..ae79412 --- /dev/null +++ b/Documentation/devicetree/bindings/csky/cpus.txt @@ -0,0 +1,73 @@ +== +C-SKY CPU Bindings +== + +The device tree allows to describe the layout of CPUs in a system through +the "cpus" node, which in turn contains a number of subnodes (ie "cpu") +defining properties for every cpu. + +Only SMP system need to care about the cpus node and single processor +needn't define cpus node at all. + += +cpus and cpu node bindings definition += + +- cpus node + + Description: Container of cpu nodes + + The node name must be "cpus". + + A cpus node must define the following properties: + + - #address-cells + Usage: required + Value type: + Definition: must be set to 1 + - #size-cells + Usage: required + Value type: + Definition: must be set to 0 + +- cpu node + + Description: Describes one of SMP cores + + PROPERTIES + + - device_type + Usage: required + Value type: + Definition: must be "cpu" + - reg + Usage: required + Value type: + Definition: CPU index + - compatible: + Usage: required + Value type: + Definition: must contain "csky", eg: + "csky,610" + "csky,807" + "csky,810" + "csky,860" + +Example: + + + cpus { + #address-cells = <1>; + #size-cells = <0>; + cpu@0 { + device_type = "cpu"; + reg = <0>; + status = "ok"; + }; + + cpu@1 { + device_type = "cpu"; + reg = <1>; + status = "ok"; + }; + }; -- 2.7.4