Re: [Xen-devel] [PATCH WIP 6/6] xen/arm: enable evtchn irqs
On Wed, 25 Jul 2012, Konrad Rzeszutek Wilk wrote: > On Fri, Jul 20, 2012 at 04:23:07PM +0100, Stefano Stabellini wrote: > > On Fri, 20 Jul 2012, Konrad Rzeszutek Wilk wrote: > > > On Fri, Jul 20, 2012 at 12:09:56PM +0100, Stefano Stabellini wrote: > > > > On Fri, 20 Jul 2012, Konrad Rzeszutek Wilk wrote: > > > > > > > OK, please include those questions/answers in the git commit and > > > > > > > repost. > > > > > > > > > > I seem to be missing the rest of the patches. I see the > > > > > drivers/xen/events also > > > > > has the xen_init_IRQ_arm... is there a git tree with the base > > > > > patches? > > > > > > > > Yes, the latest git tree, based on > > > > 55b02d2f4445ad625213817a1736bf2884d32547, is available here: > > > > > > > > git://xenbits.xen.org/people/sstabellini/linux-pvhvm.git xenarmv7-3 > > > > > > Uh there is a bit of stuff there. > > > > Actually, aside from many backports and hacks, there are just three > > interesting patch series from my point of view: > > > > http://marc.info/?l=xen-devel&m=133001901013674&w=2 xen/arm: receive Xen > > events and initialize xenbus > > http://marc.info/?l=xen-devel&m=134038186610813&w=2 xen/arm: PV console > > support > > http://marc.info/?l=xen-devel&m=134140081408627&w=2 xen/arm: grant_table, > > blkfront and blkback > > > > The last two are recent and I have received feedback from you on the second > > one. > > > > > > > Can you just repost those you want me to > > > review and Ack that touch common code? > > > > Good idea, but fortunately there aren't that many of them. > > In fact if we exclude the ones that just add more #include, these are the > > ones > > that remains: > > > > d122a6b075e582af17dd2b3ddd8ee4ded3f85300 xen/arm: receive xen events on arm > > 1902bd5574447c03c1e6081cce98d8bf6e1f35e7 xen/arm: compile and run xenbus > > 5bbda4a165284aceee19b54954f10344b724b506 xen/arm: enable evtchn irqs > > d4fda31cf5411e8ada3f1163c68595b7474d7c1d xen/arm: initialize grant_table on > > ARM > > > > it would be nice if you could take a look at them and tell me what you > > think. > > > > > > > Or are you posting them to collect feedback/Acks and then want to post > > > them > > > as a bigger set? > > I am going to be lazy and wait for you to git-send-email the right patches. If > you like, you can just email them privately to me and I can look at them. No, that's fine. I should be able to send out the proper patch series within the next few days. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Xen-devel] [PATCH WIP 6/6] xen/arm: enable evtchn irqs
On Fri, Jul 20, 2012 at 04:23:07PM +0100, Stefano Stabellini wrote: > On Fri, 20 Jul 2012, Konrad Rzeszutek Wilk wrote: > > On Fri, Jul 20, 2012 at 12:09:56PM +0100, Stefano Stabellini wrote: > > > On Fri, 20 Jul 2012, Konrad Rzeszutek Wilk wrote: > > > > > > OK, please include those questions/answers in the git commit and > > > > > > repost. > > > > > > > > I seem to be missing the rest of the patches. I see the > > > > drivers/xen/events also > > > > has the xen_init_IRQ_arm... is there a git tree with the base patches? > > > > > > Yes, the latest git tree, based on > > > 55b02d2f4445ad625213817a1736bf2884d32547, is available here: > > > > > > git://xenbits.xen.org/people/sstabellini/linux-pvhvm.git xenarmv7-3 > > > > Uh there is a bit of stuff there. > > Actually, aside from many backports and hacks, there are just three > interesting patch series from my point of view: > > http://marc.info/?l=xen-devel&m=133001901013674&w=2 xen/arm: receive Xen > events and initialize xenbus > http://marc.info/?l=xen-devel&m=134038186610813&w=2 xen/arm: PV console > support > http://marc.info/?l=xen-devel&m=134140081408627&w=2 xen/arm: grant_table, > blkfront and blkback > > The last two are recent and I have received feedback from you on the second > one. > > > > Can you just repost those you want me to > > review and Ack that touch common code? > > Good idea, but fortunately there aren't that many of them. > In fact if we exclude the ones that just add more #include, these are the ones > that remains: > > d122a6b075e582af17dd2b3ddd8ee4ded3f85300 xen/arm: receive xen events on arm > 1902bd5574447c03c1e6081cce98d8bf6e1f35e7 xen/arm: compile and run xenbus > 5bbda4a165284aceee19b54954f10344b724b506 xen/arm: enable evtchn irqs > d4fda31cf5411e8ada3f1163c68595b7474d7c1d xen/arm: initialize grant_table on > ARM > > it would be nice if you could take a look at them and tell me what you think. > > > > Or are you posting them to collect feedback/Acks and then want to post them > > as a bigger set? I am going to be lazy and wait for you to git-send-email the right patches. If you like, you can just email them privately to me and I can look at them. > > Yes, the idea is to post them in a single set. > Now that I have support for the basic functionalities (guests booting, PV > console, disk and network), I can start working on a single patch > series for a recent kernel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Xen-devel] [PATCH WIP 6/6] xen/arm: enable evtchn irqs
On Fri, 20 Jul 2012, Konrad Rzeszutek Wilk wrote: > On Fri, Jul 20, 2012 at 12:09:56PM +0100, Stefano Stabellini wrote: > > On Fri, 20 Jul 2012, Konrad Rzeszutek Wilk wrote: > > > > > OK, please include those questions/answers in the git commit and > > > > > repost. > > > > > > I seem to be missing the rest of the patches. I see the > > > drivers/xen/events also > > > has the xen_init_IRQ_arm... is there a git tree with the base patches? > > > > Yes, the latest git tree, based on > > 55b02d2f4445ad625213817a1736bf2884d32547, is available here: > > > > git://xenbits.xen.org/people/sstabellini/linux-pvhvm.git xenarmv7-3 > > Uh there is a bit of stuff there. Actually, aside from many backports and hacks, there are just three interesting patch series from my point of view: http://marc.info/?l=xen-devel&m=133001901013674&w=2 xen/arm: receive Xen events and initialize xenbus http://marc.info/?l=xen-devel&m=134038186610813&w=2 xen/arm: PV console support http://marc.info/?l=xen-devel&m=134140081408627&w=2 xen/arm: grant_table, blkfront and blkback The last two are recent and I have received feedback from you on the second one. > Can you just repost those you want me to > review and Ack that touch common code? Good idea, but fortunately there aren't that many of them. In fact if we exclude the ones that just add more #include, these are the ones that remains: d122a6b075e582af17dd2b3ddd8ee4ded3f85300 xen/arm: receive xen events on arm 1902bd5574447c03c1e6081cce98d8bf6e1f35e7 xen/arm: compile and run xenbus 5bbda4a165284aceee19b54954f10344b724b506 xen/arm: enable evtchn irqs d4fda31cf5411e8ada3f1163c68595b7474d7c1d xen/arm: initialize grant_table on ARM it would be nice if you could take a look at them and tell me what you think. > Or are you posting them to collect feedback/Acks and then want to post them > as a bigger set? Yes, the idea is to post them in a single set. Now that I have support for the basic functionalities (guests booting, PV console, disk and network), I can start working on a single patch series for a recent kernel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Xen-devel] [PATCH WIP 6/6] xen/arm: enable evtchn irqs
On Fri, Jul 20, 2012 at 12:09:56PM +0100, Stefano Stabellini wrote: > On Fri, 20 Jul 2012, Konrad Rzeszutek Wilk wrote: > > > > OK, please include those questions/answers in the git commit and > > > > repost. > > > > I seem to be missing the rest of the patches. I see the drivers/xen/events > > also > > has the xen_init_IRQ_arm... is there a git tree with the base patches? > > Yes, the latest git tree, based on > 55b02d2f4445ad625213817a1736bf2884d32547, is available here: > > git://xenbits.xen.org/people/sstabellini/linux-pvhvm.git xenarmv7-3 Uh there is a bit of stuff there. Can you just repost those you want me to review and Ack that touch common code? Or are you posting them to collect feedback/Acks and then want to post them as a bigger set? > > ___ > Xen-devel mailing list > xen-de...@lists.xen.org > http://lists.xen.org/xen-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH WIP 6/6] xen/arm: enable evtchn irqs
On Fri, 20 Jul 2012, Konrad Rzeszutek Wilk wrote: > > > OK, please include those questions/answers in the git commit and > > > repost. > > I seem to be missing the rest of the patches. I see the drivers/xen/events > also > has the xen_init_IRQ_arm... is there a git tree with the base patches? Yes, the latest git tree, based on 55b02d2f4445ad625213817a1736bf2884d32547, is available here: git://xenbits.xen.org/people/sstabellini/linux-pvhvm.git xenarmv7-3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH WIP 6/6] xen/arm: enable evtchn irqs
> > OK, please include those questions/answers in the git commit and
> > repost.
I seem to be missing the rest of the patches. I see the drivers/xen/events also
has the xen_init_IRQ_arm... is there a git tree with the base patches?
>
> ---
>
> xen/arm: enable evtchn irqs
>
> On ARM Linux irqs are not enabled by default:
>
> - call enable_percpu_irq for IRQ_EVTCHN_CALLBACK (drivers are supposed
> to call enable_irq after request_irq);
>
> - set the IRQF_VALID flag for the other irqs bound to evtchns. It causes
> IRQ_NOAUTOEN to be set and as a consequence irq_unmask is going to be
> called when a xenbus driver calls request_irq.
> This is needed because IRQ_NOAUTOEN is set by set_irq_flags on ARM.
> If IRQ_NOAUTOEN is set __setup_irq doesn't call irq_startup that is
> responsible for calling irq_unmask at startup time.
>
> Signed-off-by: Stefano Stabellini
>
> diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> index eae0d0b..ca92755 100644
> --- a/drivers/xen/events.c
> +++ b/drivers/xen/events.c
> @@ -53,6 +53,7 @@
> #include
> #include
> #include
> +#include
>
> /*
> * This lock protects updates to the following mapping and reference-count
> @@ -824,6 +828,7 @@ int bind_evtchn_to_irq(unsigned int evtchn)
>
> xen_irq_info_evtchn_init(irq, evtchn);
> }
> + set_irq_flags(irq, IRQF_VALID);
>
> out:
> mutex_unlock(&irq_mapping_update_lock);
> @@ -1748,6 +1753,7 @@ int __init xen_init_IRQ_arm(void)
> if (rc) {
> printk(KERN_ERR "Error requesting IRQ %d\n",
> IRQ_EVTCHN_CALLBACK);
> }
> + enable_percpu_irq(IRQ_EVTCHN_CALLBACK, 0);
> return rc;
> }
> core_initcall(xen_init_IRQ_arm);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH WIP 6/6] xen/arm: enable evtchn irqs
On Mon, 16 Jul 2012, Konrad Rzeszutek Wilk wrote:
> On Fri, Jul 13, 2012 at 06:14:33PM +0100, Stefano Stabellini wrote:
> > On Mon, 9 Jul 2012, Konrad Rzeszutek Wilk wrote:
> > > On Fri, Jun 22, 2012 at 05:14:45PM +0100, Stefano Stabellini wrote:
> > > > On ARM irqs are not enabled by default:
> > >
> > > Which IRQs? Xen IRQs? Linux IRQs?
> >
> > Linux IRQs
> >
> >
> > > > - call enable_percpu_irq for IRQ_EVTCHN_CALLBACK;
> > >
> > > Why do we want to do that?
> >
> > drivers are supposed to call enable_irq after request_irq, however on
> > x86 we could get away without it because Linux irqs are enabled by
> > default (see below)
> >
> >
> > > > - set the IRQF_VALID flag for the other irqs bound to evtchns. It causes
> > > > IRQ_NOAUTOEN to be set and as a consequence irq_unmask is going to be
> > > > called when a xenbus driver calls request_irq.
> > >
> > > Can you explain in more details why we need that?
> >
> > If _IRQ_NOAUTOEN is set, irq_settings_can_autoenable returns false and
> > __setup_irq doesn't call irq_startup.
> >
> > IRQ_NOAUTOEN is set by default by set_irq_flags on ARM, but not on x86.
>
> OK, please include those questions/answers in the git commit and
> repost.
---
xen/arm: enable evtchn irqs
On ARM Linux irqs are not enabled by default:
- call enable_percpu_irq for IRQ_EVTCHN_CALLBACK (drivers are supposed
to call enable_irq after request_irq);
- set the IRQF_VALID flag for the other irqs bound to evtchns. It causes
IRQ_NOAUTOEN to be set and as a consequence irq_unmask is going to be
called when a xenbus driver calls request_irq.
This is needed because IRQ_NOAUTOEN is set by set_irq_flags on ARM.
If IRQ_NOAUTOEN is set __setup_irq doesn't call irq_startup that is
responsible for calling irq_unmask at startup time.
Signed-off-by: Stefano Stabellini
diff --git a/drivers/xen/events.c b/drivers/xen/events.c
index eae0d0b..ca92755 100644
--- a/drivers/xen/events.c
+++ b/drivers/xen/events.c
@@ -53,6 +53,7 @@
#include
#include
#include
+#include
/*
* This lock protects updates to the following mapping and reference-count
@@ -824,6 +828,7 @@ int bind_evtchn_to_irq(unsigned int evtchn)
xen_irq_info_evtchn_init(irq, evtchn);
}
+ set_irq_flags(irq, IRQF_VALID);
out:
mutex_unlock(&irq_mapping_update_lock);
@@ -1748,6 +1753,7 @@ int __init xen_init_IRQ_arm(void)
if (rc) {
printk(KERN_ERR "Error requesting IRQ %d\n",
IRQ_EVTCHN_CALLBACK);
}
+ enable_percpu_irq(IRQ_EVTCHN_CALLBACK, 0);
return rc;
}
core_initcall(xen_init_IRQ_arm);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH WIP 6/6] xen/arm: enable evtchn irqs
On Fri, Jul 13, 2012 at 06:14:33PM +0100, Stefano Stabellini wrote:
> On Mon, 9 Jul 2012, Konrad Rzeszutek Wilk wrote:
> > On Fri, Jun 22, 2012 at 05:14:45PM +0100, Stefano Stabellini wrote:
> > > On ARM irqs are not enabled by default:
> >
> > Which IRQs? Xen IRQs? Linux IRQs?
>
> Linux IRQs
>
>
> > > - call enable_percpu_irq for IRQ_EVTCHN_CALLBACK;
> >
> > Why do we want to do that?
>
> drivers are supposed to call enable_irq after request_irq, however on
> x86 we could get away without it because Linux irqs are enabled by
> default (see below)
>
>
> > > - set the IRQF_VALID flag for the other irqs bound to evtchns. It causes
> > > IRQ_NOAUTOEN to be set and as a consequence irq_unmask is going to be
> > > called when a xenbus driver calls request_irq.
> >
> > Can you explain in more details why we need that?
>
> If _IRQ_NOAUTOEN is set, irq_settings_can_autoenable returns false and
> __setup_irq doesn't call irq_startup.
>
> IRQ_NOAUTOEN is set by default by set_irq_flags on ARM, but not on x86.
OK, please include those questions/answers in the git commit and
repost.
>
>
>
> > > Signed-off-by: Stefano Stabellini
> > > ---
> > > drivers/xen/events.c |3 +++
> > > 1 files changed, 3 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> > > index 0132505..ca92755 100644
> > > --- a/drivers/xen/events.c
> > > +++ b/drivers/xen/events.c
> > > @@ -53,6 +53,7 @@
> > > #include
> > > #include
> > > #include
> > > +#include
> > >
> > > /*
> > > * This lock protects updates to the following mapping and
> > > reference-count
> > > @@ -827,6 +828,7 @@ int bind_evtchn_to_irq(unsigned int evtchn)
> > >
> > > xen_irq_info_evtchn_init(irq, evtchn);
> > > }
> > > + set_irq_flags(irq, IRQF_VALID);
> > >
> > > out:
> > > mutex_unlock(&irq_mapping_update_lock);
> > > @@ -1751,6 +1753,7 @@ int __init xen_init_IRQ_arm(void)
> > > if (rc) {
> > > printk(KERN_ERR "Error requesting IRQ %d\n",
> > > IRQ_EVTCHN_CALLBACK);
> > > }
> > > + enable_percpu_irq(IRQ_EVTCHN_CALLBACK, 0);
> > > return rc;
> > > }
> > > core_initcall(xen_init_IRQ_arm);
> > > --
> > > 1.7.2.5
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > > the body of a message to majord...@vger.kernel.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > > Please read the FAQ at http://www.tux.org/lkml/
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH WIP 6/6] xen/arm: enable evtchn irqs
On Mon, 9 Jul 2012, Konrad Rzeszutek Wilk wrote:
> On Fri, Jun 22, 2012 at 05:14:45PM +0100, Stefano Stabellini wrote:
> > On ARM irqs are not enabled by default:
>
> Which IRQs? Xen IRQs? Linux IRQs?
Linux IRQs
> > - call enable_percpu_irq for IRQ_EVTCHN_CALLBACK;
>
> Why do we want to do that?
drivers are supposed to call enable_irq after request_irq, however on
x86 we could get away without it because Linux irqs are enabled by
default (see below)
> > - set the IRQF_VALID flag for the other irqs bound to evtchns. It causes
> > IRQ_NOAUTOEN to be set and as a consequence irq_unmask is going to be
> > called when a xenbus driver calls request_irq.
>
> Can you explain in more details why we need that?
If _IRQ_NOAUTOEN is set, irq_settings_can_autoenable returns false and
__setup_irq doesn't call irq_startup.
IRQ_NOAUTOEN is set by default by set_irq_flags on ARM, but not on x86.
> > Signed-off-by: Stefano Stabellini
> > ---
> > drivers/xen/events.c |3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> > index 0132505..ca92755 100644
> > --- a/drivers/xen/events.c
> > +++ b/drivers/xen/events.c
> > @@ -53,6 +53,7 @@
> > #include
> > #include
> > #include
> > +#include
> >
> > /*
> > * This lock protects updates to the following mapping and reference-count
> > @@ -827,6 +828,7 @@ int bind_evtchn_to_irq(unsigned int evtchn)
> >
> > xen_irq_info_evtchn_init(irq, evtchn);
> > }
> > + set_irq_flags(irq, IRQF_VALID);
> >
> > out:
> > mutex_unlock(&irq_mapping_update_lock);
> > @@ -1751,6 +1753,7 @@ int __init xen_init_IRQ_arm(void)
> > if (rc) {
> > printk(KERN_ERR "Error requesting IRQ %d\n",
> > IRQ_EVTCHN_CALLBACK);
> > }
> > + enable_percpu_irq(IRQ_EVTCHN_CALLBACK, 0);
> > return rc;
> > }
> > core_initcall(xen_init_IRQ_arm);
> > --
> > 1.7.2.5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majord...@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH WIP 6/6] xen/arm: enable evtchn irqs
On Fri, Jun 22, 2012 at 05:14:45PM +0100, Stefano Stabellini wrote:
> On ARM irqs are not enabled by default:
Which IRQs? Xen IRQs? Linux IRQs?
>
> - call enable_percpu_irq for IRQ_EVTCHN_CALLBACK;
Why do we want to do that?
>
> - set the IRQF_VALID flag for the other irqs bound to evtchns. It causes
> IRQ_NOAUTOEN to be set and as a consequence irq_unmask is going to be
> called when a xenbus driver calls request_irq.
Can you explain in more details why we need that?
>
> Signed-off-by: Stefano Stabellini
> ---
> drivers/xen/events.c |3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> index 0132505..ca92755 100644
> --- a/drivers/xen/events.c
> +++ b/drivers/xen/events.c
> @@ -53,6 +53,7 @@
> #include
> #include
> #include
> +#include
>
> /*
> * This lock protects updates to the following mapping and reference-count
> @@ -827,6 +828,7 @@ int bind_evtchn_to_irq(unsigned int evtchn)
>
> xen_irq_info_evtchn_init(irq, evtchn);
> }
> + set_irq_flags(irq, IRQF_VALID);
>
> out:
> mutex_unlock(&irq_mapping_update_lock);
> @@ -1751,6 +1753,7 @@ int __init xen_init_IRQ_arm(void)
> if (rc) {
> printk(KERN_ERR "Error requesting IRQ %d\n",
> IRQ_EVTCHN_CALLBACK);
> }
> + enable_percpu_irq(IRQ_EVTCHN_CALLBACK, 0);
> return rc;
> }
> core_initcall(xen_init_IRQ_arm);
> --
> 1.7.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
