Re: [PATCH baohua] ASoC: sirf: atlas7: atlas7_iacc_dai_ops can be static
On Thu, Feb 05, 2015 at 05:11:59PM +, Mark Brown wrote: > On Fri, Feb 06, 2015 at 01:03:52AM +0800, kbuild test robot wrote: > > sound/soc/sirf/atlas7-iacc.c:168:24: sparse: symbol 'atlas7_iacc_dai_ops' > > was not declared. Should it be static? > > This file isn't in an upstream tree, should this patch have been sent > upstream (I suspect non-upstream trees may need a bit of filtering in > the scripts)? Good point! I just added some tests trying to avoid this, which should be much better, but nevertheless not complete enough to cover all cases. Please help point out inadequate cases when you come across them in future! Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH baohua] ASoC: sirf: atlas7: atlas7_iacc_dai_ops can be static
On Thu, Feb 05, 2015 at 05:11:59PM +, Mark Brown wrote: On Fri, Feb 06, 2015 at 01:03:52AM +0800, kbuild test robot wrote: sound/soc/sirf/atlas7-iacc.c:168:24: sparse: symbol 'atlas7_iacc_dai_ops' was not declared. Should it be static? This file isn't in an upstream tree, should this patch have been sent upstream (I suspect non-upstream trees may need a bit of filtering in the scripts)? Good point! I just added some tests trying to avoid this, which should be much better, but nevertheless not complete enough to cover all cases. Please help point out inadequate cases when you come across them in future! Thanks, Fengguang -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [alsa-devel] [PATCH baohua] ASoC: sirf: atlas7: atlas7_iacc_dai_ops can be static
2015-02-06 1:11 GMT+08:00 Mark Brown : > On Fri, Feb 06, 2015 at 01:03:52AM +0800, kbuild test robot wrote: >> sound/soc/sirf/atlas7-iacc.c:168:24: sparse: symbol 'atlas7_iacc_dai_ops' >> was not declared. Should it be static? > > This file isn't in an upstream tree, should this patch have been sent > upstream (I suspect non-upstream trees may need a bit of filtering in > the scripts)? the file is new and under developing. so no patch for it yet. is it possible to modify kbuild script? > > ___ > Alsa-devel mailing list > alsa-de...@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > -barry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH baohua] ASoC: sirf: atlas7: atlas7_iacc_dai_ops can be static
On Fri, Feb 06, 2015 at 01:03:52AM +0800, kbuild test robot wrote: > sound/soc/sirf/atlas7-iacc.c:168:24: sparse: symbol 'atlas7_iacc_dai_ops' was > not declared. Should it be static? This file isn't in an upstream tree, should this patch have been sent upstream (I suspect non-upstream trees may need a bit of filtering in the scripts)? signature.asc Description: Digital signature
[PATCH baohua] ASoC: sirf: atlas7: atlas7_iacc_dai_ops can be static
sound/soc/sirf/atlas7-iacc.c:168:24: sparse: symbol 'atlas7_iacc_dai_ops' was
not declared. Should it be static?
Signed-off-by: Fengguang Wu
---
atlas7-iacc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sirf/atlas7-iacc.c b/sound/soc/sirf/atlas7-iacc.c
index ca17e90..a359d8b 100644
--- a/sound/soc/sirf/atlas7-iacc.c
+++ b/sound/soc/sirf/atlas7-iacc.c
@@ -165,7 +165,7 @@ static int atlas7_iacc_trigger(struct snd_pcm_substream
*substream,
return 0;
}
-struct snd_soc_dai_ops atlas7_iacc_dai_ops = {
+static struct snd_soc_dai_ops atlas7_iacc_dai_ops = {
.hw_params = atlas7_iacc_hw_params,
.trigger = atlas7_iacc_trigger,
};
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH baohua] ASoC: sirf: atlas7: atlas7_iacc_dai_ops can be static
On Fri, Feb 06, 2015 at 01:03:52AM +0800, kbuild test robot wrote: sound/soc/sirf/atlas7-iacc.c:168:24: sparse: symbol 'atlas7_iacc_dai_ops' was not declared. Should it be static? This file isn't in an upstream tree, should this patch have been sent upstream (I suspect non-upstream trees may need a bit of filtering in the scripts)? signature.asc Description: Digital signature
[PATCH baohua] ASoC: sirf: atlas7: atlas7_iacc_dai_ops can be static
sound/soc/sirf/atlas7-iacc.c:168:24: sparse: symbol 'atlas7_iacc_dai_ops' was
not declared. Should it be static?
Signed-off-by: Fengguang Wu fengguang...@intel.com
---
atlas7-iacc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sirf/atlas7-iacc.c b/sound/soc/sirf/atlas7-iacc.c
index ca17e90..a359d8b 100644
--- a/sound/soc/sirf/atlas7-iacc.c
+++ b/sound/soc/sirf/atlas7-iacc.c
@@ -165,7 +165,7 @@ static int atlas7_iacc_trigger(struct snd_pcm_substream
*substream,
return 0;
}
-struct snd_soc_dai_ops atlas7_iacc_dai_ops = {
+static struct snd_soc_dai_ops atlas7_iacc_dai_ops = {
.hw_params = atlas7_iacc_hw_params,
.trigger = atlas7_iacc_trigger,
};
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [alsa-devel] [PATCH baohua] ASoC: sirf: atlas7: atlas7_iacc_dai_ops can be static
2015-02-06 1:11 GMT+08:00 Mark Brown broo...@kernel.org: On Fri, Feb 06, 2015 at 01:03:52AM +0800, kbuild test robot wrote: sound/soc/sirf/atlas7-iacc.c:168:24: sparse: symbol 'atlas7_iacc_dai_ops' was not declared. Should it be static? This file isn't in an upstream tree, should this patch have been sent upstream (I suspect non-upstream trees may need a bit of filtering in the scripts)? the file is new and under developing. so no patch for it yet. is it possible to modify kbuild script? ___ Alsa-devel mailing list alsa-de...@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel -barry -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
