Re: [PATCH master] module: remove never implemented MODULE_SUPPORTED_DEVICE
On Thu, Mar 18, 2021 at 10:55:51AM -0700, Linus Torvalds wrote: > On Thu, Mar 18, 2021 at 10:49 AM Leon Romanovsky wrote: > > > > No, I opened patch and added the note manually, so it is definitely my VIM. > > Most likely this part of my .vimrc caused it. > > Ok, that would do it. > > Yeah, whitespace is easy to "fix" at patch application time, but it > really is meaningful and you never should change whitespace for > patches. > > Maybe you can limit your rules to just particular file types > (although, honestly, I think it's bad for headers and C files too when > it then causes entirely irrelevant and independent changes - you only > want your own _new_ edits to be whitespace-clean, not fix other random > issues). > > Better yet, maybe not "fix whitespace" at all, but have some code > coloring logic that just points out bad whitespace? I use "git diff" > myself, with colorization being default for tty operations: > > [color] > ui=auto > > so that then "git diff" will show you your (new) evil whitespace > errors when you review your changes, but won't complain about existing > whitespace issues.. Yeah, my color.ui is "always", so I will simply remove the problematic line from VIM and won't change whitespaces at all. Thanks > > Linus
Re: [PATCH master] module: remove never implemented MODULE_SUPPORTED_DEVICE
On Thu, Mar 18, 2021 at 10:49 AM Leon Romanovsky wrote: > > No, I opened patch and added the note manually, so it is definitely my VIM. > Most likely this part of my .vimrc caused it. Ok, that would do it. Yeah, whitespace is easy to "fix" at patch application time, but it really is meaningful and you never should change whitespace for patches. Maybe you can limit your rules to just particular file types (although, honestly, I think it's bad for headers and C files too when it then causes entirely irrelevant and independent changes - you only want your own _new_ edits to be whitespace-clean, not fix other random issues). Better yet, maybe not "fix whitespace" at all, but have some code coloring logic that just points out bad whitespace? I use "git diff" myself, with colorization being default for tty operations: [color] ui=auto so that then "git diff" will show you your (new) evil whitespace errors when you review your changes, but won't complain about existing whitespace issues.. Linus
Re: [PATCH master] module: remove never implemented MODULE_SUPPORTED_DEVICE
On Thu, Mar 18, 2021 at 10:36:36AM -0700, Linus Torvalds wrote: > On Thu, Mar 18, 2021 at 12:55 AM Leon Romanovsky wrote: > > > > > > Also, your email seems to have swallowed spaces at the ends of lines. > > > > > > I can (and did) apply the patch with "--whitespace=fix", but that then > > > causes git to fix some _other_ whitespace too, so the end result isn't > > > quite the same. Oh well. > > > > > > Please check what's up with your email sending client that it seems to > > > remove space at end of lines in patches. > > > > This is strange, I'm sending patches with "git send-email" with pretty > > standard settings: > > Hmm. I can't tell whats' wrong, but both my own mailbox and the > lore.kernel.org clearly has missing whitespace at end of lines. > > You can see it yourself with a simple > >b4 am 20210317104547.442203-1-l...@kernel.org > > (assuming you have b4 installed, of course: > > https://pypi.org/project/b4/ > > but with a kernel.org address I'm sure you've seen the emails about it > even if you may not be a user). Thanks, I'll try. > > > Also, I'm using mail.kernel.org as a SMTP especially to make sure that > > my mails are not mangled by our exchange server. > > Yeah, the email looks fine in any other way technically, it passes SPF > and DKIM, and I don't see anything else strange going on either. > > I think the same VIM issue that caused some whitespace line changes > for you in the patch might have then bitten you when you sent it out - > I know you must have edited the message, becasuse you have that > >"I'm sending this patch to you directly because it is much saner to > apply it in one place instead of multiple patches saga that will [...]" > > below the commit message, that you presumable added with "--annotate". No, I opened patch and added the note manually, so it is definitely my VIM. Most likely this part of my .vimrc caused it. " Remove trailing white spaces " http://vim.wikia.com/wiki/Remove_unwanted_spaces autocmd BufWritePre * %s/\s\+$//e > > > Are you sure that such change came from me and not from "--whitespace=fix"? > > Yup. See above on how you can just use b4 to download a copy yourself.. I'll try, thanks for taking the patch and for the analysis. > > Linus
Re: [PATCH master] module: remove never implemented MODULE_SUPPORTED_DEVICE
On Thu, Mar 18, 2021 at 12:55 AM Leon Romanovsky wrote: > > > > Also, your email seems to have swallowed spaces at the ends of lines. > > > > I can (and did) apply the patch with "--whitespace=fix", but that then > > causes git to fix some _other_ whitespace too, so the end result isn't > > quite the same. Oh well. > > > > Please check what's up with your email sending client that it seems to > > remove space at end of lines in patches. > > This is strange, I'm sending patches with "git send-email" with pretty > standard settings: Hmm. I can't tell whats' wrong, but both my own mailbox and the lore.kernel.org clearly has missing whitespace at end of lines. You can see it yourself with a simple b4 am 20210317104547.442203-1-l...@kernel.org (assuming you have b4 installed, of course: https://pypi.org/project/b4/ but with a kernel.org address I'm sure you've seen the emails about it even if you may not be a user). > Also, I'm using mail.kernel.org as a SMTP especially to make sure that > my mails are not mangled by our exchange server. Yeah, the email looks fine in any other way technically, it passes SPF and DKIM, and I don't see anything else strange going on either. I think the same VIM issue that caused some whitespace line changes for you in the patch might have then bitten you when you sent it out - I know you must have edited the message, becasuse you have that "I'm sending this patch to you directly because it is much saner to apply it in one place instead of multiple patches saga that will [...]" below the commit message, that you presumable added with "--annotate". > Are you sure that such change came from me and not from "--whitespace=fix"? Yup. See above on how you can just use b4 to download a copy yourself.. Linus
Re: [PATCH master] module: remove never implemented MODULE_SUPPORTED_DEVICE
On Wed, Mar 17, 2021 at 01:17:32PM -0700, Linus Torvalds wrote: > On Wed, Mar 17, 2021 at 3:46 AM Leon Romanovsky wrote: > > > > I'm sending this patch to you directly because it is much saner to > > apply it in one place instead of multiple patches saga that will > > span for at least two cycles if per-maintainer path will be taken. > > > > It applies cleanly on v5.12-rc2 and completely unharmful. > > You have an odd whitespace-only part in the patch inside the comment > underneath the "remove RME,Hammerfall" case. This is something that I missed, my VIM changed whitespaces in many old files and I didn't pay attention when added that chunk. > > Also, your email seems to have swallowed spaces at the ends of lines. > > I can (and did) apply the patch with "--whitespace=fix", but that then > causes git to fix some _other_ whitespace too, so the end result isn't > quite the same. Oh well. > > Please check what's up with your email sending client that it seems to > remove space at end of lines in patches. This is strange, I'm sending patches with "git send-email" with pretty standard settings: 28 [sendemail] 29 smtpserver = /usr/local/bin/msmtp-enqueue.sh 30 suppresscc = self 31 chainReplyTo = false 32 confirm = always 33 from = Leon Romanovsky 34 envelopeSender = Leon Romanovsky 35 signingkey = l...@kernel.org 36 composeencoding = utf-8 Also, I'm using mail.kernel.org as a SMTP especially to make sure that my mails are not mangled by our exchange server. Are you sure that such change came from me and not from "--whitespace=fix"? Thanks > > Linus
Re: [PATCH master] module: remove never implemented MODULE_SUPPORTED_DEVICE
On Wed, Mar 17, 2021 at 3:46 AM Leon Romanovsky wrote: > > I'm sending this patch to you directly because it is much saner to > apply it in one place instead of multiple patches saga that will > span for at least two cycles if per-maintainer path will be taken. > > It applies cleanly on v5.12-rc2 and completely unharmful. You have an odd whitespace-only part in the patch inside the comment underneath the "remove RME,Hammerfall" case. Also, your email seems to have swallowed spaces at the ends of lines. I can (and did) apply the patch with "--whitespace=fix", but that then causes git to fix some _other_ whitespace too, so the end result isn't quite the same. Oh well. Please check what's up with your email sending client that it seems to remove space at end of lines in patches. Linus
[PATCH master] module: remove never implemented MODULE_SUPPORTED_DEVICE
From: Leon Romanovsky MODULE_SUPPORTED_DEVICE was added in pre-git era and never was implemented. We can safely remove it, because the kernel has grown to have many more reliable mechanisms to determine if device is supported or not. Signed-off-by: Leon Romanovsky --- Hi Linus, I'm sending this patch to you directly because it is much saner to apply it in one place instead of multiple patches saga that will span for at least two cycles if per-maintainer path will be taken. It applies cleanly on v5.12-rc2 and completely unharmful. Thanks --- arch/x86/platform/iris/iris.c | 1 - drivers/atm/fore200e.c| 2 -- drivers/block/floppy.c| 1 - drivers/bluetooth/btrsi.c | 1 - drivers/char/applicom.c | 3 -- drivers/char/toshiba.c| 1 - drivers/input/joydev.c| 1 - drivers/media/firewire/firedtv-fw.c | 1 - drivers/media/pci/cx18/cx18-alsa-main.c | 1 - drivers/media/pci/cx18/cx18-driver.c | 1 - drivers/media/pci/cx25821/cx25821-alsa.c | 1 - drivers/media/pci/cx88/cx88-alsa.c| 1 - drivers/media/pci/ivtv/ivtv-alsa-main.c | 1 - drivers/media/pci/ivtv/ivtv-driver.c | 3 -- drivers/media/pci/sta2x11/sta2x11_vip.c | 1 - drivers/media/platform/atmel/atmel-isi.c | 1 - .../media/platform/atmel/atmel-sama5d2-isc.c | 1 - .../media/platform/marvell-ccic/cafe-driver.c | 4 --- drivers/media/platform/stm32/stm32-dcmi.c | 1 - drivers/media/usb/cpia2/cpia2_v4l.c | 1 - drivers/media/usb/tm6000/tm6000-alsa.c| 1 - drivers/media/usb/tm6000/tm6000-dvb.c | 2 -- drivers/mtd/maps/sun_uflash.c | 1 - drivers/net/can/peak_canfd/peak_pciefd_main.c | 1 - drivers/net/can/sja1000/ems_pci.c | 1 - drivers/net/can/sja1000/ems_pcmcia.c | 1 - drivers/net/can/sja1000/kvaser_pci.c | 1 - drivers/net/can/sja1000/peak_pci.c| 2 -- drivers/net/can/sja1000/peak_pcmcia.c | 1 - drivers/net/can/sja1000/plx_pci.c | 12 --- drivers/net/can/usb/peak_usb/pcan_usb.c | 2 -- drivers/net/can/usb/peak_usb/pcan_usb_fd.c| 3 -- drivers/net/can/usb/peak_usb/pcan_usb_pro.c | 2 -- drivers/net/hamradio/scc.c| 1 - drivers/net/wireless/admtek/adm8211.c | 1 - drivers/net/wireless/ath/ath5k/base.c | 1 - drivers/net/wireless/ath/ath9k/hw.c | 1 - drivers/net/wireless/ath/ath9k/init.c | 1 - drivers/net/wireless/atmel/atmel.c| 1 - drivers/net/wireless/atmel/atmel_cs.c | 1 - drivers/net/wireless/atmel/atmel_pci.c| 1 - .../broadcom/brcm80211/brcmsmac/mac80211_if.c | 1 - .../broadcom/brcm80211/brcmutil/utils.c | 1 - drivers/net/wireless/cisco/airo.c | 1 - drivers/net/wireless/cisco/airo_cs.c | 1 - .../net/wireless/intersil/hostap/hostap_cs.c | 1 - .../net/wireless/intersil/hostap/hostap_pci.c | 1 - .../net/wireless/intersil/hostap/hostap_plx.c | 1 - .../net/wireless/ralink/rt2x00/rt2400pci.c| 1 - .../net/wireless/ralink/rt2x00/rt2500pci.c| 1 - .../net/wireless/ralink/rt2x00/rt2500usb.c| 1 - .../net/wireless/ralink/rt2x00/rt2800pci.c| 1 - .../net/wireless/ralink/rt2x00/rt2800usb.c| 1 - drivers/net/wireless/ralink/rt2x00/rt61pci.c | 2 -- drivers/net/wireless/ralink/rt2x00/rt73usb.c | 1 - drivers/net/wireless/rsi/rsi_91x_main.c | 1 - drivers/net/wireless/rsi/rsi_91x_sdio.c | 1 - drivers/net/wireless/rsi/rsi_91x_usb.c| 1 - drivers/parport/parport_amiga.c | 1 - drivers/parport/parport_atari.c | 1 - drivers/parport/parport_gsc.c | 1 - drivers/parport/parport_mfc3.c| 1 - drivers/parport/parport_sunbpp.c | 1 - drivers/s390/block/dasd.c | 1 - drivers/sbus/char/display7seg.c | 1 - drivers/scsi/hpsa.c | 1 - drivers/scsi/pcmcia/nsp_cs.c | 1 - drivers/scsi/smartpqi/smartpqi_init.c | 1 - drivers/sh/maple/maple.c | 1 - drivers/staging/comedi/drivers/vmk80xx.c | 1 - drivers/tee/optee/core.c | 1 - drivers/tty/serial/icom.c | 2 -- drivers/tty/serial/jsm/jsm_driver.c | 1 - drivers/usb/misc/ldusb.c | 1 - drivers/watchdog/cpu5wdt.c| 1 - drivers/watchdog/cpwd.c | 1 - drivers/watchdog/riowd.c | 1 - include/linux/module.h| 3 -- net/batman-adv/main.c | 1 - sound/drivers/aloop.c | 1 - sound/drivers/dummy.c | 1 - sound/drivers/mtpav.c | 1
