Re: [PATCH net] net: mvpp2: Fix error return code in mvpp2_open()

[Jakub Kicinski]

On Thu, 3 Dec 2020 16:23:46 +0100 Andrew Lunn wrote:
> On Thu, Dec 03, 2020 at 10:18:06PM +0800, Wang Hai wrote:
> > Fix to return negative error code -ENOENT from invalid configuration
> > error handling case instead of 0, as done elsewhere in this function.
> > 
> > Fixes: 4bb043262878 ("net: mvpp2: phylink support")
> > Reported-by: Hulk Robot 
> > Signed-off-by: Wang Hai   
> 
> Reviewed-by: Andrew Lunn 

Applied, thanks!

Re: [PATCH net] net: mvpp2: Fix error return code in mvpp2_open()

[Andrew Lunn]

On Thu, Dec 03, 2020 at 10:18:06PM +0800, Wang Hai wrote:
> Fix to return negative error code -ENOENT from invalid configuration
> error handling case instead of 0, as done elsewhere in this function.
> 
> Fixes: 4bb043262878 ("net: mvpp2: phylink support")
> Reported-by: Hulk Robot 
> Signed-off-by: Wang Hai 

Reviewed-by: Andrew Lunn 

Andrew

[PATCH net] net: mvpp2: Fix error return code in mvpp2_open()

[Wang Hai]

Fix to return negative error code -ENOENT from invalid configuration
error handling case instead of 0, as done elsewhere in this function.

Fixes: 4bb043262878 ("net: mvpp2: phylink support")
Reported-by: Hulk Robot 
Signed-off-by: Wang Hai 
---
 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c 
b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index f6616c8933ca..cea886c5bcb5 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -4426,6 +4426,7 @@ static int mvpp2_open(struct net_device *dev)
if (!valid) {
netdev_err(port->dev,
   "invalid configuration: no dt or link IRQ");
+   err = -ENOENT;
goto err_free_irq;
}
 
-- 
2.17.1