Re: [PATCH net-next] net: usb: cdc_ncm: emit dev_err on error paths

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Sat,  6 Mar 2021 14:12:31 -0800 you wrote:
> Several error paths in bind/probe code will only emit
> output using dev_dbg. But if we are going to fail the
> bind/probe, emit related output with "err" priority.
> 
> Signed-off-by: Grant Grundler 
> ---
>  drivers/net/usb/cdc_ncm.c | 10 +-
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> [...]

Here is the summary with links:
  - [net-next] net: usb: cdc_ncm: emit dev_err on error paths
https://git.kernel.org/netdev/net/c/492bbe7f8a43

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

[PATCH net-next] net: usb: cdc_ncm: emit dev_err on error paths

[Grant Grundler]

Several error paths in bind/probe code will only emit
output using dev_dbg. But if we are going to fail the
bind/probe, emit related output with "err" priority.

Signed-off-by: Grant Grundler 
---
 drivers/net/usb/cdc_ncm.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

Reposting to net-next per instructions in 
https://www.spinics.net/lists/netdev/msg715496.html

I've applied this patch to most chromeos kernels:
https://chromium-review.googlesource.com/q/hashtag:usbnet-rtl8156-support

diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 5a78848db93f..25498c311551 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -849,17 +849,17 @@ int cdc_ncm_bind_common(struct usbnet *dev, struct 
usb_interface *intf, u8 data_
 
/* check if we got everything */
if (!ctx->data) {
-   dev_dbg(>dev, "CDC Union missing and no IAD found\n");
+   dev_err(>dev, "CDC Union missing and no IAD found\n");
goto error;
}
if (cdc_ncm_comm_intf_is_mbim(intf->cur_altsetting)) {
if (!ctx->mbim_desc) {
-   dev_dbg(>dev, "MBIM functional descriptor 
missing\n");
+   dev_err(>dev, "MBIM functional descriptor 
missing\n");
goto error;
}
} else {
if (!ctx->ether_desc || !ctx->func_desc) {
-   dev_dbg(>dev, "NCM or ECM functional descriptors 
missing\n");
+   dev_err(>dev, "NCM or ECM functional descriptors 
missing\n");
goto error;
}
}
@@ -868,7 +868,7 @@ int cdc_ncm_bind_common(struct usbnet *dev, struct 
usb_interface *intf, u8 data_
if (ctx->data != ctx->control) {
temp = usb_driver_claim_interface(driver, ctx->data, dev);
if (temp) {
-   dev_dbg(>dev, "failed to claim data intf\n");
+   dev_err(>dev, "failed to claim data intf\n");
goto error;
}
}
@@ -924,7 +924,7 @@ int cdc_ncm_bind_common(struct usbnet *dev, struct 
usb_interface *intf, u8 data_
if (ctx->ether_desc) {
temp = usbnet_get_ethernet_addr(dev, 
ctx->ether_desc->iMACAddress);
if (temp) {
-   dev_dbg(>dev, "failed to get mac address\n");
+   dev_err(>dev, "failed to get mac address\n");
goto error2;
}
dev_info(>dev, "MAC-Address: %pM\n", dev->net->dev_addr);
-- 
2.29.2