Re: [PATCH net-next 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port

[Michal Vokáč]

On 21.5.2018 17:17, Florian Fainelli wrote:


On 05/21/2018 06:28 AM, Michal Vokáč wrote:

When a port is brought up/down do not enable/disable only the TXMAC
but the RXMAC as well. This is essential for the CPU port to work.

Signed-off-by: Michal Vokáč 


Reviewed-by: Florian Fainelli 

Should this have:

Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")?


Yes, I think it is a good idea to can add this. Will do it in v2.

Thanks,
Michal

Re: [PATCH net-next 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port

[Michal Vokáč]

On 21.5.2018 17:17, Florian Fainelli wrote:


On 05/21/2018 06:28 AM, Michal Vokáč wrote:

When a port is brought up/down do not enable/disable only the TXMAC
but the RXMAC as well. This is essential for the CPU port to work.

Signed-off-by: Michal Vokáč 


Reviewed-by: Florian Fainelli 

Should this have:

Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")?


Yes, I think it is a good idea to can add this. Will do it in v2.

Thanks,
Michal

Re: [PATCH net-next 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port

[Florian Fainelli]

On 05/21/2018 06:28 AM, Michal Vokáč wrote:
> When a port is brought up/down do not enable/disable only the TXMAC
> but the RXMAC as well. This is essential for the CPU port to work.
> 
> Signed-off-by: Michal Vokáč 

Reviewed-by: Florian Fainelli 

Should this have:

Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")?
-- 
Florian

Re: [PATCH net-next 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port

[Florian Fainelli]

On 05/21/2018 06:28 AM, Michal Vokáč wrote:
> When a port is brought up/down do not enable/disable only the TXMAC
> but the RXMAC as well. This is essential for the CPU port to work.
> 
> Signed-off-by: Michal Vokáč 

Reviewed-by: Florian Fainelli 

Should this have:

Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")?
-- 
Florian

Re: [PATCH net-next 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port

[Andrew Lunn]

On Mon, May 21, 2018 at 03:28:09PM +0200, Michal Vokáč wrote:
> When a port is brought up/down do not enable/disable only the TXMAC
> but the RXMAC as well. This is essential for the CPU port to work.
> 
> Signed-off-by: Michal Vokáč 

Reviewed-by: Andrew Lunn 

Andrew

Re: [PATCH net-next 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port

[Andrew Lunn]

On Mon, May 21, 2018 at 03:28:09PM +0200, Michal Vokáč wrote:
> When a port is brought up/down do not enable/disable only the TXMAC
> but the RXMAC as well. This is essential for the CPU port to work.
> 
> Signed-off-by: Michal Vokáč 

Reviewed-by: Andrew Lunn 

Andrew

[PATCH net-next 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port

[Michal Vokáč]

When a port is brought up/down do not enable/disable only the TXMAC
but the RXMAC as well. This is essential for the CPU port to work.

Signed-off-by: Michal Vokáč 
---
 drivers/net/dsa/qca8k.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index 6a3ffb2..0d224f3 100644
--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -516,7 +516,7 @@ qca8k_set_pad_ctrl(struct qca8k_priv *priv, int port, int 
mode)
 static void
 qca8k_port_set_status(struct qca8k_priv *priv, int port, int enable)
 {
-   u32 mask = QCA8K_PORT_STATUS_TXMAC;
+   u32 mask = QCA8K_PORT_STATUS_TXMAC | QCA8K_PORT_STATUS_RXMAC;
 
pr_debug("qca: port %i set status %i\n", port, enable);
 
-- 
2.1.4

[PATCH net-next 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port

[Michal Vokáč]

When a port is brought up/down do not enable/disable only the TXMAC
but the RXMAC as well. This is essential for the CPU port to work.

Signed-off-by: Michal Vokáč 
---
 drivers/net/dsa/qca8k.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index 6a3ffb2..0d224f3 100644
--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -516,7 +516,7 @@ qca8k_set_pad_ctrl(struct qca8k_priv *priv, int port, int 
mode)
 static void
 qca8k_port_set_status(struct qca8k_priv *priv, int port, int enable)
 {
-   u32 mask = QCA8K_PORT_STATUS_TXMAC;
+   u32 mask = QCA8K_PORT_STATUS_TXMAC | QCA8K_PORT_STATUS_RXMAC;
 
pr_debug("qca: port %i set status %i\n", port, enable);
 
-- 
2.1.4