Re: [PATCH net-next v2] net: natsemi: Remove set but not used variable

2020-09-21 Thread David Miller
From: Zheng Yongjun 
Date: Mon, 21 Sep 2020 20:18:41 +0800

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/ethernet/natsemi/ns83820.c: In function 
> ns83820_get_link_ksettings:
> drivers/net/ethernet/natsemi/ns83820.c:1210:11: warning: variable ‘tanar’ set 
> but not used [-Wunused-but-set-variable]
> 
> `tanar` is never used, so remove it.
> 
> Signed-off-by: Zheng Yongjun 

Applied.


[PATCH net-next v2] net: natsemi: Remove set but not used variable

2020-09-21 Thread Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/natsemi/ns83820.c: In function ns83820_get_link_ksettings:
drivers/net/ethernet/natsemi/ns83820.c:1210:11: warning: variable ‘tanar’ set 
but not used [-Wunused-but-set-variable]

`tanar` is never used, so remove it.

Signed-off-by: Zheng Yongjun 
---
 drivers/net/ethernet/natsemi/ns83820.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/natsemi/ns83820.c 
b/drivers/net/ethernet/natsemi/ns83820.c
index 8e24c7acf79b..144feb2d2622 100644
--- a/drivers/net/ethernet/natsemi/ns83820.c
+++ b/drivers/net/ethernet/natsemi/ns83820.c
@@ -1207,7 +1207,7 @@ static int ns83820_get_link_ksettings(struct net_device 
*ndev,
  struct ethtool_link_ksettings *cmd)
 {
struct ns83820 *dev = PRIV(ndev);
-   u32 cfg, tanar, tbicr;
+   u32 cfg, tbicr;
int fullduplex   = 0;
u32 supported;
 
@@ -1226,8 +1226,8 @@ static int ns83820_get_link_ksettings(struct net_device 
*ndev,
 
/* read current configuration */
cfg   = readl(dev->base + CFG) ^ SPDSTS_POLARITY;
-   tanar = readl(dev->base + TANAR);
+   readl(dev->base + TANAR);
tbicr = readl(dev->base + TBICR);
 
fullduplex = (cfg & CFG_DUPSTS) ? 1 : 0;
 
-- 
2.17.1