Re: [PATCH net-next v2 1/6] bcm63xx_enet: batch process rx path

2020-12-28 Thread Florian Fainelli 



On 12/24/2020 6:24 AM, Sieng Piaw Liew wrote:
> Use netif_receive_skb_list to batch process rx skb.
> Tested on BCM6328 320 MHz using iperf3 -M 512, increasing performance
> by 12.5%.
> 
> Before:
> [ ID] Interval   Transfer Bandwidth   Retr
> [  4]   0.00-30.00  sec   120 MBytes  33.7 Mbits/sec  277 sender
> [  4]   0.00-30.00  sec   120 MBytes  33.5 Mbits/secreceiver
> 
> After:
> [ ID] Interval   Transfer Bandwidth   Retr
> [  4]   0.00-30.00  sec   136 MBytes  37.9 Mbits/sec  203 sender
> [  4]   0.00-30.00  sec   135 MBytes  37.7 Mbits/secreceiver
> 
> Signed-off-by: Sieng Piaw Liew 

Acked-by: Florian Fainelli 
-- 
Florian

[PATCH net-next v2 1/6] bcm63xx_enet: batch process rx path

2020-12-24 Thread Sieng Piaw Liew 
Use netif_receive_skb_list to batch process rx skb.
Tested on BCM6328 320 MHz using iperf3 -M 512, increasing performance
by 12.5%.

Before:
[ ID] Interval   Transfer Bandwidth   Retr
[  4]   0.00-30.00  sec   120 MBytes  33.7 Mbits/sec  277 sender
[  4]   0.00-30.00  sec   120 MBytes  33.5 Mbits/secreceiver

After:
[ ID] Interval   Transfer Bandwidth   Retr
[  4]   0.00-30.00  sec   136 MBytes  37.9 Mbits/sec  203 sender
[  4]   0.00-30.00  sec   135 MBytes  37.7 Mbits/secreceiver

Signed-off-by: Sieng Piaw Liew 
---
 drivers/net/ethernet/broadcom/bcm63xx_enet.c | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c 
b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
index 916824cca3fd..b82b7805c36a 100644
--- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
@@ -297,10 +297,12 @@ static void bcm_enet_refill_rx_timer(struct timer_list *t)
 static int bcm_enet_receive_queue(struct net_device *dev, int budget)
 {
struct bcm_enet_priv *priv;
+   struct list_head rx_list;
struct device *kdev;
int processed;
 
priv = netdev_priv(dev);
+   INIT_LIST_HEAD(_list);
kdev = >pdev->dev;
processed = 0;
 
@@ -391,10 +393,12 @@ static int bcm_enet_receive_queue(struct net_device *dev, 
int budget)
skb->protocol = eth_type_trans(skb, dev);
dev->stats.rx_packets++;
dev->stats.rx_bytes += len;
-   netif_receive_skb(skb);
+   list_add_tail(>list, _list);
 
} while (--budget > 0);
 
+   netif_receive_skb_list(_list);
+
if (processed || !priv->rx_desc_count) {
bcm_enet_refill_rx(dev);
 
-- 
2.17.1