Re: [PATCH net 1/1] stmmac: intel: Fix kernel panic on pci probe

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 17:32:28 +0800 Wong Vee Khee wrote:
> The commit "stmmac: intel: Adding ref clock 1us tic for LPI cntr"
> introduced a regression which leads to the kernel panic duing loading
> of the dwmac_intel module.
> 
> Move the code block after pci resources is obtained.
> 
> Fixes: b4c5f83ae3f3 ("stmmac: intel: Adding ref clock 1us tic for LPI cntr")
> Cc: Voon Weifeng 
> Signed-off-by: Wong Vee Khee 

Applied, thanks!


[PATCH net 1/1] stmmac: intel: Fix kernel panic on pci probe

2020-10-29 Thread Wong Vee Khee
The commit "stmmac: intel: Adding ref clock 1us tic for LPI cntr"
introduced a regression which leads to the kernel panic duing loading
of the dwmac_intel module.

Move the code block after pci resources is obtained.

Fixes: b4c5f83ae3f3 ("stmmac: intel: Adding ref clock 1us tic for LPI cntr")
Cc: Voon Weifeng 
Signed-off-by: Wong Vee Khee 
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c 
b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
index b6e5e3e36b63..81ee0a071b4e 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
@@ -625,13 +625,6 @@ static int intel_eth_pci_probe(struct pci_dev *pdev,
if (ret)
return ret;
 
-   if (plat->eee_usecs_rate > 0) {
-   u32 tx_lpi_usec;
-
-   tx_lpi_usec = (plat->eee_usecs_rate / 100) - 1;
-   writel(tx_lpi_usec, res.addr + GMAC_1US_TIC_COUNTER);
-   }
-
ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
if (ret < 0)
return ret;
@@ -641,6 +634,13 @@ static int intel_eth_pci_probe(struct pci_dev *pdev,
res.wol_irq = pci_irq_vector(pdev, 0);
res.irq = pci_irq_vector(pdev, 0);
 
+   if (plat->eee_usecs_rate > 0) {
+   u32 tx_lpi_usec;
+
+   tx_lpi_usec = (plat->eee_usecs_rate / 100) - 1;
+   writel(tx_lpi_usec, res.addr + GMAC_1US_TIC_COUNTER);
+   }
+
ret = stmmac_dvr_probe(>dev, plat, );
if (ret) {
pci_free_irq_vectors(pdev);
-- 
2.17.0