Re: [PATCH next v2 04/17] dt-bindings: phy: mediatek: dsi-phy: add optional clock-names

2021-01-24 Thread Chunfeng Yun
On Sat, 2021-01-23 at 08:18 +0800, Chun-Kuang Hu wrote:
> Hi, Chunfeng:
> 
> Chunfeng Yun  於 2021年1月22日 週五 下午8:04寫道:
> >
> > Add an optional "clock-names" property, it's not used to get the clock,
> > but some DTS files (e.g. mt8183) provide it.
> 
> I think the logic is that we define property in binding document
> first, and then write it in device tree. If a property does not exist
> in binding document, we should not write it in device tree. So let's
> drop this patch and remove clock-names in mt8183.dtsi.
Ok, It's better to remove unnecessary property.

> 
> Regards,
> Chun-Kuang.
> 
> >
> > Cc: Chun-Kuang Hu 
> > Cc: Philipp Zabel 
> > Signed-off-by: Chunfeng Yun 
> > ---
> > v2: new patch separated from [3/15] suggested by CK
> > ---
> >  Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml | 4 
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml 
> > b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> > index 6e4d795f9b02..af6e554c5b69 100644
> > --- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> > @@ -35,6 +35,10 @@ properties:
> >  items:
> >- description: PLL reference clock
> >
> > +  clock-names:
> > +items:
> > +  - const: ref
> > +
> >clock-output-names:
> >  maxItems: 1
> >
> > --
> > 2.18.0
> > ___
> > Linux-mediatek mailing list
> > linux-media...@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek



Re: [PATCH next v2 04/17] dt-bindings: phy: mediatek: dsi-phy: add optional clock-names

2021-01-22 Thread Chun-Kuang Hu
Hi, Chunfeng:

Chunfeng Yun  於 2021年1月22日 週五 下午8:04寫道:
>
> Add an optional "clock-names" property, it's not used to get the clock,
> but some DTS files (e.g. mt8183) provide it.

I think the logic is that we define property in binding document
first, and then write it in device tree. If a property does not exist
in binding document, we should not write it in device tree. So let's
drop this patch and remove clock-names in mt8183.dtsi.

Regards,
Chun-Kuang.

>
> Cc: Chun-Kuang Hu 
> Cc: Philipp Zabel 
> Signed-off-by: Chunfeng Yun 
> ---
> v2: new patch separated from [3/15] suggested by CK
> ---
>  Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml | 4 
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml 
> b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> index 6e4d795f9b02..af6e554c5b69 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> @@ -35,6 +35,10 @@ properties:
>  items:
>- description: PLL reference clock
>
> +  clock-names:
> +items:
> +  - const: ref
> +
>clock-output-names:
>  maxItems: 1
>
> --
> 2.18.0
> ___
> Linux-mediatek mailing list
> linux-media...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek


[PATCH next v2 04/17] dt-bindings: phy: mediatek: dsi-phy: add optional clock-names

2021-01-22 Thread Chunfeng Yun
Add an optional "clock-names" property, it's not used to get the clock,
but some DTS files (e.g. mt8183) provide it.

Cc: Chun-Kuang Hu 
Cc: Philipp Zabel 
Signed-off-by: Chunfeng Yun 
---
v2: new patch separated from [3/15] suggested by CK
---
 Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml | 4 
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml 
b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
index 6e4d795f9b02..af6e554c5b69 100644
--- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
@@ -35,6 +35,10 @@ properties:
 items:
   - description: PLL reference clock
 
+  clock-names:
+items:
+  - const: ref
+
   clock-output-names:
 maxItems: 1
 
-- 
2.18.0