Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x
On Fri, May 04, 2007 at 11:18:37PM +0400, Sergei Shtylyov wrote: > HPT36x chip don't seem to have the channel enable bits, > so prevent the IDE core from checking them... > > Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> Earlier this evening I reported that HPT366 was broken in 2.6.21. I confirm that this fixes it for me. Andries - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x
On Fri, May 04, 2007 at 11:18:37PM +0400, Sergei Shtylyov wrote: HPT36x chip don't seem to have the channel enable bits, so prevent the IDE core from checking them... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] Earlier this evening I reported that HPT366 was broken in 2.6.21. I confirm that this fixes it for me. Andries - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x
On Saturday 05 May 2007, Sergei Shtylyov wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > >>HPT36x chip don't seem to have the channel enable bits, so prevent the IDE > >>core > >>from checking them... > > >>Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> > > > applied > > I'm getting "403 Forbidden" trying to browse this patch (and > ide-cs-recognize-2gb-compactflash-from-transcend.patch as well). Should be fixed now - sorry for that. While at it I replaced mine version of "the hpt366: simplify UltraDMA filtering (take 2)" with the official one ;) and fixed my damn scripts to always do "chmod 644 pata-2.6/patches/*.patch" before pushing updates to kernel.org. Bart - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x
Hello. Bartlomiej Zolnierkiewicz wrote: HPT36x chip don't seem to have the channel enable bits, so prevent the IDE core from checking them... Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> applied I'm getting "403 Forbidden" trying to browse this patch (and ide-cs-recognize-2gb-compactflash-from-transcend.patch as well). MBR, Sergei - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x
On Friday 04 May 2007, Sergei Shtylyov wrote: > HPT36x chip don't seem to have the channel enable bits, so prevent the IDE > core > from checking them... > > Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x
On Friday 04 May 2007, Sergei Shtylyov wrote: HPT36x chip don't seem to have the channel enable bits, so prevent the IDE core from checking them... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x
Hello. Bartlomiej Zolnierkiewicz wrote: HPT36x chip don't seem to have the channel enable bits, so prevent the IDE core from checking them... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied I'm getting 403 Forbidden trying to browse this patch (and ide-cs-recognize-2gb-compactflash-from-transcend.patch as well). MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x
On Saturday 05 May 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: HPT36x chip don't seem to have the channel enable bits, so prevent the IDE core from checking them... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied I'm getting 403 Forbidden trying to browse this patch (and ide-cs-recognize-2gb-compactflash-from-transcend.patch as well). Should be fixed now - sorry for that. While at it I replaced mine version of the hpt366: simplify UltraDMA filtering (take 2) with the official one ;) and fixed my damn scripts to always do chmod 644 pata-2.6/patches/*.patch before pushing updates to kernel.org. Bart - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x
HPT36x chip don't seem to have the channel enable bits, so prevent the IDE core
from checking them...
Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]>
---
Michal, sorry for unintended breakage, please verify the patch... :-)
drivers/ide/pci/hpt366.c |7 ++-
1 files changed, 6 insertions(+), 1 deletion(-)
Index: linux-2.6/drivers/ide/pci/hpt366.c
===
--- linux-2.6.orig/drivers/ide/pci/hpt366.c
+++ linux-2.6/drivers/ide/pci/hpt366.c
@@ -1,5 +1,5 @@
/*
- * linux/drivers/ide/pci/hpt366.c Version 1.02Apr 18, 2007
+ * linux/drivers/ide/pci/hpt366.c Version 1.03May 4, 2007
*
* Copyright (C) 1999-2003 Andre Hedrick <[EMAIL PROTECTED]>
* Portions Copyright (C) 2001 Sun Microsystems, Inc.
@@ -1527,7 +1527,12 @@ static int __devinit init_setup_hpt366(s
if (rev > 2)
goto init_single;
+ /*
+* HPT36x chips are single channel and
+* do not seem to have the channel enable bit...
+*/
d->channels = 1;
+ d->enablebits[0].reg = 0;
if ((dev2 = pci_get_slot(dev->bus, dev->devfn + 1)) != NULL) {
u8 pin1 = 0, pin2 = 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x
HPT36x chip don't seem to have the channel enable bits, so prevent the IDE core
from checking them...
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
---
Michal, sorry for unintended breakage, please verify the patch... :-)
drivers/ide/pci/hpt366.c |7 ++-
1 files changed, 6 insertions(+), 1 deletion(-)
Index: linux-2.6/drivers/ide/pci/hpt366.c
===
--- linux-2.6.orig/drivers/ide/pci/hpt366.c
+++ linux-2.6/drivers/ide/pci/hpt366.c
@@ -1,5 +1,5 @@
/*
- * linux/drivers/ide/pci/hpt366.c Version 1.02Apr 18, 2007
+ * linux/drivers/ide/pci/hpt366.c Version 1.03May 4, 2007
*
* Copyright (C) 1999-2003 Andre Hedrick [EMAIL PROTECTED]
* Portions Copyright (C) 2001 Sun Microsystems, Inc.
@@ -1527,7 +1527,12 @@ static int __devinit init_setup_hpt366(s
if (rev 2)
goto init_single;
+ /*
+* HPT36x chips are single channel and
+* do not seem to have the channel enable bit...
+*/
d-channels = 1;
+ d-enablebits[0].reg = 0;
if ((dev2 = pci_get_slot(dev-bus, dev-devfn + 1)) != NULL) {
u8 pin1 = 0, pin2 = 0;
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
