Re: [PATCH resend 0/2] I2C: sis630: add sis964 support
On Fri, 28 Dec 2012 20:24:00 +0100, Amaury Decrême wrote: > On Tue, Dec 18, 2012 at 12:51:05PM +0100, Jean Delvare wrote: > > On Wed, 29 Aug 2012 03:35:13 +0200, Amaury Decrême wrote: > > > > I reviewed these two patches 2 months ago, but did not hear back from > > you since then. Do you plan to resubmit these patches with the > > improvements I suggested? I would hate to see your work time and mine > > wasted. > > I'm sorry I gave no news. I read your improvments with interests > when you sent it. > > I changed my job at the very same moment and didn't have a minute > until xmas season.. > It's getting a bit better and I hope to send a working solution > in early 2013 if the schedule is still ok. Yes, that would be OK. Thanks, -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH resend 0/2] I2C: sis630: add sis964 support
On Fri, 28 Dec 2012 20:24:00 +0100, Amaury Decrême wrote: On Tue, Dec 18, 2012 at 12:51:05PM +0100, Jean Delvare wrote: On Wed, 29 Aug 2012 03:35:13 +0200, Amaury Decrême wrote: I reviewed these two patches 2 months ago, but did not hear back from you since then. Do you plan to resubmit these patches with the improvements I suggested? I would hate to see your work time and mine wasted. I'm sorry I gave no news. I read your improvments with interests when you sent it. I changed my job at the very same moment and didn't have a minute until xmas season.. It's getting a bit better and I hope to send a working solution in early 2013 if the schedule is still ok. Yes, that would be OK. Thanks, -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH resend 0/2] I2C: sis630: add sis964 support
On Tue, Dec 18, 2012 at 12:51:05PM +0100, Jean Delvare wrote: > Hi Amaury, > > On Wed, 29 Aug 2012 03:35:13 +0200, Amaury Decrême wrote: > > I reviewed these two patches 2 months ago, but did not hear back from > you since then. Do you plan to resubmit these patches with the > improvements I suggested? I would hate to see your work time and mine > wasted. > > Thanks, > -- > Jean Delvare Hi Jean, I'm sorry I gave no news. I read your improvments with interests when you sent it. I changed my job at the very same moment and didn't have a minute until xmas season.. It's getting a bit better and I hope to send a working solution in early 2013 if the schedule is still ok. Best regards, season greetings. -- Amaury Decrême -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH resend 0/2] I2C: sis630: add sis964 support
On Tue, Dec 18, 2012 at 12:51:05PM +0100, Jean Delvare wrote: Hi Amaury, On Wed, 29 Aug 2012 03:35:13 +0200, Amaury Decrême wrote: I reviewed these two patches 2 months ago, but did not hear back from you since then. Do you plan to resubmit these patches with the improvements I suggested? I would hate to see your work time and mine wasted. Thanks, -- Jean Delvare Hi Jean, I'm sorry I gave no news. I read your improvments with interests when you sent it. I changed my job at the very same moment and didn't have a minute until xmas season.. It's getting a bit better and I hope to send a working solution in early 2013 if the schedule is still ok. Best regards, season greetings. -- Amaury Decrême -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH resend 0/2] I2C: sis630: add sis964 support
Hi Amaury, On Wed, 29 Aug 2012 03:35:13 +0200, Amaury Decrême wrote: > This serie of patches brings SIS964 support to i2c-sis630. > > The SiS datasheets have been used. > > The SIS964 isn't part of the SIS96X family and behaves differently. > For i2c, this array show the differences between sis630 and sis964. > +++---+ > || SIS630/730 | SIS964 | > +++---+ > | Clock | 14kHz/56kHz| 55.56kHz/27.78kHz | > | SMBus registers offset | 0x80 | 0xE0 | > | SMB_CNT| Bit 1 = Slave Busy | Bit 1 = Bus probe | > | SMB_COUNT | 4:0 bits | 5:0 bits | > +++---+ > > The other differences doesn't affect the functions provided by the original > i2c-sis630 driver. > > The first patch is mandatory as it adds supports for SIS964 bus. > The second patch is optional. It depends on the first patch. > > Amaury Decrême (2): > I2C: sis630: sis964 bus > I2C: sis630: Cleaning and cosmetics > > Documentation/i2c/busses/i2c-sis630 | 17 +- > drivers/i2c/busses/Kconfig |4 +- > drivers/i2c/busses/i2c-sis630.c | 445 > +-- > 3 files changed, 278 insertions(+), 188 deletions(-) I reviewed these two patches 2 months ago, but did not hear back from you since then. Do you plan to resubmit these patches with the improvements I suggested? I would hate to see your work time and mine wasted. Thanks, -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH resend 0/2] I2C: sis630: add sis964 support
Hi Amaury, On Wed, 29 Aug 2012 03:35:13 +0200, Amaury Decrême wrote: This serie of patches brings SIS964 support to i2c-sis630. The SiS datasheets have been used. The SIS964 isn't part of the SIS96X family and behaves differently. For i2c, this array show the differences between sis630 and sis964. +++---+ || SIS630/730 | SIS964 | +++---+ | Clock | 14kHz/56kHz| 55.56kHz/27.78kHz | | SMBus registers offset | 0x80 | 0xE0 | | SMB_CNT| Bit 1 = Slave Busy | Bit 1 = Bus probe | | SMB_COUNT | 4:0 bits | 5:0 bits | +++---+ The other differences doesn't affect the functions provided by the original i2c-sis630 driver. The first patch is mandatory as it adds supports for SIS964 bus. The second patch is optional. It depends on the first patch. Amaury Decrême (2): I2C: sis630: sis964 bus I2C: sis630: Cleaning and cosmetics Documentation/i2c/busses/i2c-sis630 | 17 +- drivers/i2c/busses/Kconfig |4 +- drivers/i2c/busses/i2c-sis630.c | 445 +-- 3 files changed, 278 insertions(+), 188 deletions(-) I reviewed these two patches 2 months ago, but did not hear back from you since then. Do you plan to resubmit these patches with the improvements I suggested? I would hate to see your work time and mine wasted. Thanks, -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
