Re: [PATCH review for 4.9 31/50] xen/manage: correct return value check on xenbus_scanf()

2017-10-23 Thread Levin, Alexander (Sasha Levin) 
On Tue, Oct 10, 2017 at 08:49:13AM -0400, Boris Ostrovsky wrote:
>On 10/07/2017 06:36 PM, Levin, Alexander (Sasha Levin) wrote:
>> From: Jan Beulich 
>>
>> [ Upstream commit 4fed1b125eb6252bde478665fc05d4819f774fa8 ]
>>
>> A negative return value indicates an error; in fact the function at
>> present won't ever return zero.
>>
>> Signed-off-by: Jan Beulich 
>> Reviewed-by: Juergen Gross 
>> Signed-off-by: Boris Ostrovsky 
>> Signed-off-by: Sasha Levin 
>
>This patch will cause a warning to be printed. Please pull commit
>4e93b64 ("xen: don't print error message in case of missing Xenstore
>entry") as well.

Added, thanks Boris.

-- 

Thanks,
Sasha

Re: [PATCH review for 4.9 31/50] xen/manage: correct return value check on xenbus_scanf()

2017-10-23 Thread Levin, Alexander (Sasha Levin) 
On Tue, Oct 10, 2017 at 08:49:13AM -0400, Boris Ostrovsky wrote:
>On 10/07/2017 06:36 PM, Levin, Alexander (Sasha Levin) wrote:
>> From: Jan Beulich 
>>
>> [ Upstream commit 4fed1b125eb6252bde478665fc05d4819f774fa8 ]
>>
>> A negative return value indicates an error; in fact the function at
>> present won't ever return zero.
>>
>> Signed-off-by: Jan Beulich 
>> Reviewed-by: Juergen Gross 
>> Signed-off-by: Boris Ostrovsky 
>> Signed-off-by: Sasha Levin 
>
>This patch will cause a warning to be printed. Please pull commit
>4e93b64 ("xen: don't print error message in case of missing Xenstore
>entry") as well.

Added, thanks Boris.

-- 

Thanks,
Sasha

Re: [PATCH review for 4.9 31/50] xen/manage: correct return value check on xenbus_scanf()

2017-10-10 Thread Boris Ostrovsky 
On 10/07/2017 06:36 PM, Levin, Alexander (Sasha Levin) wrote:
> From: Jan Beulich 
>
> [ Upstream commit 4fed1b125eb6252bde478665fc05d4819f774fa8 ]
>
> A negative return value indicates an error; in fact the function at
> present won't ever return zero.
>
> Signed-off-by: Jan Beulich 
> Reviewed-by: Juergen Gross 
> Signed-off-by: Boris Ostrovsky 
> Signed-off-by: Sasha Levin 

This patch will cause a warning to be printed. Please pull commit
4e93b64 ("xen: don't print error message in case of missing Xenstore
entry") as well.

Thanks.
-boris

> ---
>  drivers/xen/manage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
> index 26e5e8507f03..357a8db859c9 100644
> --- a/drivers/xen/manage.c
> +++ b/drivers/xen/manage.c
> @@ -277,7 +277,7 @@ static void sysrq_handler(struct xenbus_watch *watch, 
> const char **vec,
>   err = xenbus_transaction_start();
>   if (err)
>   return;
> - if (!xenbus_scanf(xbt, "control", "sysrq", "%c", _key)) {
> + if (xenbus_scanf(xbt, "control", "sysrq", "%c", _key) < 0) {
>   pr_err("Unable to read sysrq code in control/sysrq\n");
>   xenbus_transaction_end(xbt, 1);
>   return;

Re: [PATCH review for 4.9 31/50] xen/manage: correct return value check on xenbus_scanf()

2017-10-10 Thread Boris Ostrovsky 
On 10/07/2017 06:36 PM, Levin, Alexander (Sasha Levin) wrote:
> From: Jan Beulich 
>
> [ Upstream commit 4fed1b125eb6252bde478665fc05d4819f774fa8 ]
>
> A negative return value indicates an error; in fact the function at
> present won't ever return zero.
>
> Signed-off-by: Jan Beulich 
> Reviewed-by: Juergen Gross 
> Signed-off-by: Boris Ostrovsky 
> Signed-off-by: Sasha Levin 

This patch will cause a warning to be printed. Please pull commit
4e93b64 ("xen: don't print error message in case of missing Xenstore
entry") as well.

Thanks.
-boris

> ---
>  drivers/xen/manage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
> index 26e5e8507f03..357a8db859c9 100644
> --- a/drivers/xen/manage.c
> +++ b/drivers/xen/manage.c
> @@ -277,7 +277,7 @@ static void sysrq_handler(struct xenbus_watch *watch, 
> const char **vec,
>   err = xenbus_transaction_start();
>   if (err)
>   return;
> - if (!xenbus_scanf(xbt, "control", "sysrq", "%c", _key)) {
> + if (xenbus_scanf(xbt, "control", "sysrq", "%c", _key) < 0) {
>   pr_err("Unable to read sysrq code in control/sysrq\n");
>   xenbus_transaction_end(xbt, 1);
>   return;

[PATCH review for 4.9 31/50] xen/manage: correct return value check on xenbus_scanf()

2017-10-07 Thread Levin, Alexander (Sasha Levin) 
From: Jan Beulich 

[ Upstream commit 4fed1b125eb6252bde478665fc05d4819f774fa8 ]

A negative return value indicates an error; in fact the function at
present won't ever return zero.

Signed-off-by: Jan Beulich 
Reviewed-by: Juergen Gross 
Signed-off-by: Boris Ostrovsky 
Signed-off-by: Sasha Levin 
---
 drivers/xen/manage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
index 26e5e8507f03..357a8db859c9 100644
--- a/drivers/xen/manage.c
+++ b/drivers/xen/manage.c
@@ -277,7 +277,7 @@ static void sysrq_handler(struct xenbus_watch *watch, const 
char **vec,
err = xenbus_transaction_start();
if (err)
return;
-   if (!xenbus_scanf(xbt, "control", "sysrq", "%c", _key)) {
+   if (xenbus_scanf(xbt, "control", "sysrq", "%c", _key) < 0) {
pr_err("Unable to read sysrq code in control/sysrq\n");
xenbus_transaction_end(xbt, 1);
return;
-- 
2.11.0

[PATCH review for 4.9 31/50] xen/manage: correct return value check on xenbus_scanf()

2017-10-07 Thread Levin, Alexander (Sasha Levin) 
From: Jan Beulich 

[ Upstream commit 4fed1b125eb6252bde478665fc05d4819f774fa8 ]

A negative return value indicates an error; in fact the function at
present won't ever return zero.

Signed-off-by: Jan Beulich 
Reviewed-by: Juergen Gross 
Signed-off-by: Boris Ostrovsky 
Signed-off-by: Sasha Levin 
---
 drivers/xen/manage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
index 26e5e8507f03..357a8db859c9 100644
--- a/drivers/xen/manage.c
+++ b/drivers/xen/manage.c
@@ -277,7 +277,7 @@ static void sysrq_handler(struct xenbus_watch *watch, const 
char **vec,
err = xenbus_transaction_start();
if (err)
return;
-   if (!xenbus_scanf(xbt, "control", "sysrq", "%c", _key)) {
+   if (xenbus_scanf(xbt, "control", "sysrq", "%c", _key) < 0) {
pr_err("Unable to read sysrq code in control/sysrq\n");
xenbus_transaction_end(xbt, 1);
return;
-- 
2.11.0