Re: [PATCH v1] Add support for MediaTek regulator vibrator driver
On Thu 2020-05-07 22:45:35, Jacek Anaszewski wrote: > Hi Pavel, > > On 5/7/20 7:45 PM, Pavel Machek wrote: > > Hi! > > > > > This patchset add regulator vibrator driver for MTK Soc. The driver > > > controls vibrator through regulator's enable and disable. > > > > We'd prefer not to have vibrators in led subsystem. > > > > > > > > Xing Zhang (3): > > >dt-bindings: add regulator vibrator documentation > > >arm64: mediatek: Add regulator vibrator support > > >Vibrator: Add regulator vibrator driver > > > > > > .../bindings/leds/regulator-vibrator.txt | 39 ++ > > > arch/arm64/configs/defconfig | 1 + > > > drivers/leds/Kconfig | 10 + > > > drivers/leds/Makefile | 1 + > > > drivers/leds/regulator-vibrator.c | 450 ++ > > > > OTOH, connecting LED to regulator might make some sense. I can take the > > driver with > > vibrator functionality stripped, provided it is named the usual way... > > We already had an attempt of solving this in more generic way [0], > but you opposed then [1]. Just for the record. That's something different. led-regulator.c might be acceptable. Special code to support vibrator quirks... not so much. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: PGP signature
Re: [PATCH v1] Add support for MediaTek regulator vibrator driver
Hi Pavel, On 5/7/20 7:45 PM, Pavel Machek wrote: Hi! This patchset add regulator vibrator driver for MTK Soc. The driver controls vibrator through regulator's enable and disable. We'd prefer not to have vibrators in led subsystem. Xing Zhang (3): dt-bindings: add regulator vibrator documentation arm64: mediatek: Add regulator vibrator support Vibrator: Add regulator vibrator driver .../bindings/leds/regulator-vibrator.txt | 39 ++ arch/arm64/configs/defconfig | 1 + drivers/leds/Kconfig | 10 + drivers/leds/Makefile | 1 + drivers/leds/regulator-vibrator.c | 450 ++ OTOH, connecting LED to regulator might make some sense. I can take the driver with vibrator functionality stripped, provided it is named the usual way... We already had an attempt of solving this in more generic way [0], but you opposed then [1]. Just for the record. [0] https://lore.kernel.org/linux-leds/20170913175400.42744-1-dtw...@google.com/ [1] https://lore.kernel.org/linux-leds/20170914205804.GA24339@amd/ -- Best regards, Jacek Anaszewski
Re: [PATCH v1] Add support for MediaTek regulator vibrator driver
Hi! > This patchset add regulator vibrator driver for MTK Soc. The driver > controls vibrator through regulator's enable and disable. We'd prefer not to have vibrators in led subsystem. > > Xing Zhang (3): > dt-bindings: add regulator vibrator documentation > arm64: mediatek: Add regulator vibrator support > Vibrator: Add regulator vibrator driver > > .../bindings/leds/regulator-vibrator.txt | 39 ++ > arch/arm64/configs/defconfig | 1 + > drivers/leds/Kconfig | 10 + > drivers/leds/Makefile | 1 + > drivers/leds/regulator-vibrator.c | 450 ++ OTOH, connecting LED to regulator might make some sense. I can take the driver with vibrator functionality stripped, provided it is named the usual way... Best regards, Pavel
[PATCH v1] Add support for MediaTek regulator vibrator driver
This patchset add regulator vibrator driver for MTK Soc. The driver controls vibrator through regulator's enable and disable. Xing Zhang (3): dt-bindings: add regulator vibrator documentation arm64: mediatek: Add regulator vibrator support Vibrator: Add regulator vibrator driver .../bindings/leds/regulator-vibrator.txt | 39 ++ arch/arm64/configs/defconfig | 1 + drivers/leds/Kconfig | 10 + drivers/leds/Makefile | 1 + drivers/leds/regulator-vibrator.c | 450 ++ 5 files changed, 501 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/regulator-vibrator.txt create mode 100644 drivers/leds/regulator-vibrator.c
