Re: [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support
On Wed, Aug 26, 2020 at 12:18:04PM +0300, Andy Shevchenko wrote: > On Wed, Aug 26, 2020 at 10:51:37AM +0800, Ramuthevar, Vadivel MuruganX wrote: > > On 25/8/2020 4:19 pm, Heikki Krogerus wrote: > > > On Wed, Aug 19, 2020 at 04:45:38PM +0800, Ramuthevar, Vadivel MuruganX > > > wrote: > > > > On 19/8/2020 3:55 pm, Andy Shevchenko wrote: > > > > > On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX > > > > > wrote: > > > > > > On 18/8/2020 4:40 pm, Andy Shevchenko wrote: > > > > > > > On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel > > > > > > > MuruganX wrote: > > > > > > > > USB external connector chip PTN5150 used on the Intel LGM SoC > > > > > > > > boards to detect the USB type and connection. > > > > > > > Internally I meant you can send cleanups, but couple of patches > > > > > > > here are the > > > > > > > features and were still under discussion... But here we are. > > > > > > > > > > > > you mean asking us to implement the Heikki suggested as below.. > > > > > > > > > > > > Heikki Krogerus: register the port and the partner attached to it > > > > > > with > > > > > > the USB Type-C connector class in the driver. Is my understaanding > > > > > > right? if not, please explain it. Thanks! > > > > > > > > > > When you mention somebody, don't forget to Cc them (now done by me). > > > > Sure, Thank you > > > > > > So the patches 1-5 are fine. The rest needs to be rewritten. > > Already Krzysztof submitted all the patches and got approved, so we started > > sending only one patch which support to Intel LGM SoC based boards, Thanks! > > I'm not sure what you meant by above. > > Krzysztof suggested you to squash all first patches into 1 (or two) and he > approves it. What you have to do is follow his advise and send v2 where it > will > be one (or two) patch with his tag attached. > > Krzysztof, is it correct what I'm saying? Yes, correct. I guess Vadivel mentioned my patchset which was sent some days before and recently got applied into extcon tree. I think there is no misunderstanding here. Best regards, Krzysztof
Re: [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support
Hi Andy, On 26/8/2020 5:18 pm, Andy Shevchenko wrote: On Wed, Aug 26, 2020 at 10:51:37AM +0800, Ramuthevar, Vadivel MuruganX wrote: On 25/8/2020 4:19 pm, Heikki Krogerus wrote: On Wed, Aug 19, 2020 at 04:45:38PM +0800, Ramuthevar, Vadivel MuruganX wrote: On 19/8/2020 3:55 pm, Andy Shevchenko wrote: On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX wrote: On 18/8/2020 4:40 pm, Andy Shevchenko wrote: On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote: USB external connector chip PTN5150 used on the Intel LGM SoC boards to detect the USB type and connection. Internally I meant you can send cleanups, but couple of patches here are the features and were still under discussion... But here we are. you mean asking us to implement the Heikki suggested as below.. Heikki Krogerus: register the port and the partner attached to it with the USB Type-C connector class in the driver. Is my understaanding right? if not, please explain it. Thanks! When you mention somebody, don't forget to Cc them (now done by me). Sure, Thank you So the patches 1-5 are fine. The rest needs to be rewritten. Already Krzysztof submitted all the patches and got approved, so we started sending only one patch which support to Intel LGM SoC based boards, Thanks! I'm not sure what you meant by above. Krzysztof suggested you to squash all first patches into 1 (or two) and he approves it. What you have to do is follow his advise and send v2 where it will be one (or two) patch with his tag attached. Yes, you're right, the above discussion was before Krzysztof reviewed my patches, sure will follow his advise, thanks! Regards Vadivel Krzysztof, is it correct what I'm saying?
Re: [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support
On Wed, Aug 26, 2020 at 10:51:37AM +0800, Ramuthevar, Vadivel MuruganX wrote: > On 25/8/2020 4:19 pm, Heikki Krogerus wrote: > > On Wed, Aug 19, 2020 at 04:45:38PM +0800, Ramuthevar, Vadivel MuruganX > > wrote: > > > On 19/8/2020 3:55 pm, Andy Shevchenko wrote: > > > > On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX > > > > wrote: > > > > > On 18/8/2020 4:40 pm, Andy Shevchenko wrote: > > > > > > On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel > > > > > > MuruganX wrote: > > > > > > > USB external connector chip PTN5150 used on the Intel LGM SoC > > > > > > > boards to detect the USB type and connection. > > > > > > Internally I meant you can send cleanups, but couple of patches > > > > > > here are the > > > > > > features and were still under discussion... But here we are. > > > > > > > > > > you mean asking us to implement the Heikki suggested as below.. > > > > > > > > > > Heikki Krogerus: register the port and the partner attached to it with > > > > > the USB Type-C connector class in the driver. Is my understaanding > > > > > right? if not, please explain it. Thanks! > > > > > > > > When you mention somebody, don't forget to Cc them (now done by me). > > > Sure, Thank you > > > > So the patches 1-5 are fine. The rest needs to be rewritten. > Already Krzysztof submitted all the patches and got approved, so we started > sending only one patch which support to Intel LGM SoC based boards, Thanks! I'm not sure what you meant by above. Krzysztof suggested you to squash all first patches into 1 (or two) and he approves it. What you have to do is follow his advise and send v2 where it will be one (or two) patch with his tag attached. Krzysztof, is it correct what I'm saying? -- With Best Regards, Andy Shevchenko
Re: [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support
Hi Heikki, Thank you very much for the review comment... On 25/8/2020 4:19 pm, Heikki Krogerus wrote: On Wed, Aug 19, 2020 at 04:45:38PM +0800, Ramuthevar, Vadivel MuruganX wrote: Hi Andy, On 19/8/2020 3:55 pm, Andy Shevchenko wrote: On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX wrote: On 18/8/2020 4:40 pm, Andy Shevchenko wrote: On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote: USB external connector chip PTN5150 used on the Intel LGM SoC boards to detect the USB type and connection. Internally I meant you can send cleanups, but couple of patches here are the features and were still under discussion... But here we are. you mean asking us to implement the Heikki suggested as below.. Heikki Krogerus: register the port and the partner attached to it with the USB Type-C connector class in the driver. Is my understaanding right? if not, please explain it. Thanks! When you mention somebody, don't forget to Cc them (now done by me). Sure, Thank you So the patches 1-5 are fine. The rest needs to be rewritten. Already Krzysztof submitted all the patches and got approved, so we started sending only one patch which support to Intel LGM SoC based boards, Thanks! Regards Vadivel thanks,
Re: [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support
On Wed, Aug 19, 2020 at 04:45:38PM +0800, Ramuthevar, Vadivel MuruganX wrote: > Hi Andy, > > On 19/8/2020 3:55 pm, Andy Shevchenko wrote: > > On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX > > wrote: > > > On 18/8/2020 4:40 pm, Andy Shevchenko wrote: > > > > On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX > > > > wrote: > > > > > USB external connector chip PTN5150 used on the Intel LGM SoC > > > > > boards to detect the USB type and connection. > > > > Internally I meant you can send cleanups, but couple of patches here > > > > are the > > > > features and were still under discussion... But here we are. > > > > > > you mean asking us to implement the Heikki suggested as below.. > > > > > > Heikki Krogerus: register the port and the partner attached to it with > > > the USB Type-C connector class in the driver. Is my understaanding > > > right? if not, please explain it. Thanks! > > > > When you mention somebody, don't forget to Cc them (now done by me). > Sure, Thank you So the patches 1-5 are fine. The rest needs to be rewritten. thanks, -- heikki
Re: [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support
Hi Andy, On 19/8/2020 3:55 pm, Andy Shevchenko wrote: On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX wrote: On 18/8/2020 4:40 pm, Andy Shevchenko wrote: On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote: USB external connector chip PTN5150 used on the Intel LGM SoC boards to detect the USB type and connection. Internally I meant you can send cleanups, but couple of patches here are the features and were still under discussion... But here we are. you mean asking us to implement the Heikki suggested as below.. Heikki Krogerus: register the port and the partner attached to it with the USB Type-C connector class in the driver. Is my understaanding right? if not, please explain it. Thanks! When you mention somebody, don't forget to Cc them (now done by me). Sure, Thank you Regards Vadivel
Re: [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support
On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX wrote: > On 18/8/2020 4:40 pm, Andy Shevchenko wrote: > > On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote: > >> USB external connector chip PTN5150 used on the Intel LGM SoC > >> boards to detect the USB type and connection. > > Internally I meant you can send cleanups, but couple of patches here are the > > features and were still under discussion... But here we are. > > you mean asking us to implement the Heikki suggested as below.. > > Heikki Krogerus: register the port and the partner attached to it with > the USB Type-C connector class in the driver. Is my understaanding > right? if not, please explain it. Thanks! When you mention somebody, don't forget to Cc them (now done by me). -- With Best Regards, Andy Shevchenko
Re: [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support
Hi Andy, On 18/8/2020 4:40 pm, Andy Shevchenko wrote: On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote: USB external connector chip PTN5150 used on the Intel LGM SoC boards to detect the USB type and connection. Internally I meant you can send cleanups, but couple of patches here are the features and were still under discussion... But here we are. you mean asking us to implement the Heikki suggested as below.. Heikki Krogerus: register the port and the partner attached to it with the USB Type-C connector class in the driver. Is my understaanding right? if not, please explain it. Thanks! Regards Vadivel
Re: [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support
On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote: > USB external connector chip PTN5150 used on the Intel LGM SoC > boards to detect the USB type and connection. Internally I meant you can send cleanups, but couple of patches here are the features and were still under discussion... But here we are. > --- > v1: > - Initial version > > Ramuthevar Vadivel Murugan (9): > extcon: extcon-ptn5150: Switch to GENMASK() for vendor and device ID's > extcon: extcon-ptn5150: Switch to GENMASK() for VBUS detection macro > extcon: extcon-ptn5150: Switch to BIT() macro for cable attach > extcon: extcon-ptn5150: Switch to BIT() for cable detach macro > extcon: extcon-ptn5150: Switch to GENMASK() for port attachment macro > extcon: extcon-ptn5150: Set and get the VBUS and POLARITY property > state > extcon: extcon-ptn5150: Add USB debug accessory support > extcon: extcon-ptn5150: Add USB analog audio accessory support > extcon: extcon-ptn5150: Remove unused variable and extra space > > drivers/extcon/extcon-ptn5150.c | 135 > > 1 file changed, 82 insertions(+), 53 deletions(-) > > -- > 2.11.0 > -- With Best Regards, Andy Shevchenko
[PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support
USB external connector chip PTN5150 used on the Intel LGM SoC boards to detect the USB type and connection. --- v1: - Initial version Ramuthevar Vadivel Murugan (9): extcon: extcon-ptn5150: Switch to GENMASK() for vendor and device ID's extcon: extcon-ptn5150: Switch to GENMASK() for VBUS detection macro extcon: extcon-ptn5150: Switch to BIT() macro for cable attach extcon: extcon-ptn5150: Switch to BIT() for cable detach macro extcon: extcon-ptn5150: Switch to GENMASK() for port attachment macro extcon: extcon-ptn5150: Set and get the VBUS and POLARITY property state extcon: extcon-ptn5150: Add USB debug accessory support extcon: extcon-ptn5150: Add USB analog audio accessory support extcon: extcon-ptn5150: Remove unused variable and extra space drivers/extcon/extcon-ptn5150.c | 135 1 file changed, 82 insertions(+), 53 deletions(-) -- 2.11.0
