Re: [PATCH v1 02/19] x86/insn: Add @buf_len param to insn_init() kernel-doc comment

2020-12-27 Thread Masami Hiramatsu
On Wed, 23 Dec 2020 18:42:16 +0100
Borislav Petkov  wrote:

> From: Borislav Petkov 
> 
> It wasn't documented so add it. No functional changes.
> 

Thank you for fixing!

Acked-by: Masami Hiramatsu 

> Signed-off-by: Borislav Petkov 
> ---
>  arch/x86/lib/insn.c   | 1 +
>  tools/arch/x86/lib/insn.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/arch/x86/lib/insn.c b/arch/x86/lib/insn.c
> index 404279563891..1ba994862b56 100644
> --- a/arch/x86/lib/insn.c
> +++ b/arch/x86/lib/insn.c
> @@ -37,6 +37,7 @@
>   * insn_init() - initialize struct insn
>   * @insn: insn to be initialized
>   * @kaddr:   address (in kernel memory) of instruction (or copy thereof)
> + * @buf_len: length of the insn buffer at @kaddr
>   * @x86_64:  !0 for 64-bit kernel or 64-bit app
>   */
>  void insn_init(struct insn *insn, const void *kaddr, int buf_len, int x86_64)
> diff --git a/tools/arch/x86/lib/insn.c b/tools/arch/x86/lib/insn.c
> index 0151dfc6da61..f3277d6e4ef2 100644
> --- a/tools/arch/x86/lib/insn.c
> +++ b/tools/arch/x86/lib/insn.c
> @@ -37,6 +37,7 @@
>   * insn_init() - initialize struct insn
>   * @insn: insn to be initialized
>   * @kaddr:   address (in kernel memory) of instruction (or copy thereof)
> + * @buf_len: length of the insn buffer at @kaddr
>   * @x86_64:  !0 for 64-bit kernel or 64-bit app
>   */
>  void insn_init(struct insn *insn, const void *kaddr, int buf_len, int x86_64)
> -- 
> 2.29.2
> 


-- 
Masami Hiramatsu 


[PATCH v1 02/19] x86/insn: Add @buf_len param to insn_init() kernel-doc comment

2020-12-23 Thread Borislav Petkov
From: Borislav Petkov 

It wasn't documented so add it. No functional changes.

Signed-off-by: Borislav Petkov 
---
 arch/x86/lib/insn.c   | 1 +
 tools/arch/x86/lib/insn.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/x86/lib/insn.c b/arch/x86/lib/insn.c
index 404279563891..1ba994862b56 100644
--- a/arch/x86/lib/insn.c
+++ b/arch/x86/lib/insn.c
@@ -37,6 +37,7 @@
  * insn_init() - initialize struct insn
  * @insn:   insn to be initialized
  * @kaddr: address (in kernel memory) of instruction (or copy thereof)
+ * @buf_len:   length of the insn buffer at @kaddr
  * @x86_64:!0 for 64-bit kernel or 64-bit app
  */
 void insn_init(struct insn *insn, const void *kaddr, int buf_len, int x86_64)
diff --git a/tools/arch/x86/lib/insn.c b/tools/arch/x86/lib/insn.c
index 0151dfc6da61..f3277d6e4ef2 100644
--- a/tools/arch/x86/lib/insn.c
+++ b/tools/arch/x86/lib/insn.c
@@ -37,6 +37,7 @@
  * insn_init() - initialize struct insn
  * @insn:   insn to be initialized
  * @kaddr: address (in kernel memory) of instruction (or copy thereof)
+ * @buf_len:   length of the insn buffer at @kaddr
  * @x86_64:!0 for 64-bit kernel or 64-bit app
  */
 void insn_init(struct insn *insn, const void *kaddr, int buf_len, int x86_64)
-- 
2.29.2