Re: [PATCH v1 1/1] iio: adc: ad7768-1: Keep fwnode reference count balanced

2021-04-12 Thread Andy Shevchenko 
On Mon, Apr 12, 2021 at 01:19:04PM +0300, Andy Shevchenko wrote:
> The commit 75ed0be7200d ("iio: adc: ad7768-1: Add channel labels.")
> missed the point that loop counter should be put after use. Otherwise
> the reference count of it will become unbalanced.

Scratch this, I might be not slept enough.

-- 
With Best Regards,
Andy Shevchenko

[PATCH v1 1/1] iio: adc: ad7768-1: Keep fwnode reference count balanced

2021-04-12 Thread Andy Shevchenko 
The commit 75ed0be7200d ("iio: adc: ad7768-1: Add channel labels.")
missed the point that loop counter should be put after use. Otherwise
the reference count of it will become unbalanced.

Fixes: 75ed0be7200d ("iio: adc: ad7768-1: Add channel labels.")
Cc: Cristian Pop 
Signed-off-by: Andy Shevchenko 
---
 drivers/iio/adc/ad7768-1.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
index c945f1349623..c488bd4bfeba 100644
--- a/drivers/iio/adc/ad7768-1.c
+++ b/drivers/iio/adc/ad7768-1.c
@@ -565,6 +565,7 @@ static int ad7768_set_channel_label(struct iio_dev 
*indio_dev,
 
st->labels[crt_ch] = label;
}
+   fwnode_handle_put(fwnode);
 
return 0;
 }
-- 
2.31.1