Re: [PATCH v1 14/14] vfio: Cleanup use of bare unsigned

[Christoph Hellwig]

On Mon, Mar 08, 2021 at 09:07:45PM -0400, Jason Gunthorpe wrote:
> Indeed, checkpatch has been warning about this too

And checkaptch as so often these days is completely full of shit.
There is ansolutely not objective reason against using bare unsigned
except for a weird anal preference of a checkpatch author.

Re: [PATCH v1 14/14] vfio: Cleanup use of bare unsigned

[Jason Gunthorpe]

On Mon, Mar 08, 2021 at 02:49:49PM -0700, Alex Williamson wrote:
> Replace with 'unsigned int'.
> 
> Signed-off-by: Alex Williamson 
> ---
>  drivers/vfio/pci/vfio_pci_intrs.c |   42 
> ++---
>  drivers/vfio/pci/vfio_pci_private.h   |4 +-
>  drivers/vfio/platform/vfio_platform_irq.c |   21 +++--
>  drivers/vfio/platform/vfio_platform_private.h |4 +-
>  4 files changed, 39 insertions(+), 32 deletions(-)

Indeed, checkpatch has been warning about this too

Reviewed-by: Jason Gunthorpe 

Again it would be nice to apply it

Jason

[PATCH v1 14/14] vfio: Cleanup use of bare unsigned

[Alex Williamson]

Replace with 'unsigned int'.

Signed-off-by: Alex Williamson 
---
 drivers/vfio/pci/vfio_pci_intrs.c |   42 ++---
 drivers/vfio/pci/vfio_pci_private.h   |4 +-
 drivers/vfio/platform/vfio_platform_irq.c |   21 +++--
 drivers/vfio/platform/vfio_platform_private.h |4 +-
 4 files changed, 39 insertions(+), 32 deletions(-)

diff --git a/drivers/vfio/pci/vfio_pci_intrs.c 
b/drivers/vfio/pci/vfio_pci_intrs.c
index 869dce5f134d..67de58d67908 100644
--- a/drivers/vfio/pci/vfio_pci_intrs.c
+++ b/drivers/vfio/pci/vfio_pci_intrs.c
@@ -364,8 +364,8 @@ static int vfio_msi_set_vector_signal(struct 
vfio_pci_device *vdev,
return 0;
 }
 
-static int vfio_msi_set_block(struct vfio_pci_device *vdev, unsigned start,
- unsigned count, int32_t *fds, bool msix)
+static int vfio_msi_set_block(struct vfio_pci_device *vdev, unsigned int start,
+ unsigned int count, int32_t *fds, bool msix)
 {
int i, j, ret = 0;
 
@@ -418,8 +418,9 @@ static void vfio_msi_disable(struct vfio_pci_device *vdev, 
bool msix)
  * IOCTL support
  */
 static int vfio_pci_set_intx_unmask(struct vfio_pci_device *vdev,
-   unsigned index, unsigned start,
-   unsigned count, uint32_t flags, void *data)
+   unsigned int index, unsigned int start,
+   unsigned int count, uint32_t flags,
+   void *data)
 {
if (!is_intx(vdev) || start != 0 || count != 1)
return -EINVAL;
@@ -445,8 +446,9 @@ static int vfio_pci_set_intx_unmask(struct vfio_pci_device 
*vdev,
 }
 
 static int vfio_pci_set_intx_mask(struct vfio_pci_device *vdev,
- unsigned index, unsigned start,
- unsigned count, uint32_t flags, void *data)
+ unsigned int index, unsigned int start,
+ unsigned int count, uint32_t flags,
+ void *data)
 {
if (!is_intx(vdev) || start != 0 || count != 1)
return -EINVAL;
@@ -465,8 +467,9 @@ static int vfio_pci_set_intx_mask(struct vfio_pci_device 
*vdev,
 }
 
 static int vfio_pci_set_intx_trigger(struct vfio_pci_device *vdev,
-unsigned index, unsigned start,
-unsigned count, uint32_t flags, void *data)
+unsigned int index, unsigned int start,
+unsigned int count, uint32_t flags,
+void *data)
 {
if (is_intx(vdev) && !count && (flags & VFIO_IRQ_SET_DATA_NONE)) {
vfio_intx_disable(vdev);
@@ -508,8 +511,9 @@ static int vfio_pci_set_intx_trigger(struct vfio_pci_device 
*vdev,
 }
 
 static int vfio_pci_set_msi_trigger(struct vfio_pci_device *vdev,
-   unsigned index, unsigned start,
-   unsigned count, uint32_t flags, void *data)
+   unsigned int index, unsigned int start,
+   unsigned int count, uint32_t flags,
+   void *data)
 {
int i;
bool msix = (index == VFIO_PCI_MSIX_IRQ_INDEX) ? true : false;
@@ -614,8 +618,9 @@ static int vfio_pci_set_ctx_trigger_single(struct 
eventfd_ctx **ctx,
 }
 
 static int vfio_pci_set_err_trigger(struct vfio_pci_device *vdev,
-   unsigned index, unsigned start,
-   unsigned count, uint32_t flags, void *data)
+   unsigned int index, unsigned int start,
+   unsigned int count, uint32_t flags,
+   void *data)
 {
if (index != VFIO_PCI_ERR_IRQ_INDEX || start != 0 || count > 1)
return -EINVAL;
@@ -625,8 +630,9 @@ static int vfio_pci_set_err_trigger(struct vfio_pci_device 
*vdev,
 }
 
 static int vfio_pci_set_req_trigger(struct vfio_pci_device *vdev,
-   unsigned index, unsigned start,
-   unsigned count, uint32_t flags, void *data)
+   unsigned int index, unsigned int start,
+   unsigned int count, uint32_t flags,
+   void *data)
 {
if (index != VFIO_PCI_REQ_IRQ_INDEX || start != 0 || count > 1)
return -EINVAL;
@@ -636,11 +642,11 @@ static int vfio_pci_set_req_trigger(struct 
vfio_pci_device *vdev,
 }
 
 int vfio_pci_set_irqs_ioctl(struct vfio_pci_device *vdev, uint32_t flags,
-   unsigned index, unsigned start, unsigned count,
-   void *data)
+   unsigned int