RE: [PATCH v1 2/2] scsi: ufs: Cleanup device vendor and quirk definition

2020-06-11 Thread Stanley Chu 
Hi Alim,

On Thu, 2020-06-11 at 21:04 +0530, Alim Akhtar wrote:
> Hi Stanley
> 
> > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index
> > dea4fddf9332..7c93cb446f51 100644
> > --- a/drivers/scsi/ufs/ufshcd.c
> > +++ b/drivers/scsi/ufs/ufshcd.c
> > @@ -219,10 +219,8 @@ static struct ufs_dev_fix ufs_fixups[] = {
> > UFS_FIX(UFS_VENDOR_MICRON, UFS_ANY_MODEL,
> > UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
> > UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
> > -   UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
> > -   UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
> > -   UFS_DEVICE_QUIRK_RECOVERY_FROM_DL_NAC_ERRORS),
> > -   UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
> > +   UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM |
> > +   UFS_DEVICE_QUIRK_RECOVERY_FROM_DL_NAC_ERRORS |
> > UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE),
> > UFS_FIX(UFS_VENDOR_TOSHIBA, UFS_ANY_MODEL,
> > UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
> > --
> While at this, may be arrange the table in alphabetical order.

Sure, fixed in v2.

Thanks for the review.
Stanley Chu

RE: [PATCH v1 2/2] scsi: ufs: Cleanup device vendor and quirk definition

2020-06-11 Thread Alim Akhtar 
Hi Stanley

> -Original Message-
> From: Stanley Chu 
> Sent: 10 June 2020 11:07
> To: linux-s...@vger.kernel.org; martin.peter...@oracle.com;
> avri.alt...@wdc.com; alim.akh...@samsung.com; j...@linux.ibm.com;
> asuto...@codeaurora.org
> Cc: bean...@micron.com; c...@codeaurora.org; matthias@gmail.com;
> bvanass...@acm.org; linux-media...@lists.infradead.org; linux-arm-
> ker...@lists.infradead.org; linux-kernel@vger.kernel.org;
> kuohong.w...@mediatek.com; peter.w...@mediatek.com; chun-
> hung...@mediatek.com; andy.t...@mediatek.com;
> chaotian.j...@mediatek.com; cc.c...@mediatek.com; Stanley Chu
> 
> Subject: [PATCH v1 2/2] scsi: ufs: Cleanup device vendor and quirk
definition
> 
> Cleanup below items,
> - Arrange vendor name in alphabetical order
> - Squash device quirks as compact as possible in device quirk table
>   to enhance performance of the lookup.
> 
> Signed-off-by: Stanley Chu 
> ---
>  drivers/scsi/ufs/ufs_quirks.h | 2 +-
>  drivers/scsi/ufs/ufshcd.c | 6 ++
>  2 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufs_quirks.h b/drivers/scsi/ufs/ufs_quirks.h
index
> e80d5f26a442..2a0041493e30 100644
> --- a/drivers/scsi/ufs/ufs_quirks.h
> +++ b/drivers/scsi/ufs/ufs_quirks.h
> @@ -13,9 +13,9 @@
>  #define UFS_ANY_MODEL  "ANY_MODEL"
> 
>  #define UFS_VENDOR_MICRON  0x12C
> -#define UFS_VENDOR_TOSHIBA 0x198
>  #define UFS_VENDOR_SAMSUNG 0x1CE
>  #define UFS_VENDOR_SKHYNIX 0x1AD
> +#define UFS_VENDOR_TOSHIBA 0x198
>  #define UFS_VENDOR_WDC 0x145
> 
>  /**
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index
> dea4fddf9332..7c93cb446f51 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -219,10 +219,8 @@ static struct ufs_dev_fix ufs_fixups[] = {
>   UFS_FIX(UFS_VENDOR_MICRON, UFS_ANY_MODEL,
>   UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
>   UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
> - UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
> - UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
> - UFS_DEVICE_QUIRK_RECOVERY_FROM_DL_NAC_ERRORS),
> - UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
> + UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM |
> + UFS_DEVICE_QUIRK_RECOVERY_FROM_DL_NAC_ERRORS |
>   UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE),
>   UFS_FIX(UFS_VENDOR_TOSHIBA, UFS_ANY_MODEL,
>   UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
> --
While at this, may be arrange the table in alphabetical order.

> 2.18.0

[PATCH v1 2/2] scsi: ufs: Cleanup device vendor and quirk definition

2020-06-09 Thread Stanley Chu 
Cleanup below items,
- Arrange vendor name in alphabetical order
- Squash device quirks as compact as possible in device quirk table
  to enhance performance of the lookup.

Signed-off-by: Stanley Chu 
---
 drivers/scsi/ufs/ufs_quirks.h | 2 +-
 drivers/scsi/ufs/ufshcd.c | 6 ++
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/ufs/ufs_quirks.h b/drivers/scsi/ufs/ufs_quirks.h
index e80d5f26a442..2a0041493e30 100644
--- a/drivers/scsi/ufs/ufs_quirks.h
+++ b/drivers/scsi/ufs/ufs_quirks.h
@@ -13,9 +13,9 @@
 #define UFS_ANY_MODEL  "ANY_MODEL"
 
 #define UFS_VENDOR_MICRON  0x12C
-#define UFS_VENDOR_TOSHIBA 0x198
 #define UFS_VENDOR_SAMSUNG 0x1CE
 #define UFS_VENDOR_SKHYNIX 0x1AD
+#define UFS_VENDOR_TOSHIBA 0x198
 #define UFS_VENDOR_WDC 0x145
 
 /**
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index dea4fddf9332..7c93cb446f51 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -219,10 +219,8 @@ static struct ufs_dev_fix ufs_fixups[] = {
UFS_FIX(UFS_VENDOR_MICRON, UFS_ANY_MODEL,
UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
-   UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
-   UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
-   UFS_DEVICE_QUIRK_RECOVERY_FROM_DL_NAC_ERRORS),
-   UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
+   UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM |
+   UFS_DEVICE_QUIRK_RECOVERY_FROM_DL_NAC_ERRORS |
UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE),
UFS_FIX(UFS_VENDOR_TOSHIBA, UFS_ANY_MODEL,
UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
-- 
2.18.0