Re: [PATCH v1 2/3] Documentation: dt-bindings: add dt binding info for dwc2 reset control
lyz, On Tue, Aug 11, 2015 at 12:56 AM, Yunzhi Li wrote: > Signed-off-by: Yunzhi Li > --- > > Documentation/devicetree/bindings/usb/dwc2.txt | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt > b/Documentation/devicetree/bindings/usb/dwc2.txt > index fd132cb..6a84099 100644 > --- a/Documentation/devicetree/bindings/usb/dwc2.txt > +++ b/Documentation/devicetree/bindings/usb/dwc2.txt > @@ -24,6 +24,12 @@ Refer to phy/phy-bindings.txt for generic phy consumer > properties > - g-rx-fifo-size: size of rx fifo size in gadget mode. > - g-np-tx-fifo-size: size of non-periodic tx fifo size in gadget mode. > - g-tx-fifo-size: size of periodic tx fifo per endpoint (except ep0) in > gadget mode. > +- resets: A list of phandle + reset-specifier pairs for the resets listed in > + reset-names > +- reset-names: Should contain the following: > + "ahb": AHB interface reset > + "phy": PHY reset > + "con": controller reset Would it be worth it to leave the "phy" out? You don't use it in the driver yet and it's unclear to me whether it belongs here or as part of "rockchip,rk3288-usb-phy"? -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v1 2/3] Documentation: dt-bindings: add dt binding info for dwc2 reset control
Signed-off-by: Yunzhi Li --- Documentation/devicetree/bindings/usb/dwc2.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt index fd132cb..6a84099 100644 --- a/Documentation/devicetree/bindings/usb/dwc2.txt +++ b/Documentation/devicetree/bindings/usb/dwc2.txt @@ -24,6 +24,12 @@ Refer to phy/phy-bindings.txt for generic phy consumer properties - g-rx-fifo-size: size of rx fifo size in gadget mode. - g-np-tx-fifo-size: size of non-periodic tx fifo size in gadget mode. - g-tx-fifo-size: size of periodic tx fifo per endpoint (except ep0) in gadget mode. +- resets: A list of phandle + reset-specifier pairs for the resets listed in + reset-names +- reset-names: Should contain the following: + "ahb": AHB interface reset + "phy": PHY reset + "con": controller reset Example: -- 2.0.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v1 2/3] Documentation: dt-bindings: add dt binding info for dwc2 reset control
Signed-off-by: Yunzhi Li l...@rock-chips.com --- Documentation/devicetree/bindings/usb/dwc2.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt index fd132cb..6a84099 100644 --- a/Documentation/devicetree/bindings/usb/dwc2.txt +++ b/Documentation/devicetree/bindings/usb/dwc2.txt @@ -24,6 +24,12 @@ Refer to phy/phy-bindings.txt for generic phy consumer properties - g-rx-fifo-size: size of rx fifo size in gadget mode. - g-np-tx-fifo-size: size of non-periodic tx fifo size in gadget mode. - g-tx-fifo-size: size of periodic tx fifo per endpoint (except ep0) in gadget mode. +- resets: A list of phandle + reset-specifier pairs for the resets listed in + reset-names +- reset-names: Should contain the following: + ahb: AHB interface reset + phy: PHY reset + con: controller reset Example: -- 2.0.0 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 2/3] Documentation: dt-bindings: add dt binding info for dwc2 reset control
lyz, On Tue, Aug 11, 2015 at 12:56 AM, Yunzhi Li l...@rock-chips.com wrote: Signed-off-by: Yunzhi Li l...@rock-chips.com --- Documentation/devicetree/bindings/usb/dwc2.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt index fd132cb..6a84099 100644 --- a/Documentation/devicetree/bindings/usb/dwc2.txt +++ b/Documentation/devicetree/bindings/usb/dwc2.txt @@ -24,6 +24,12 @@ Refer to phy/phy-bindings.txt for generic phy consumer properties - g-rx-fifo-size: size of rx fifo size in gadget mode. - g-np-tx-fifo-size: size of non-periodic tx fifo size in gadget mode. - g-tx-fifo-size: size of periodic tx fifo per endpoint (except ep0) in gadget mode. +- resets: A list of phandle + reset-specifier pairs for the resets listed in + reset-names +- reset-names: Should contain the following: + ahb: AHB interface reset + phy: PHY reset + con: controller reset Would it be worth it to leave the phy out? You don't use it in the driver yet and it's unclear to me whether it belongs here or as part of rockchip,rk3288-usb-phy? -Doug -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
